Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 317565 - sys-apps/coreutils-8.4 fails tests (misc/sort-mb-tests.log)
Summary: sys-apps/coreutils-8.4 fails tests (misc/sort-mb-tests.log)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-28 03:17 UTC by T Chan
Modified: 2010-05-08 17:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,97.90 KB, text/plain)
2010-05-02 01:15 UTC, T Chan
Details
Patchpatch </xzibit> (000_all_coreutils-i18n.patch.patch,1002 bytes, patch)
2010-05-05 22:32 UTC, T Chan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description T Chan 2010-04-28 03:17:07 UTC
With FEATURES='-sandbox -usersandbox' (works around bug #297026):
# grep '\*\*\*' build.log
make[4]: *** No rule to make target `misc/sort-mb-tests.log', needed by
`test-suite.log'.
make[3]: *** [check-TESTS] Error 2
make[2]: *** [check-am] Error 2
make[1]: *** [check-recursive] Error 1
make: *** [check] Error 2

The bug seems to be in 000_all_coreutils-i18n.patch: the patch adds tests/misc/sort-mb-tests but somehow it doesn't run, and make complains that the log doesn't exist.


Reproducible: Always

Steps to Reproduce:
Comment 1 T Chan 2010-05-02 01:15:44 UTC
Created attachment 229965 [details]
build.log
Comment 2 SpanKY gentoo-dev 2010-05-04 04:22:17 UTC
the test doesnt exist when USE=vanilla
Comment 3 T Chan 2010-05-05 22:32:32 UTC
Created attachment 230547 [details, diff]
Patchpatch </xzibit>

The root cause seems to be that the new test isn't executable. This does not stop it from running, but stops Makefile.am from picking it up when producing Makefile.in. The simple fix is to unpack, chmod +x tests/misc/sort-mb-tests, and run autoconf.

Attached is a patchpatch which fixes the original patch by adding sort-mb-tests to Makefile.in. I'm not sure what the canonical way of fixing Gentoo patches is, but this seems to be the simplest way of fixing it in a portage overlay, requiring only a simple addition to the ebuild:

--- /usr/portage/sys-apps/coreutils/coreutils-8.4.ebuild        2010-04-08 13:07:10.000000000 +0000
+++ /usr/local/portage/sys-apps/coreutils/coreutils-8.4.ebuild  2010-05-05 03:33:15.000000000 +0000
@@ -42,2 +42,3 @@
        if ! use vanilla ; then
+               patch "${WORKDIR}"/patch/000_all_coreutils-i18n.patch < "${FILESDIR}"/000_all_coreutils-i18n.patch.patch
                use unicode || rm -f "${WORKDIR}"/patch/000_all_coreutils-i18n.patch
Comment 4 SpanKY gentoo-dev 2010-05-08 17:37:36 UTC
thanks, added that patch to 8.4