when applying diffstat to 20_dc395-integ24 from patches-2.4.20-xfs-r3.tar.bz2 from current gentoo mirrors, it reports over 8000 lines of changes in Makefile. However those changes don't belong to the Makefile but to a file listed in the patch after the Makefile Reproducible: Always Steps to Reproduce: 1. ebuild /usr/portage/sys-kernel/xfs-sources/xfs-sources-2.4.20-xfs-r3.ebuild fetch 2. cd /tmp && tar xjf /usr/portage/distfiles/patches-2.4.20-xfs-r3.tar.bz2; cd 2.4.20-xfs-r3 3. diffstat 20_dc395-integ24 Actual Results: Documentation/Configure.help | 13 MAINTAINERS | 6 drivers/scsi/Config.in | 3 drivers/scsi/Makefile | 8047 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 8067 insertions(+), 2 deletions(-) Expected Results: Documentation/Configure.help | 13 MAINTAINERS | 6 drivers/scsi/Config.in | 3 drivers/scsi/Makefile | 1 drivers/scsi/dc395x_trm.c | 7903 +++++++++++++++++++++++++++++++++++++++++++ drivers/scsi/dc395x_trm.h | 143 ++ 6 files changed, 8067 insertions(+), 2 deletions(-) diffstat 1.29 installed
Created attachment 19611 [details, diff] Adds a new sscanf line to match yyyy-mm-dd diff output. The problem here is that the diff output for dc395x_trm.* contained headers with: 2002-12-22 18:34:27 2002-06-21 11:57:38 This year/time format was not supported by diffstat. This patch adds a sscanf line to handle such headers.
Nice catch Jochen and thanks for the patch Doug. diffstat now handles files with hard-locale headers. :)
I've just made a 1.34 ebuild of diffstat, however the 1.29 patch for this issue does not apply. The codebases are too drastically altered (AFAICT). Someone mind double checking this to see if such a patch is needed for this version as well and let me know via a new bug?
Created attachment 25648 [details, diff] above patch for diffstat 1.34
Thanks, applied, remerge the 1.34 ebuild for the patch.
