Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 31671 - pinstall patch for OpenAFS fails
Summary: pinstall patch for OpenAFS fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High blocker (vote)
Assignee: Ryan Phillips (RETIRED)
URL:
Whiteboard:
Keywords:
: 31822 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-10-21 06:50 UTC by David Brigada
Modified: 2003-11-23 20:42 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch fail message (openafs-pinstall-execve.patch-2755.out,3.39 KB, text/plain)
2003-10-21 06:52 UTC, David Brigada
Details
execve patch for 1.2.10 (openafs-pinstall-execve-1.2.10.patch,1.21 KB, patch)
2003-11-17 14:15 UTC, Ian
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Brigada 2003-10-21 06:50:40 UTC
Whenever I attempt to emerge openafs; any version; I get the following error:

eph files # emerge openafs
Calculating dependencies ...done!
>>> emerge (1 of 1) net-fs/openafs-1.2.10-r1 to /
>>> md5 src_uri ;-) openafs-1.2.10-src.tar.bz2
>>> Unpacking source...
>>> Unpacking openafs-1.2.10-src.tar.bz2 to /var/tmp/portage/openafs-1.2.10-r1/work
 * Applying openafs-pinstall-execve.patch...

 * Failed Patch: openafs-pinstall-execve.patch!
 * 
 * Include in your bugreport the contents of:
 * 
 *   /var/tmp/portage/openafs-1.2.10-r1/temp/openafs-pinstall-execve.patch-2573.out


!!! ERROR: net-fs/openafs-1.2.10-r1 failed.
!!! Function epatch, Line 354, Exitcode 0
!!! Failed Patch: openafs-pinstall-execve.patch!

eph files # 

Reproducible: Always
Steps to Reproduce:
1. emerge openafs
2.
3.

Actual Results:  
Above error message results

Expected Results:  
It should have emerged openafs

Portage 2.0.49-r13 (default-x86-1.4, gcc-3.3.1, glibc-2.3.2-r6, 2.4.22-ac4)
=================================================================
System uname: 2.4.22-ac4 i686 Intel(R) Pentium(R) M processor 1600MHz
Gentoo Base System version 1.4.3.11
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=pentium3 -O3 -fomit-frame-pointer -funroll-loops"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /var/qmail/control /usr/share/config /usr/kde/2/share/confi
g /usr/kde/3/share/config /usr/X11R6/lib/X11/xkb /usr/share/texmf/tex/generic/co
nfig/ /usr/share/texmf/tex/platex/config/"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-O2 -mcpu=i686 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="sandbox ccache autoaddcvs"
GENTOO_MIRRORS="http://gentoo.mirrors.pair.com/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://acm.cs.rpi.edu/gentoo-portage"
USE="x86 oss apm avi crypt cups encode foomaticdb gif jpeg libg++ mad mpeg ncurs
es pdflib png quicktime spell truetype xml2 xv zlib directfb gdbm berkdb slang r
eadline tetex aalib ggi tcltk java ruby mysql X sdl gpm tcpd pam libwww ssl perl
 python esd imlib oggvorbis gtk opengl mozilla ldap apache2 bluetooth cdr cscope
 curl dedicated dga doc dvd fbcon flash gd gstreamer gtk2 imagemagick ipv6 jikes
 kerberos lcd lcms mbox md5sum mmx mng php plotutils pnp ppds radeon samba sse t
iff usb xml -arts -kde -gnome -mikmod -nls -qt -svga -xmms -motif"
Comment 1 David Brigada 2003-10-21 06:52:48 UTC
Created attachment 19582 [details]
Patch fail message

This is the output from the patch command.
Comment 2 Jonathan Manning 2003-10-25 19:28:40 UTC
There's lots of dups for this bug - but some refer 1.2.8, which is a different
problem...
In the current stable version - 1.2.8, the patch refuses to apply at all.
This is due to a cd $[S}/src/config in the unpack section before the epatch.
Adding the line 'cd ${S}' just above the epatch line fixes this problem.

However, in the latest version 1.2.10-r1, the patch finds its target, but
all hunks fail. This is what is reported here.

A quick look at src/pinstall/install.c shows the differences that causes
the patch to fail. While the changes are not identical to the patch, they
appear to be an alternative solution to the problem the patch is trying to
fix. (Did that make sense?)

I don't know enough about the problem or the proper solution to evaluate
it. From my inexperienced viewpoint, the gentoo patch is still better, since
it creates an empty environment for execve. The old (bad) code just had NULL
for the environment, the official fix replaces NULL with 0.

The answer to this can probably be found in some openafs mailing list archive.

So, once someone else fills in those details then:
If the new official fix in 1.2.10 is good enough, the patch is no longer
needed in 1.2.10 and should be removed from the ebuild.
If it's not enough, then a new patch needs to be created based on the new
source, since all lines covered by the patch have now changed.
Comment 3 Ryan Phillips (RETIRED) gentoo-dev 2003-10-27 16:41:56 UTC
I've removed the patch... Does anyone know if it is really needed?
Comment 4 Ryan Phillips (RETIRED) gentoo-dev 2003-10-27 16:50:40 UTC
*** Bug 31822 has been marked as a duplicate of this bug. ***
Comment 5 alexander j pierce 2003-10-28 06:39:07 UTC
yes.. still needed.  here is the results of the compile:


/var/tmp/portage/openafs-1.2.10-r1/work/openafs-1.2.10/src/pinstall/pinstall
libprocmgmt.a
/var/tmp/portage/openafs-1.2.10-r1/work/openafs-1.2.10/lib/libprocmgmt.a
Bad exit code from /bin/cp: 139
Could not open output temp file
``/var/tmp/portage/openafs-1.2.10-r1/work/openafs-1.2.10/lib/libprocmgmt.a.hostname'':
No such file or directory
make[3]: ***
[/var/tmp/portage/openafs-1.2.10-r1/work/openafs-1.2.10/lib/libprocmgmt.a]
Error 1
make[3]: Leaving directory `/var/tmp/portage/openafs-1.2.10-r1/work/openafs-1.2.10/src/procmgmt'
make[2]: *** [procmgmt] Error 2
make[2]: Leaving directory `/var/tmp/portage/openafs-1.2.10-r1/work/openafs-1.2.10'
make[1]: *** [build] Error 2
make[1]: Leaving directory `/var/tmp/portage/openafs-1.2.10-r1/work/openafs-1.2.10'
make: *** [all] Error 2

!!! ERROR: net-fs/openafs-1.2.10-r1 failed.
!!! Function src_compile, Line 50, Exitcode 2
!!! (no error message)


Portage 2.0.49-r15 (default-x86-1.4, gcc-3.3.2, glibc-2.3.2-r8, 2.4.20-gentoo-r8)
=================================================================
System uname: 2.4.20-gentoo-r8 i686 Intel(R) Xeon(TM) CPU 2.80GHz
Gentoo Base System version 1.4.3.11
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -march=pentium4 -funroll-loops -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /var/qmail/control /usr/kde/2/share/config /usr/kde/3/share/config
/usr/X11R6/lib/X11/xkb /usr/kde/3.1/share/config /usr/share/config"
CONFIG_PROTECT_MASK="/etc/afs/C /etc/afs/afsws /etc/gconf /etc/env.d"
CXXFLAGS="-O2 -march=pentium4 -funroll-loops -fomit-frame-pointer -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="sandbox ccache autoaddcvs"
GENTOO_MIRRORS="http://gentoo.ccccom.com http://gentoo.noved.org/ http://adelie.polymtl.ca/
http://gentoo.chem.wisc.edu/gentoo/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 oss apm avi crypt cups encode foomaticdb gif jpeg libg++ libwww
mad mikmod mpeg ncurses pdflib png quicktime spell truetype xml2 xmms xv
zlib alsa gdbm berkdb slang readline arts aalib svga java ruby postgres X
sdl tcpd pam ssl perl python imlib oggvorbis gnome gtk qt kde ldap afs apache2
artswrappersuid bonobo cdr cscope curl dedicated dga directfb dnd dv dvd
esd ethereal faad fbcon fltk glut gnomedb gphoto2 gstreamer gtk2 gtkhtml
guile icc imagemagick imap jack lcms lua maildir mldonkeypango mng mozcalendar
mozilla mozp3p mozsvg mpi offensive openal opengl parse-clocks pic sasl skey
slp sse tcltk tiff transcode usb videos wmf wxwin wxwindows Xaw3d xface xine
xml xosd xvid -gpm -motif -nls video_cards_nvidia"
Comment 6 Steven Jenkins 2003-11-06 23:46:03 UTC
The official OpenAFS delta was applied between two revisions on the main
CVS trunk. It doesn't work against the 1.2.10 branch. Might as well continue
using the previous Gentoo patch for 1.2.10-r*. The patch is definitely necessary,
at least on x86.

The Gentoo patch will not be needed for OpenAFS 1.2.11 and later. My suggestion
in Bug 26287 that the Gentoo patch can be replaced with this delta in 1.2.10-r1
was in error.
Comment 7 Ian 2003-11-17 14:15:06 UTC
Created attachment 20877 [details, diff]
execve patch for 1.2.10

Working patch for execve
Comment 8 Charlie Brackett 2003-11-19 12:19:04 UTC
This patch worked for me.  Now I just need to figure out how to configure it.
Comment 9 Ryan Phillips (RETIRED) gentoo-dev 2003-11-21 10:26:02 UTC
I've committed the patch for ebuilds >= 1.2.10 that are in the repository. Please test.
Comment 10 Steven Jenkins 2003-11-23 20:42:09 UTC
Compiles and appears to work for me with the following setup:

System uname: 2.4.20-gentoo-r8 i686 Pentium III (Coppermine)
Gentoo Base System version 1.4.3.10p1
distcc 2.11.1 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [enabled]
ccache version 2.3 [enabled]
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-march=pentium3 -O3 -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /var/qmail/control /usr/kde/2/share/config /usr/kde/3/share/config /usr/X11R6/lib/X11/xkb /usr/kde/3.1/share/config /usr/share/config"
CONFIG_PROTECT_MASK="/etc/afs/C /etc/afs/afsws /etc/gconf /etc/env.d"
CXXFLAGS="-O2 -mcpu=i686 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="sandbox autoaddcvs ccache distcc"
GENTOO_MIRRORS="http://gentoo.oregonstate.edu http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 oss apm avi crypt cups encode foomaticdb gif jpeg kde libg++ mad mikmod mpeg ncurses nls pdflib png quicktime spell truetype xml2 xmms xv zlib gtkhtml alsa gdbm berkdb slang readline arts tetex bonobo svga tcltk java guile ruby mysql postgres sdl gpm tcpd pam libwww ssl perl python esd imlib oggvorbis qt motif opengl mozilla ldap cdr X gtk gnome gtk2 afs distcc dvd"