314791 – dev-util/cvs crash on FreeBSD at cvs init

Bug 314791 - dev-util/cvs crash on FreeBSD at cvs init

Summary: dev-util/cvs crash on FreeBSD at cvs init

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo/Alt
Classification:	Unclassified
Component:	FreeBSD (show other bugs)
Hardware:	All FreeBSD

Importance:	High normal (vote)
Assignee:	Maintainers for cvs, and cvs related tools (the version control system) [OBSOLETE]

URL:	http://savannah.nongnu.org/bugs/?29466
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-04-12 09:00 UTC by Javier Villavicencio (RETIRED)
Modified:	2010-04-15 23:34 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Javier Villavicencio (RETIRED) gentoo-dev

2010-04-12 09:00:04 UTC

FreeBSD has slightly different wording for getdelim(), they expect a size=0 to append to the buffer, while on linux getdelim() expects a null pointer to do the same thing. Setting both (0/null) solves the problem.

Patch is tiny:
http://savannah.nongnu.org/bugs/download.php?file_id=20154

And already reported upstream.

Comment 1 Christian Faulhammer (RETIRED) gentoo-dev

2010-04-12 11:35:06 UTC

Looks fine on x86-fbsd.

Comment 2 Robin Johnson archtester

2010-04-12 18:31:46 UTC

prefix: +1 for commit with revbump

Comment 3 Javier Villavicencio (RETIRED) gentoo-dev

2010-04-15 23:34:13 UTC

Fixed in cvs-1.12.12-r8, let me know if we want this on the masked versions too.

And it's already applied upstream:
http://cvs.savannah.gnu.org/viewvc/ccvs/src/myndbm.c?root=cvs&r1=1.38&r2=1.39