Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 313959 - sys-apps/dbus should depend on gentoolkit
Summary: sys-apps/dbus should depend on gentoolkit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-08 19:53 UTC by Dirk-Lüder Kreie
Modified: 2010-04-20 11:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to change ewarn message to contain more specific information (dbus-ebuild-ewarn.patch,578 bytes, patch)
2010-04-20 11:29 UTC, Dirk-Lüder Kreie
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk-Lüder Kreie 2010-04-08 19:53:02 UTC
dbus *requires* revdep-rebuild to run after emerge, so should depend on gentoolkit.


Reproducible: Always

Steps to Reproduce:
1. have no gentoolkit
2. emerge dbus
3. try to run revdep-rebuild
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2010-04-08 21:54:27 UTC
not really, there's several ways of fixing the system. 
portage-2.2's preserved-libs feature, manual emerging, and revdep-rebuild.
it's up to you to pick one.
Comment 2 Harald van Dijk (RETIRED) gentoo-dev 2010-04-10 18:29:55 UTC
(In reply to comment #1)
> not really, there's several ways of fixing the system. 
> portage-2.2's preserved-libs feature, manual emerging, and revdep-rebuild.
> it's up to you to pick one.

dbus's pkg_postinst disagrees:

  "You MUST run 'revdep-rebuild' after emerging this package"

You're right, of course, gentoolkit should definitely not be a dependency for dbus and there are other options of fixing any problems. Reopening anyway because the warning is a bug. I suggest something like

  "Please run 'revdep-rebuild' (provided by app-portage/gentoolkit) to ensure programs are linked with the current version of dbus"

and also try to make sure to give that warning only when upgrading from an older dbus with a different SONAME.
Comment 3 Pacho Ramos gentoo-dev 2010-04-10 18:37:41 UTC
Maybe a function to show an unified message related with the need of run revdep-rebuild (or everything else) could be included in eutils.eclass to:
1. Prevent problems like this
2. Get all ebuilds showing the same, proper and clear message about this
3. Save a few lines on every ebuild needing to show this info
Comment 4 Brian Dolbec (RETIRED) gentoo-dev 2010-04-11 08:36:48 UTC
I believe there are other things in the works for a future EAPI that will allow an ebuild to revdep-rebuild (sort of) the pkgs depending on it when it changes.
Comment 5 Steev Klimaszewski (RETIRED) gentoo-dev 2010-04-11 09:31:55 UTC
Realistically, the comment should be removed, however I'm always cautious about removing something like that, because the second I do, its likely that someone will need that comment.  

Yes, the wording on it also sucks, it was written back before portage had @preserved-libs or whatever it has, and the myriad of options available now.

Comment 6 Dirk-Lüder Kreie 2010-04-11 16:00:35 UTC
The original reason for this bug report was that I can never remember which ebuild installs revdep-rebuild whenever I set up a new box, so perhaps just change te comment to "you MUST run revdep-rebuild from gentoolkit or similar" or something to that effect.
Comment 7 Dirk-Lüder Kreie 2010-04-20 11:29:21 UTC
Created attachment 228499 [details, diff]
patch to change ewarn message to contain more specific information
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2010-04-20 11:36:21 UTC
+  20 Apr 2010; Samuli Suominen <ssuominen@gentoo.org> dbus-1.2.3-r1.ebuild,
+  dbus-1.2.24.ebuild, dbus-1.3.0-r1.ebuild:
+  Remove outdated revdep-rebuild message wrt #313959 by Dirk-Lüder Kreie.