Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 313731 - Portage fixes shebangs of files that are ought not to be fixed (autotools)
Summary: Portage fixes shebangs of files that are ought not to be fixed (autotools)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-07 19:06 UTC by Fabian Groffen
Modified: 2010-04-24 15:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Groffen gentoo-dev 2010-04-07 19:06:22 UTC
This is mainly a reminder for myself.

I recently discovered that automake --copy --add-missing would copy in lots of files with my prefix' /bin/sh as shebang.  This is obviously not right.

While fixing shebangs is cool for the health of a Prefix, it makes autotools totally useless for a development system.  Any extra ideas/thoughts are welcome here.

I thought that perhaps we should only fix tools that reside in path, like we already do check now to see if we have to die or just warn.  Question is if this is enough.  Alternative is to exclude e.g. usr/share/* from shebanging, which makes sense, but should be covered by the path check too...
Comment 1 Fabian Groffen gentoo-dev 2010-04-23 19:14:09 UTC
haubi, if you agree, I'm going to implement and release this change (only autofix what's in $PATH).
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-04-23 19:21:42 UTC
I'm in favor of excluding anything not in $PATH. But, who's PATH is is exactly - user's or portage's ?
Comment 3 Fabian Groffen gentoo-dev 2010-04-23 19:24:16 UTC
Portage's of course.
Comment 4 Michael Haubenwallner (RETIRED) gentoo-dev 2010-04-24 11:17:46 UTC
Can't think of any problem here, so fine with me too, thanks!
Comment 5 Fabian Groffen gentoo-dev 2010-04-24 15:20:29 UTC
I committed this to 2.2.00.15842-r1