Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 312855 - net-misc/mediatomb-0.12.0-r1 does not have an USE flag for libextractor
Summary: net-misc/mediatomb-0.12.0-r1 does not have an USE flag for libextractor
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Jeremy Olexa (darkside) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-02 18:34 UTC by John Lowry
Modified: 2010-04-08 17:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libextractor patch (mediatomb-libextractor.patch,1.43 KB, patch)
2010-04-02 23:37 UTC, BT
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Lowry 2010-04-02 18:34:09 UTC
Mediatomb includes optional support for libextractor. net-misc/mediatomb-0.11 included a use flag for it, however 0.12-r1 does not.

Reproducible: Always

Steps to Reproduce:
1. emerge =net-misc/mediatomb-0.12-r1

Actual Results:  
mediatomb build but does not include the libextractor support.

Expected Results:  
A USE flags for libextractor
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-04-02 18:42:18 UTC
I assume it is enabled by default. I don't know the history of this flag though.
Comment 2 John Lowry 2010-04-02 19:22:30 UTC
No, in the configure script it is disabled by default, I am looking at 0.11 right now. I am looking at how to enable it again with a patch. 
Comment 3 BT 2010-04-02 23:37:44 UTC
Created attachment 226327 [details, diff]
libextractor patch

This patch against 0.12.0-r1 enables libextractor support. There is a messy if/elif/else section in src_configure which probably could be done better but I don't know how :(

Upstream used to have libextractor disabled by default because it was very slow and was known to leak memory. I don't know if this is still the case. Enabling libextractor also has the side effect of disabling ffmpeg and and ffmpegthumbnailer support.
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-04-08 04:58:57 UTC
We should probably elog the fact that libextractor is disabled even when requested in the case. Thanks for the patch, I'll commit it soon.
Comment 5 BT 2010-04-08 05:15:19 UTC
(In reply to comment #4)
> We should probably elog the fact that libextractor is disabled even when
> requested in the case. Thanks for the patch, I'll commit it soon.
> 

No problem :)

Just to let you know that 0.12.1 has also been released which fixes YouTube support. It was broken after the recent YouTube website changes.
Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-04-08 17:13:40 UTC
Thanks. Added use flag to 0.12.1