Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 312671 - Rename BASH_COMPLETION_NAME in bash-completion.eclass
Summary: Rename BASH_COMPLETION_NAME in bash-completion.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Jeremy Olexa (darkside) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-01 16:37 UTC by Christian Ruppert (idl0r)
Modified: 2010-04-07 10:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ruppert (idl0r) gentoo-dev 2010-04-01 16:37:43 UTC
We noticed that BASH_COMPLETION_NAME will be ignored always and Zac told us about a filter for BASH_.* variables.

"< zmedico> idl0r: oh, we have a blanket filter for BASH_.* because typically those are bash internals and it has issues with them being set"
"< zmedico> I'd suggest not using variables that start with BASH_ :)"

So we have to choose a new name, what about BASHCOMPLETION_NAME instead?

The following packages are currently using this variable:
app-office/openoffice
app-portage/udept
dev-libs/dbus-glib
gnome-extra/gdesklets-core
sys-apps/paludis

And last but not least:
vim.eclass
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-04-02 14:21:25 UTC
I agree, let's call it BASHCOMPLETION_NAME.

If this is the whole list, let's just make the changes and reference this bug. I think it in non-evasive enough.
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-04-07 04:23:40 UTC
Fixed everything, thanks for the analysis and reporting.
Comment 3 urcindalo 2010-04-07 07:43:36 UTC
Please excuse my ignorance. I already have openoffice-3.2.0 installed on my amd64 box.

Does this mean I have to re-emerge the affected packages to use the new variable name?
Comment 4 Christian Ruppert (idl0r) gentoo-dev 2010-04-07 10:09:16 UTC
(In reply to comment #3)
> Please excuse my ignorance. I already have openoffice-3.2.0 installed on my
> amd64 box.
> 
> Does this mean I have to re-emerge the affected packages to use the new
> variable name?
> 

Not all.
dev-libs/dbus-glib yes,
not sure about sys-apps/paludis.