Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 311109 - sys-fs/xfsprogs-3.1.2 bump request
Summary: sys-fs/xfsprogs-3.1.2 bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on: 333155
Blocks: 332907
  Show dependency tree
 
Reported: 2010-03-24 11:12 UTC by Hendrik Leppkes
Modified: 2015-09-12 05:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xfsprogs-3.1.1 ebuild (xfsprogs-3.1.1.tar,10.00 KB, application/octet-stream)
2010-03-31 21:21 UTC, Hendrik Leppkes
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hendrik Leppkes 2010-03-24 11:12:06 UTC
version 3.1.0 and 3.1.1 have been available for a pretty long time now (7 weeks for 3.1.1)

Tarball available here:
ftp://oss.sgi.com/projects/xfs/

Reproducible: Always

Steps to Reproduce:
Comment 1 Hendrik Leppkes 2010-03-24 11:28:30 UTC
I gathered some information about package changes, and the most important change is that its now using libblkid from >=util-linux-2.17

I'll try and bump the old ebuild myself and post it here for a developer to check it out.
Comment 2 Hendrik Leppkes 2010-03-31 21:21:47 UTC
Created attachment 226023 [details]
xfsprogs-3.1.1 ebuild

I modified the 3.0.3 ebuild and updated it for 3.1.1. It builds and works fine for me, however i'm not 100% sure i did everything right with the ebuild. But it should get whoever wants to take care of this started, at least.

Quick notes on what changed from 3.0.3:
- New sharedlibs patch that applies against 3.1.1
- Using libblkid-2.17 from >=util-linux-2.17
- libdisk is no longer build (replaced by libblkid)
Comment 3 Joe Kappus 2010-05-27 07:20:42 UTC
Can we get a somewhat recent version of xfsprogs merged?  It's only been a year since we checked for a new release.

http://old.nabble.com/Enabling-lazy-counters-damages-filesystem-td28389688.html << these ancient versions are getting affected by bugs like this.  And worse too, just run a quick google search.

Just toasted a drive because of issues with these old utilities.  I guess I didn't need my data.
Comment 4 Tiziano Müller (RETIRED) gentoo-dev 2010-06-03 21:34:54 UTC
ok, I needed the new version on some servers and took the liberty to bump it.
I gave it a pretty good amount of testing, so any combination of {readline,static,static-libs} USE flags are supposed to work. libedit although needs some testing and we have to check whether the static executables are usable without a glibc when building with USE=readline (the compiler says something about it).
There are also two TODOs in the ebuild someone might want to give a try (nothing important: when doing a static build you need -lncurses if you have -lreadline and you need -luuid for -lblkid, the latter could be solved if configure.in would use pkg-config).

... and because of all the above the bump is still p.masked, so it's the base-system team's call to either drop it again, drop my changes or unmask it.
Comment 5 Joe Kappus 2010-07-16 04:00:06 UTC
Just something to add.  You might wanna add a check to this to make sure the user isn't running kernel <=2.6.22.  The new mkfs sets lazy-count=1 by default and will not mount on an old system.  However lazy-count can be toggled by the xfs_admin tool offline.

Interestingly enough, with the old versions of xfsprogs, this functionality was broken so it's NOT possible to toggle it off with the stable version.  In this case, it's probably best to unmask this version because without it a user cannot mount a recently created xfs partition.  (xfs_admin is broken)

Just some food for thought.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2010-08-17 11:03:01 UTC
broken...

 * QA Notice: The following files contain insecure RUNPATHs
 *  Please file a bug about this at http://bugs.gentoo.org/
 *  with the maintaining herd of the package.
 * /var/tmp/portage/sys-fs/xfsprogs-3.1.2/work/xfsprogs-3.1.2/libxfs/.libs lib64/libxlog.so.0.0.0
Comment 7 SpanKY gentoo-dev 2010-08-17 13:15:53 UTC
ive cleaned up the library install and changed the preference to readline as this is what the upstream code does

as for parallel install failures, i'll need to see a full build log (seems to work on my 4 core machine)

as for the rpath issue, i'll also need a full build log as i'm not getting that
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2010-08-17 14:00:38 UTC
(In reply to comment #7)
> as for parallel install failures, i'll need to see a full build log (seems to
> work on my 4 core machine)

4 core here too, bug 333155

> 
> as for the rpath issue, i'll also need a full build log as i'm not getting that
> 

odd enough, with your latest ebuild changes, i can't reproduce it anymore either. so lets just forget about my previous statement :)
Comment 9 SpanKY gentoo-dev 2010-08-18 00:36:52 UTC
ive unmasked it now