Bug 310991 – Please review EAPI3 changes for app-editors/{vim-core,vim,gvim}

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jeremy Olexa (darkside) (RETIRED) 2010-03-23 22:09:48 UTC]

Patches attached.

[Comment 1 Jeremy Olexa (darkside) (RETIRED) 2010-03-23 22:11:47 UTC]

Created attachment 224947 [details, diff]
vim-core-prefix.patch

This one is the easiest. You will see the vimrc-r4 in FILESDIR gets this @GENTOO_PORTAGE_EPREFIX@ variable. That is removed in vim.eclass by the eprefixify() function.

[Comment 2 Jeremy Olexa (darkside) (RETIRED) 2010-03-23 22:17:42 UTC]

Created attachment 224951 [details, diff]
vim-prefix.patch

First, it needs some patches in FILESDIR.

Second, it is questionable to me if you want src_compile in vim.eclass or not? It is shared code with gvim:
+src_compile() {
+       if [[ ${CHOST} == *-interix* ]]; then
+               # avoid finding of this function, to avoid having to patch either
+               # configure or the source, which would be much more hackish.  after all
+               # vim does it right, only interix is badly broken (again).
+               export ac_cv_func_sigaction=no
+       fi
+       vim_src_compile || die "vim_src_compile failed"
+}
+

[Comment 3 Jeremy Olexa (darkside) (RETIRED) 2010-03-23 22:24:48 UTC]

Created attachment 224957 [details]
gvim-prefix.patch

nearly identical to vim-prefix.patch

[Comment 4 Jeremy Olexa (darkside) (RETIRED) 2010-03-28 03:46:15 UTC]

Created attachment 225519 [details, diff]
vim-eclass-interix.patch

Move that interix conditional into the eclass for cleaner ebuilds.

[Comment 5 Jeremy Olexa (darkside) (RETIRED) 2010-04-13 18:09:33 UTC]

Hey, I tried pinging you in irc a few times to continue discussion on this. I'll continue forward towards the end of this week and place the mods in gentoo-x86. Thanks.

[Comment 6 Jeremy Olexa (darkside) (RETIRED) 2010-04-15 19:54:06 UTC]

In gentoo-x86 now. I know we talked some in irc when I first created this bug so I hope it isn't a problem. You can find me on irc or email. thx

[Comment 7 Jeremy Olexa (darkside) (RETIRED) 2010-04-15 19:54:52 UTC]

*** Bug 302796 has been marked as a duplicate of this bug. ***