Bug 310203 – Please review Prefic changes to net-libs/libsrtp

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Fabian Groffen 2010-03-19 12:23:07 UTC]

--- libsrtp-1.4.4-r1.ebuild        2009-07-08 23:06:26 +0200
+++ libsrtp-1.4.4-r1.ebuild     2010-03-19 13:16:29 +0100
@@ -4,7 +4,7 @@
 
 EAPI="2"
 
-inherit eutils
+inherit eutils multilib
 
 MY_PN="srtp"
 MY_P="${MY_PN}-${PV}"
@@ -23,6 +23,8 @@
 src_prepare() {
        # generate a shared lib
        epatch "${FILESDIR}"/${P}-shared.patch
+       # and as well on Darwin
+       epatch "${FILESDIR}"/${P}-darwin-dylib.patch
 }
 
 src_configure() {
@@ -41,7 +43,7 @@
 
 src_compile() {
        # target all is building test
-       emake ${PN}.a ${PN}.so || die "emake failed"
+       emake ${PN}.a ${PN}$(get_libname) || die "emake failed"
 }
 
 src_test() {


I suggest the darwin-dylib patch to be merged with the shared patch, as it's basically doing that.

Please accept or comment on the intended changes, thanks.

[Comment 1 Mounir Lamouri (volkmar) (RETIRED) 2010-03-20 12:45:06 UTC]

You did not attach the darwin patch but I trust you about it.
For the changes in the ebuild, it's ok.

Feel free to commit your changes and mark the bug as fixed.

[Comment 2 Fabian Groffen 2010-03-21 10:52:02 UTC]

Ah, you're right, sorry.  For the record, here's the darwin patch:

http://overlays.gentoo.org/proj/alt/browser/trunk/prefix-overlay/net-libs/libsrtp/files/libsrtp-1.4.4-darwin-dylib.patch

[Comment 3 Fabian Groffen 2010-03-21 11:00:40 UTC]

committed, thanks!