Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 309627 - virtual/mysql-5.[145] has keywords not available in real ebuilds (ia64-linux x86-freebsd)
Summary: virtual/mysql-5.[145] has keywords not available in real ebuilds (ia64-linux ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Other
: High normal (vote)
Assignee: Gentoo Prefix
URL: http://overlays.gentoo.org/proj/alt/b...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-15 19:01 UTC by Robin Johnson
Modified: 2010-03-23 14:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2010-03-15 19:01:53 UTC
I'm not sure why you added some of these keywords, as they aren't in any of the MySQL ebuilds.

Specifically ia64-linux and x86-freebsd (x86-fbsd IS there).

They were added by ABCD in mid December.
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-03-15 19:28:01 UTC
(In reply to comment #0)
> I'm not sure why you added some of these keywords, as they aren't in any of the
> MySQL ebuilds.

The situation is not ideal. The prefix tree is a mix of gx86 and prefix overlay. So, as a migration step, all ebuilds that only had KEYWORD additions were migrated. Since that time, more and more ebuilds have been moving but the pace is much slower since they are now non-trivial updates. Anway, for mysql-dev-db/5.0.90-r2.ebuild, an inline patch is as follows:

%% diff -u mysql-5.0.90-r2.ebuild mysql-5.0.90-r2.ebuild.1 
--- mysql-5.0.90-r2.ebuild      2010-03-15 14:22:11.729909488 -0500
+++ mysql-5.0.90-r2.ebuild.1    2010-03-13 09:44:29.000000000 -0600
@@ -13,7 +13,7 @@
 EGIT_REPO_URI="git://git.overlays.gentoo.org/proj/mysql-extras.git"
 
 # REMEMBER: also update eclass/mysql*.eclass before committing!
-KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~ppc ~ppc64 ~s390 ~sh ~sparc x86 ~sparc-fbsd ~x86-fbsd"
+KEYWORDS="~x86-freebsd ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~x64-solaris"
 
 # When MY_EXTRAS is bumped, the index should be revised to exclude these.
 EPATCH_EXCLUDE=''
@@ -25,6 +25,12 @@
 # If you want to add a single patch, copy the ebuild to an overlay
 # and create your own mysql-extras tarball, looking at 000_index.txt
 
+src_unpack() {
+       mysql_src_unpack
+       cd "${S}"
+       epatch "${FILESDIR}"/${PN}-5.0.60-darwin-bool.patch
+}
+
 # Official test instructions:
 # USE='berkdb -cluster embedded extraengine perl ssl community' \
 # FEATURES='test userpriv -usersandbox' \

This is the latest non-masked version that we have in the prefix tree ($URL). Obviously, the KEYWORDS would be appended, not replaced.
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2010-03-15 19:35:44 UTC
that patch, can you confirm it's globally safe (no side effects for everybody else?)

Then I'll merge it to the patches repo for MySQL, and you can just merge the keywords and be done with it.
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-03-18 20:24:53 UTC
According to a power user in IRC, the patch is not even needed on Snow Leopard. Update forthcoming on status regarding Tiger.
Comment 4 Fabian Groffen gentoo-dev 2010-03-18 20:31:12 UTC
For Tiger I need to first zap around the eclasses, because otherwise I get compilation issues that stem from not being prefix-aware, which takes some time to remember at the right moment to try again...
Comment 5 Fabian Groffen gentoo-dev 2010-03-19 09:50:30 UTC
I dropped the darwin-bool patch in our local 5.0.90-r5 and that compiles fine with GCC 4.2.1 - "gcc version 4.2.1 (Apple Inc. build 5646) (dot 1)" (had to change the eclass to ewarn iso die) on Tiger also.  Seems it's no longer necessary now, good.
Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-03-23 14:48:14 UTC
(In reply to comment #2)
> that patch, can you confirm it's globally safe (no side effects for everybody
> else?)
> 
> Then I'll merge it to the patches repo for MySQL, and you can just merge the
> keywords and be done with it.
> 

Now, our only remaining diff is this (thanks grobian for checking the patch on osx):
%% diff -u mysql-5.0.90-r2.ebuild{,.1}
--- mysql-5.0.90-r2.ebuild      2010-03-19 05:01:44.000000000 -0500
+++ mysql-5.0.90-r2.ebuild.1    2010-03-10 11:35:27.000000000 -0600
@@ -13,7 +13,7 @@
 EGIT_REPO_URI="git://git.overlays.gentoo.org/proj/mysql-extras.git"
 
 # REMEMBER: also update eclass/mysql*.eclass before committing!
-KEYWORDS="~x86-freebsd ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~x64-solaris"
+KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~ppc ~ppc64 ~s390 ~sh ~sparc x86 ~sparc-fbsd ~x86-fbsd"
 
 # When MY_EXTRAS is bumped, the index should be revised to exclude these.
 EPATCH_EXCLUDE=''

I added the keywords to gentoo-x86 and cleaned up virtual/mysql-5.x too. I consider this bug closed now. Thanks.