308863 – games-strategy/ufo-ai fails to build with libpng14

Bug 308863 - games-strategy/ufo-ai fails to build with libpng14

Summary: games-strategy/ufo-ai fails to build with libpng14

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Games (show other bugs)
Hardware:	All Linux

Importance:	High normal
Assignee:	Gentoo Games

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	libpng-1.4
	Show dependency tree

Reported:	2010-03-10 18:17 UTC by Ai Locke Shinseiko (Wizzleby)
Modified:	2010-03-10 18:44 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
ufo-ai-2.2.1-libpng14.patch (ufo-ai-2.2.1-libpng14.patch,977 bytes, patch) 2010-03-10 18:26 UTC, Ai Locke Shinseiko (Wizzleby)	Details \| Diff
ufo-ai-2.2.1-libpng14.patch (ufo-ai-2.2.1-libpng14.patch,977 bytes, patch) 2010-03-10 18:42 UTC, Ai Locke Shinseiko (Wizzleby)	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ai Locke Shinseiko (Wizzleby) 2010-03-10 18:17:38 UTC

src/game/inv_shared.c: In function ‘INVSH_PackAmmoAndWeapon’:
src/game/inv_shared.c:940: warning: array subscript is below array bounds
 * [GAM] ... linking  (-lm  )
release-linux-gnu-x86_64/client/renderer/r_image.o: In function `R_LoadPNG':
/var/tmp/portage/games-strategy/ufo-ai-2.2.1/work/ufoai-2.2.1-source/src/renderer/r_image.c:210: undefined reference to `png_check_sig'
/var/tmp/portage/games-strategy/ufo-ai-2.2.1/work/ufoai-2.2.1-source/src/renderer/r_image.c:257: undefined reference to `png_set_gray_1_2_4_to_8'
collect2: ld returned 1 exit status
make: *** [ufo] Error 1

Comment 1 Ai Locke Shinseiko (Wizzleby) 2010-03-10 18:26:21 UTC

Created attachment 223031 [details, diff]
ufo-ai-2.2.1-libpng14.patch

works for libpng12 and libpng14

Comment 2 Samuli Suominen (RETIRED) gentoo-dev

2010-03-10 18:37:26 UTC

+  10 Mar 2010; Samuli Suominen <ssuominen@gentoo.org> ufo-ai-2.2.1.ebuild,
+  +files/ufo-ai-2.2.1-libpng14.patch:
+  Fix building with libpng14 wrt #308863 by Locke Shinseiko.

Comment 3 Ai Locke Shinseiko (Wizzleby) 2010-03-10 18:42:46 UTC

Created attachment 223033 [details, diff]
ufo-ai-2.2.1-libpng14.patch

Upstream fixed this, I had the semantics reversed

Comment 4 Samuli Suominen (RETIRED) gentoo-dev

2010-03-10 18:44:11 UTC

In fact upstream has moved on to using SDL_image and all this is void in trunk. But yeah, the temp. fix is to reverse it