Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 308791 - x11-wm/emerald-0.8.4: build failure: undefined reference to 'GTK_OBJECT_TYPE_NAME' when linking libemeraldengine.so
Summary: x11-wm/emerald-0.8.4: build failure: undefined reference to 'GTK_OBJECT_TYPE_...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Desktop-Effects herd
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2010-03-10 06:34 UTC by Leif Walsh
Modified: 2010-09-28 07:17 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to change these symbol references (emerald-0.8.4-01-deprecated_GTK_OBJECT_TYPE_NAME.patch,833 bytes, patch)
2010-03-10 06:34 UTC, Leif Walsh
Details | Diff
new ebuild that uses this patch (emerald-0.8.4-r1.ebuild,921 bytes, patch)
2010-03-10 06:35 UTC, Leif Walsh
Details | Diff
another breaker of gtk+-2.0 (emerald-0.8.4-gtk_widget_get_visible.patch,361 bytes, patch)
2010-03-30 03:23 UTC, geoscope
Details | Diff
ebuild patch (emerald-0.8.4-r2.ebuild.patch,383 bytes, patch)
2010-03-30 03:26 UTC, geoscope
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leif Walsh 2010-03-10 06:34:01 UTC
emerging x11-wm/emerald-0.8.4 fails to link libemeraldengine.so, with undefined reference to 'GTK_OBJECT_TYPE_NAME'.

This is because that symbol is deprecated in favor of G_OBJECT_TYPE_NAME, and must have been removed sometime before gtk+-2.19.6.

I have created a patch and a new ebuild; I will attach them

Reproducible: Always

Steps to Reproduce:
1. emerge x11-wm/emerald-0.8.4 with gtk+-2.19.6.
Actual Results:  
Link error as above.

Expected Results:  
Build should succeed.

I don't know which gtk versions this affects; I am running 2.19.6.

http://library.gnome.org/devel/gtk/unstable/GtkObject.html#GTK-OBJECT-TYPE-NAME:CAPS says it is deprecated as of 2.20.
Comment 1 Leif Walsh 2010-03-10 06:34:49 UTC
Created attachment 222951 [details, diff]
patch to change these symbol references
Comment 2 Leif Walsh 2010-03-10 06:35:12 UTC
Created attachment 222953 [details, diff]
new ebuild that uses this patch
Comment 3 Leif Walsh 2010-03-10 06:35:57 UTC
I'm not sure if the patching goes in src_configure or src_unpack, but for my sanity, I put it in src_configure as that was already there.  Please fix it if that is a problem.
Comment 4 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-03-21 16:18:19 UTC
Thank you for your report. I would like to kindly ask you to submit diff against previous version of ebuilds' instead of whole files in the future.
Best regards,
Kacper Kowalik
Comment 5 geoscope 2010-03-30 03:21:00 UTC
It also needs a patch for GTK_WIDEGT_VISIBLE

(My very first patches submission. Similar patch was submitted for compiz-0.8.4, so it wasn't too hard to learn something new.)

Comment 6 geoscope 2010-03-30 03:23:18 UTC
Created attachment 225779 [details, diff]
another breaker of gtk+-2.0

oops, not a comment...
Comment 7 geoscope 2010-03-30 03:26:21 UTC
Created attachment 225781 [details, diff]
ebuild patch

Hope I got this one right. the above GTK-WIDGET-VISIBLE patch compiled properly, but not yet tested.
Comment 8 geoscope 2010-03-30 03:33:39 UTC
Sorry to spam the bug but, but I just forgot to mention 2 things. 

1) emerald-0.8.4-r2.ebuild.patch was diffed against the emerald-0.8.4-r1.ebuild attachment above, NOT the portage tree's emerald-0.8.4.ebuild.

2) the emerald-0.8.4-gtk_widget_get_visible.patch change IS case sensitve. My first attempts with the change uppercase did not work.
Comment 9 Jorge Manuel B. S. Vicetto (RETIRED) gentoo-dev 2010-04-03 05:46:41 UTC
I've applied these patches in emerald-0.8.4-r1.
Please test the new ebuild and let me know if it works for you.
Comment 10 Jorge Manuel B. S. Vicetto (RETIRED) gentoo-dev 2010-04-16 22:51:16 UTC
Feel free to reopen the bug if it still fails to you.
Comment 11 zemerdon 2010-09-28 07:17:30 UTC
i get this when i try execute the patch.

./emerald-0.8.4-01-deprecated_GTK_OBJECT_TYPE_NAME.patch: line 2: ---: command not found
./emerald-0.8.4-01-deprecated_GTK_OBJECT_TYPE_NAME.patch: line 3: +++: command not found
./emerald-0.8.4-01-deprecated_GTK_OBJECT_TYPE_NAME.patch: line 4: @@: command not found
./emerald-0.8.4-01-deprecated_GTK_OBJECT_TYPE_NAME.patch: line 5: syntax error near unexpected token `}'
./emerald-0.8.4-01-deprecated_GTK_OBJECT_TYPE_NAME.patch: line 5: ` }'

before that there is a whole bunch of stuff its doing.