Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 307349 - sci-mathematics/maxima-5.20.1 command completion fails with emacs-23.1
Summary: sci-mathematics/maxima-5.20.1 command completion fails with emacs-23.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Science Mathematics related packages
URL: http://forums.gentoo.org/viewtopic-t-...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-01 18:37 UTC by Ulrich Müller
Modified: 2010-03-06 08:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
maxima-5.20.1-emacs-version.patch (maxima-5.20.1-emacs-version.patch,346 bytes, patch)
2010-03-01 18:38 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2010-03-01 18:37:25 UTC
User "sawara" has reported the following problem on the forums (see URL):

| This problem occurs when I use maxima inside emacs and I try to complete a
| maxima command with M-Tab. 
| When the completion is unique it works fine, but when the completion is
| ambiguous I only get this in the Messages buffer:
|
|   comint-dynamic-simple-complete: Wrong number of arguments:
|   (lambda (completions) [...rest of message deleted...]

The reason is a broken version number check in maxima.el which (re)defines function comint-dynamic-list-completions if the following condition is true:

    (and
     (not maxima-running-xemacs)
     (or
      (< emacs-major-version 21)
      (< emacs-minor-version 3)))

This obviously breaks for Emacs 23.1. I guess that the intention was to test for versions <21.3 (which would fit the date when this code was committed to upstream's CVS, namely 2004-11-03).

Patch will follow.
Comment 1 Ulrich Müller gentoo-dev 2010-03-01 18:38:25 UTC
Created attachment 221639 [details, diff]
maxima-5.20.1-emacs-version.patch

Fix version number test in maxima.el.
Comment 2 Ulrich Müller gentoo-dev 2010-03-04 20:57:46 UTC
Reported upstream. I believe that their following bug report is about the same issue: <http://sourceforge.net/tracker/index.php?func=detail&aid=2808179&group_id=4933&atid=104933>

@sci-mathematics: Would you mind if I commit this fix myself?
Comment 3 Sébastien Fabbro (RETIRED) gentoo-dev 2010-03-06 06:38:22 UTC
> @sci-mathematics: Would you mind if I commit this fix myself?

Please do!
Thanks.
 

Comment 4 Ulrich Müller gentoo-dev 2010-03-06 08:50:47 UTC
Fixed in 5.20.1-r1.