Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 303733 - net-analyzer/munin-1.4.3 install with -ssl tries to fix a nonexistent munin.conf
Summary: net-analyzer/munin-1.4.3 install with -ssl tries to fix a nonexistent munin.conf
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-06 14:57 UTC by Thomas Seifert
Modified: 2010-02-10 16:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
munin-1.4.3.ebuild.diff (munin-1.4.3.ebuild.diff,456 bytes, text/plain)
2010-02-07 00:35 UTC, David Abbott (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Seifert 2010-02-06 14:57:03 UTC
The install procedure tries to fix build/server/munin.conf with adding "tls disabled" if -ssl is set. But the minimal build (aka node-only) does not create the file there.
I think the fixing of munin.conf should be made optional in the ebuild, only if minimal isn't set.

Reproducible: Always

Steps to Reproduce:
try installing munin 1.4.3 with "-ssl minimal"

Actual Results:  
fails with 
 * ERROR: net-analyzer/munin-1.4.3 failed:
 *   Fixing munin.conf Failed!
 * 
 * Call stack:
 *     ebuild.sh, line  54:  Called src_compile
 *   environment, line 2326:  Called die
 * The specific snippet of code:
 *           echo "tls disabled" >> ${S}/build/server/munin.conf || die "Fixing munin.conf Failed!";
 * 
...
the log contains:
/var/tmp/portage/net-analyzer/munin-1.4.3/temp/environment: line 2326: /var/tmp/portage/net-analyzer/munin-1.4.3/work/munin-1.4.3/build/server/munin.conf: No such file or directory


Expected Results:  
completing install
Comment 1 Thomas Seifert 2010-02-06 15:05:58 UTC
I'm sorry. Seems like I spoke to soon.
The issue is not related to "minimal" but to -ssl only.

Actually the munin.conf is just in a different directory.
The ebuild tries to fix 
build/server/munin.conf
while the real munin.conf is in
build/master/munin.conf
Comment 2 David Abbott (RETIRED) gentoo-dev 2010-02-07 00:35:57 UTC
Created attachment 218767 [details]
munin-1.4.3.ebuild.diff

Thanks Thomas, that fixed it.
[ebuild   R   ] net-analyzer/munin-1.4.3-r1  USE="doc mysql -irc -minimal -postgres -ssl" 0 kB [1]
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-02-09 17:12:16 UTC
Thanks! I apologize for not catching this when I bumped it. I will commit the fix soon.
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-02-10 16:38:31 UTC
fixed without a revbump. Thanks.