Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 302308 - [PATCHES] x11-wm/compiz-0.8.4
Summary: [PATCHES] x11-wm/compiz-0.8.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Desktop-Effects herd
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-26 14:19 UTC by Denilson Sá Maia
Modified: 2010-02-02 13:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
compiz-0.8.4-fix-window-region-calculation.patch (compiz-0.8.4-fix-window-region-calculation.patch,1.17 KB, patch)
2010-01-26 14:22 UTC, Denilson Sá Maia
Details | Diff
compiz-0.8.4-fix-crash-on-opening-windows.patch (compiz-0.8.4-fix-crash-on-opening-windows.patch,2.08 KB, patch)
2010-01-26 14:25 UTC, Denilson Sá Maia
Details | Diff
fix-put-plugin.patch (fix-put-plugin.patch,5.84 KB, text/plain)
2010-01-26 14:27 UTC, Denilson Sá Maia
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Denilson Sá Maia 2010-01-26 14:19:30 UTC
In the last days, a few simple patches that fix some annoying Compiz bugs were created. One of them fixes a regression from 0.8.2 to 0.8.4, while another fixes a segfault.

Maybe it would be a good idea to release a 0.8.4-r1 ebuild with such patches applied, as it will improve the user experience. If that's not desirable, just tell me, and I won't annoy you with new patches here.
Comment 1 Denilson Sá Maia 2010-01-26 14:22:49 UTC
Created attachment 217471 [details, diff]
compiz-0.8.4-fix-window-region-calculation.patch

For x11-wm/compiz-0.8.4

Fixes this bug (regression from 0.8.2):
http://forum.compiz.org/viewtopic.php?f=89&t=12267

Patch downloaded from this commit (as pointed out in above URL):
http://git.compiz.org/compiz/core/commit/?h=compiz-0.8&id=79a275b240a98d9f64c8dd1e799e5d469ec8f204

(by the way, there are a couple of old, orphan patch files lying at the portage/x11-wm/compiz/files directory)
Comment 2 Denilson Sá Maia 2010-01-26 14:25:35 UTC
Created attachment 217472 [details, diff]
compiz-0.8.4-fix-crash-on-opening-windows.patch

For x11-wm/compiz-0.8.4

Fixes a segfault that happens since 0.8.2 or earlier:
http://bugs.opencompositing.org/show_bug.cgi?id=1253
Comment 3 Denilson Sá Maia 2010-01-26 14:27:31 UTC
Created attachment 217473 [details]
fix-put-plugin.patch

For x11-plugins/compiz-plugins-main-0.8.4

Fixes an old Compiz bug (but that was not present in Beryl) related to "Put" plugin.
http://bugs.opencompositing.org/show_bug.cgi?id=1259
Comment 4 Romain Perier (RETIRED) gentoo-dev 2010-01-27 20:09:25 UTC
Patches look good, but except compiz-0.8.4-fix-window-region-calculation.patch, others have been accepted on upstream ?

thanks for your report :)
Comment 5 Denilson Sá Maia 2010-01-27 20:50:41 UTC
(In reply to comment #4)
> Patches look good, [...] have been accepted on upstream ?

The first two I got directly from upstream.

I've proposed the fix-put-patch. I'm still waiting for answer (it might take some time, though), but I really see no reason to not accept it.

I'm also waiting for a few other upstream bugs; if they ever get fixed, I might point add them here. Don't hold your breath, though, as it might take time.
Comment 6 Romain Perier (RETIRED) gentoo-dev 2010-01-27 21:21:26 UTC
(In reply to comment #5)
> but I really see no reason to not accept it.

I never said that I disagree to commit it, I just asked ;)
Comment 7 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure gentoo-dev 2010-01-28 01:03:27 UTC
Thanks for opening the bug.
The patches look ok to me. I'll try to poke upstream to take a look at the fix-put-plugin patch.
Comment 8 Denilson Sá Maia 2010-01-28 03:36:50 UTC
I've just noticed that "Place" plugin (the one that chooses where to place new windows) also has the bug that was fixed in fix-put-plugin.patch. I think we need another patch (this time for the Place plugin).
Comment 9 Denilson Sá Maia 2010-01-30 06:48:50 UTC
(In reply to comment #8)
> I've just noticed that "Place" plugin (the one that chooses where to place new
> windows) also has the bug that was fixed in fix-put-plugin.patch. I think we
> need another patch (this time for the Place plugin).

Posted this bug upstream:
http://bugs.opencompositing.org/show_bug.cgi?id=1262


By the way, why does x11-wm/compiz ebuild download a tar.gz, while all other compiz-related ebuilds download a tar.bz2 ?
Comment 10 Denilson Sá Maia 2010-01-31 13:24:38 UTC
Just to let you know that these bugs have been fixed upstream (including links to the relevant commits):
http://bugs.opencompositing.org/show_bug.cgi?id=1253 (Compiz segfaults)
http://bugs.opencompositing.org/show_bug.cgi?id=1259 (Put plugin)
http://bugs.opencompositing.org/show_bug.cgi?id=1262 (Place plugin)

Thanks to Danny Baumann (maniac)!

So, including the bug fixed in comment 1 (which was not attached to any bug report), we now have 4 bugfixes/patches to be deployed!
(please prefer to get the patches directly from upstream repository instead of those attached to this bug)
Comment 11 Romain Perier (RETIRED) gentoo-dev 2010-01-31 16:13:26 UTC
(In reply to comment #9)
> By the way, why does x11-wm/compiz ebuild download a tar.gz, while all other
> compiz-related ebuilds download a tar.bz2 ?
> 

There are no reasons, it's a fault, thanks for pointing that.

(In reply to comment #10)
> (please prefer to get the patches directly from upstream repository instead of
> those attached to this bug)

Usually it's our policy to do so ^^

Okay so I'll commit them :)
Comment 12 Romain Perier (RETIRED) gentoo-dev 2010-01-31 17:01:40 UTC
Fixed in the main tree, both with a revbump.
Many thanks for patches and for reporting.

Feel free to reopen this bug in case of problems
Comment 13 Denilson Sá Maia 2010-01-31 18:11:13 UTC
(In reply to comment #12)
> Fixed in the main tree, both with a revbump.

Huh... Did I miss it or you forgot to add the patch mentioned in comment 1 ?

By the way, is it a good moment to delete those old patches (for old versions, not in tree anymore) from files/ directory?
Comment 14 Denilson Sá Maia 2010-02-01 17:18:14 UTC
Reopening, as you forgot the patch from comment 1 (that fixes a regression from 0.8.2 to 0.8.4).
Comment 15 Romain Perier (RETIRED) gentoo-dev 2010-02-02 13:00:13 UTC
(In reply to comment #14)
> Reopening, as you forgot the patch from comment 1 (that fixes a regression from
> 0.8.2 to 0.8.4).
> 

oops, fixed :) (with a revbump because it's an important patch)

feel free to blame me ^^