Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 301815 - www-client/conkeror works with gentoo prefix on amd64-linux
Summary: www-client/conkeror works with gentoo prefix on amd64-linux
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-22 08:48 UTC by Chetan Reddy
Modified: 2010-02-26 10:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Prefix-aware ebuild for Conkeror (conkeror-0.9.1.ebuild,1.67 KB, text/plain)
2010-02-25 08:57 UTC, Christian Faulhammer (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chetan Reddy 2010-01-22 08:48:25 UTC
hi. i wanted to inform you guys that i ecopy'd www-client/conkeror into my overlay and it worked without any hassles. the only change i needed to make after the install was to symlink ~/.gre.d to $EPREFIX/etc/gre.d
Comment 1 Christian Faulhammer (RETIRED) gentoo-dev 2010-01-22 10:42:14 UTC
Does it use your system's xulrunner or the one from prefix?
Comment 2 Chetan Reddy 2010-01-23 00:13:55 UTC
oops. i had created a symlink called gre.d in my home folder instead of *.*gre.d which was making conkeror use the system's xulrunner. when i 'fixed' this and made conkeror use gentoo prefix's xulrunner, it started segfaulting whenever i tried to load a site. the same happens with www-client/mozilla-firefox though (which is already in gentoo prefix).
Comment 3 Chetan Reddy 2010-02-21 00:14:23 UTC
After a recent update to xulrunner, both conkeror and mozilla-firefox began to work on both my rhel4 and fc11 boxes. Reopening. The user probably needs to be informed to set the ~/.gre.d link to use gentoo prefix's etc/gre.d .
Comment 4 Christian Faulhammer (RETIRED) gentoo-dev 2010-02-23 21:54:31 UTC
(In reply to comment #3)
> After a recent update to xulrunner, both conkeror and mozilla-firefox began to
> work on both my rhel4 and fc11 boxes. Reopening. The user probably needs to be
> informed to set the ~/.gre.d link to use gentoo prefix's etc/gre.d .

 As I maintain conkeror I would not like to see an ecopied ebuild in the Prefix overlay, but the work be done in the main tree.  How can I test for a Prefix environment for an according elog message?  use prefix?
Comment 5 Chetan Reddy 2010-02-23 22:22:32 UTC
Another fix for this problem is to change 
usr/lib/conkeror/contrib/run-conkeror
from
    if [[ -d "/etc/gre.d" ]]; then
        xr=$(check-gre /etc/gre.d 2>/dev/null)
    fi
to
    if [[ -d "/path/to/gentoo/prefix/etc/gre.d" ]]; then
        xr=$(check-gre /path/to/gentoo/prefix/etc/gre.d 2>/dev/null)
    fi

This way, the user doesn't have to know about .gre.d and can have both a system version and a gentoo prefix version of conkeror installed and using their respective xulrunners by default.
Comment 6 Jonathan Callen (RETIRED) gentoo-dev 2010-02-24 00:10:56 UTC
(In reply to comment #5)
> Another fix for this problem is to change 
> usr/lib/conkeror/contrib/run-conkeror
> from
>     if [[ -d "/etc/gre.d" ]]; then
>         xr=$(check-gre /etc/gre.d 2>/dev/null)
>     fi
> to
>     if [[ -d "/path/to/gentoo/prefix/etc/gre.d" ]]; then
>         xr=$(check-gre /path/to/gentoo/prefix/etc/gre.d 2>/dev/null)
>     fi
> 

The proper method to do that is to inherit prefix.eclass, and use some method (patch, sed, etc.) to adjust the above from [[ -d "/etc/gre.d" ]] to [[ -d "@GENTOO_PORTAGE_EPREFIX@" ]], and then call eprefixify on the resulting file.
Comment 7 Fabian Groffen gentoo-dev 2010-02-24 07:23:07 UTC
That makes little sense to me.  If you're sedding anyway, you can immediately put EPREFIX in there.  If you come up with a patch to add @GENTOO_PORTAGE_EPREFIX@, then using eprefixify is the right thing.
Comment 8 Jonathan Callen (RETIRED) gentoo-dev 2010-02-24 09:29:08 UTC
(In reply to comment #7)
> That makes little sense to me.  If you're sedding anyway, you can immediately
> put EPREFIX in there.  If you come up with a patch to add
> @GENTOO_PORTAGE_EPREFIX@, then using eprefixify is the right thing.
> 

That's what I meant, I just expressed myself poorly.
Comment 9 Christian Faulhammer (RETIRED) gentoo-dev 2010-02-25 08:31:07 UTC
As I am not able to test it properly in my Prefix environments, I will prepare a patched ebuild in the next couple of days (latest on monday) and attach it here.  Chetan, can you test it then and report back?
Comment 10 Christian Faulhammer (RETIRED) gentoo-dev 2010-02-25 08:57:39 UTC
Created attachment 221061 [details]
Prefix-aware ebuild for Conkeror

Please try.
Comment 11 Chetan Reddy 2010-02-26 01:16:32 UTC
thanks fauli. it worked but only after i changed the sed command to 

sed -e "s:/etc/gre.d:\"${EPREFIX}/etc/gre.d\":g" -i "${D}${EPREFIX}"/usr/lib/conkeror/contrib/run-conkeror || die

One weird thing i noticed is that ${D} ends with a slash, whereas the ebuild manual states that it is ${PORTAGE_BUILDDIR}/image without a slash. Not a problem here though, just something i noticed while debugging.
Comment 12 Christian Faulhammer (RETIRED) gentoo-dev 2010-02-26 10:35:48 UTC
Done, thanks for your test.