Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 301773 - <net-p2p/transmission-1.83: "Protect against potential data loss by maliciously-crafted torrents" (CVE-2010-0012)
Summary: <net-p2p/transmission-1.83: "Protect against potential data loss by malicious...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Security
Classification: Unclassified
Component: Vulnerabilities (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Security
URL: http://trac.transmissionbt.com/wiki/C...
Whiteboard: B3 [noglsa]
Keywords:
: 301039 301771 301965 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-01-21 20:20 UTC by Jeroen Roovers (RETIRED)
Modified: 2014-05-31 22:55 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
transmission-1.80.ebuild (transmission-1.80.ebuild,2.18 KB, text/plain)
2010-01-23 14:02 UTC, Angelo D'Autilia (sYdRo)
no flags Details
the patch for the ebuild. (transmission-1.83.patch,1.85 KB, patch)
2010-01-30 16:17 UTC, Björn
no flags Details | Diff
the patch to disable libevent (transmission-1.83-disable-libevent.patch,1.00 KB, patch)
2010-01-30 16:19 UTC, Björn
no flags Details | Diff
Complete Transmission 1.83 ebuild (transmission-1.83.ebuild,2.58 KB, text/plain)
2010-02-05 13:56 UTC, Brad Laue
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2010-01-21 20:20:45 UTC
From the 1.80 changes:

 "Fix vulnerability from maliciously-crafted torrent files that could overwrite
  other files"

Note that 1.77 already had this:

 "Protect against potential data loss by maliciously-crafted torrent files"

so this bug report probably supersedes bug #301039 in some way.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2010-01-22 01:10:14 UTC
*** Bug 301771 has been marked as a duplicate of this bug. ***
Comment 2 Angelo D'Autilia (sYdRo) 2010-01-23 14:02:47 UTC
Created attachment 217243 [details]
transmission-1.80.ebuild 

This is transmission-1.76.ebuild fixed

There's transmission-1.81.ebuild in bug : #301900
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2010-01-24 07:52:31 UTC
*** Bug 301965 has been marked as a duplicate of this bug. ***
Comment 4 Matt O 2010-01-29 07:36:59 UTC
I've been using transmission-1.82.ebuild from #301965 for some time without any issues now. I have not tested the qt4 or gtk clients however.

The configuration file and init script needs to be updated with the new options such as incomplete folder and incomplete file extensions in 1.82. I use a customized version of the init script from 1.76 and symlinked in conf.d to the settings.json file that transmission-daemon actually uses for its settings.
Comment 5 Xake 2010-01-29 08:10:36 UTC
(In reply to comment #4)
> I use a
> customized version of the init script from 1.76 and symlinked in conf.d to the
> settings.json file that transmission-daemon actually uses for its settings.
> 

You will probably never see that in gentoo as transmission needs an initial configuration to generate that file from, and also the init.d script does stuff (like run as another user and more) which transmission-daemon itself does not support, and the logic place to configure that is in conf.d.
Comment 6 lucapost 2010-01-29 08:34:42 UTC
The 1.82 ebuild, renamed to 1.83, compiles and installs fine on my AMD64
system.
Comment 7 Matt O 2010-01-29 18:48:26 UTC
Xake,
I see your point. Transmission does however pick reasonable defaults for most of its parameters, except for the home/config directory where it creates its default settings.json and supporting configuration folder/files. It would be possible to pick/set a default home and transmission daemon user as a script variable in init.d and put a default settings.json file in conf.d and a symlink to this in the chosen transmission home. This could be done in install/postinst in the ebuild, however I could see that getting messy fast.

The problems I ran into are a) the transmission-daemon startup params do not allow you to set all settings (might be changed in future transmission versions) and b) in 1.80+ you can send a SIGHUP to read changes to its settings.json while its running. However startup options in init.d overwrite these changes on any restart.

This wouldn't be an issue if transmission-daemon used a regular linux conf file. Also, I'm not sure if bugzilla is the proper place for discussions about packages. Is there any better option for discussing package enhancements/changes?
Comment 8 Xake 2010-01-29 18:53:42 UTC
(In reply to comment #7)
> This wouldn't be an issue if transmission-daemon used a regular linux conf
> file. Also, I'm not sure if bugzilla is the proper place for discussions about
> packages. Is there any better option for discussing package
> enhancements/changes?

Well, if it is about the init.d/conf.d then a new bug I think would be appropriate, if you think that maybe some things should be changed in how upstream handles their config file, then upstream is your place.
Comment 9 Björn 2010-01-30 16:16:19 UTC
Some changed to the ebuild:

- dht is not optional anymore.
- new use flags canberra, cli and daemon.
- warning for cli being deprecated.
- patch to remove libevent from configure and build.
- added gconf as dependency.

The patch is for the 1.82 ebuild from bug #301900.
Comment 10 Björn 2010-01-30 16:17:01 UTC
Created attachment 217925 [details, diff]
the patch for the ebuild.
Comment 11 Björn 2010-01-30 16:19:03 UTC
Created attachment 217928 [details, diff]
the patch to disable libevent
Comment 12 lordcris 2010-02-03 15:42:42 UTC
can you add the ebuild in portage please?
Comment 13 Brad Laue 2010-02-05 03:32:09 UTC
Any reason not to commit this? Saw a bump to 1.77 today which is an old version.
Comment 14 Jeroen Roovers (RETIRED) gentoo-dev 2010-02-05 04:38:03 UTC
*transmission-1.77 (04 Feb 2010)

  04 Feb 2010; Rémi Cardona <remi@gentoo.org> +transmission-1.77.ebuild:
  bump to 1.77
Comment 15 Rémi Cardona (RETIRED) gentoo-dev 2010-02-05 07:24:05 UTC
I bumped 1.77 because I needed that version, but newer versions could interest me as well. Is there a full 1.83 ebuild? Or a patch on top of 1.76/77? Attachment #217925 [details, diff] seems to be on top of 1.82...

Cheers
Comment 16 Brad Laue 2010-02-05 13:56:20 UTC
Created attachment 218523 [details]
Complete Transmission 1.83 ebuild
Comment 17 Brad Laue 2010-02-05 13:59:01 UTC
Seems the 1.83 patch was a patch against an ebuild buried in a closed ticket. Wow. I've attached a full 1.83 ebuild built from these. Tested and functional - QT and GTK
Comment 18 Brad Laue 2010-02-05 14:06:29 UTC
Attached ebuild is 218523
Comment 19 Stefan Behte (RETIRED) gentoo-dev Security 2010-02-06 15:56:31 UTC
*** Bug 301039 has been marked as a duplicate of this bug. ***
Comment 20 lucapost 2010-02-09 14:23:16 UTC
> - warning for cli being deprecated.

but, in 1.83 with USE="daemon -canberra -cli -gtk -libnotify -qt4" is there a way to create torrent via transmission-remote?

LP

Comment 21 Samuli Suominen (RETIRED) gentoo-dev 2010-02-11 08:57:06 UTC
1.83 in Portage.

Arch's, please test and stabilize:

=net-p2p/transmission-1.83
Comment 22 lordcris 2010-02-11 09:23:56 UTC
stable for me on amd64
Comment 23 Christian Faulhammer (RETIRED) gentoo-dev 2010-02-11 12:05:30 UTC
Samuli, how could you stable with transmission 1.83 being EAPI 3, while only  2.1.7.17 supports that and is in testing?
Comment 24 Samuli Suominen (RETIRED) gentoo-dev 2010-02-11 12:17:57 UTC
(In reply to comment #23)
> Samuli, how could you stable with transmission 1.83 being EAPI 3, while only 
> 2.1.7.17 supports that and is in testing?
> 

Didn't realize stable portage is outdated, downgraded the ebuild to EAPI=2.
Comment 25 Christian Faulhammer (RETIRED) gentoo-dev 2010-02-11 14:58:42 UTC
x86 stable
Comment 26 Samuli Suominen (RETIRED) gentoo-dev 2010-02-14 10:29:26 UTC
amd64 stable
Comment 27 lucapost 2010-02-19 11:14:34 UTC
please update to 1.90, renamed ebuild from 1.83 works fine for me.

Comment 28 Xake 2010-02-19 12:06:01 UTC
(In reply to comment #27)
> please update to 1.90, renamed ebuild from 1.83 works fine for me.
> 

Will not happen in this bug, as this bug is about bumping (done) and stabilizing transmission-1.83.

Could someone change the Summary to reflect that change of status?
Comment 29 Tobias Heinlein (RETIRED) gentoo-dev 2010-03-01 12:34:54 UTC
ppc ping.
Comment 30 Tobias Heinlein (RETIRED) gentoo-dev 2010-03-01 12:35:20 UTC
CVE-2010-0012 (http://nvd.nist.gov/nvd.cfm?cvename=CVE-2010-0012):
  Directory traversal vulnerability in libtransmission/metainfo.c in
  Transmission 1.22, 1.34, 1.75, and 1.76 allows remote attackers to
  overwrite arbitrary files via a .. (dot dot) in a pathname within a
  .torrent file.

Comment 31 Joe Jezak (RETIRED) gentoo-dev 2010-03-09 22:02:19 UTC
Sorry, marked ppc stable.
Comment 32 Doug Goldstein (RETIRED) gentoo-dev 2010-06-23 22:46:50 UTC
security: The oldest version available in the tree now is 1.92, close out this bug and do whatever cleanup you guys need to do.
Comment 33 Stefan Behte (RETIRED) gentoo-dev Security 2010-08-01 13:06:38 UTC
Vote: NO (*very* unlikely to be ever exploited).
Comment 34 Tobias Heinlein (RETIRED) gentoo-dev 2010-08-14 14:38:32 UTC
Actually I vote YES here.
Comment 35 Tim Sammut (RETIRED) gentoo-dev 2010-11-18 21:03:19 UTC
GLSA Vote: Yes too. Request filed.
Comment 36 Xake 2012-02-22 08:50:15 UTC
Ehm, those versions in this bug are gone from portage since long, making the oldest in portage 2.22 and stable since May 2011.
So is it time to close this bug?
Comment 37 Samuli Suominen (RETIRED) gentoo-dev 2012-11-15 06:23:36 UTC
removing net-p2p@ and myself from CC due to nothing left to be done here for us, please readd us if needed
Comment 38 Sean Amoss (RETIRED) gentoo-dev Security 2014-05-31 22:55:28 UTC
This issue has been fixed since Mar 09, 2010 and users have already been advised to update from GLSA 201006-06. No GLSA will be issued for this bug.