Upstream is already at 1.43 for a while. Reproducible: Always Steps to Reproduce:
HOMEPAGE redirects to URL now.
Created attachment 215692 [details, diff] munin-1.3.4-r2 - 1.4.3 ebuild patch [needs works] This shows some of the changes between the latest stable and what is needed for 1.4.3 to enter the tree: (1) None of the old patches apply (and will likely need to be replaced - see also (3)). (2) Two deps added (dev-perl/Net-CIDR from bug #287718) and dev-perl/Log- Log4perl because src_compile() failed when it couldn't find this. (3) The build still fails in src_compile: [...] cd node && /usr/bin/perl Build.PL Looks good Creating new 'Build' script for 'Munin::Master' version '0.0.0' cd plugins && /usr/bin/perl Build.PL Can't locate Munin/Common/Defaults.pm in @INC (@INC contains: ../common/blib/lib /etc/perl /usr/lib/perl5/vendor_perl/5.8.8/i686-linux /usr/lib/perl5/vendor_perl/5.8.8 /usr/lib/perl5/vendor_perl /usr/lib/perl5/site_perl/5.8.8/i686-linux /usr/lib/perl5/site_perl/5.8.8 /usr/lib/perl5/site_perl /usr/lib/perl5/5.8.8/i686-linux /usr/lib/perl5/5.8.8 /usr/local/lib/site_perl .) at NodeBuilder.pm line 14. BEGIN failed--compilation aborted at NodeBuilder.pm line 14. Compilation failed in require at Build.PL line 1. BEGIN failed--compilation aborted at Build.PL line 1. make: *** [node/Build] Error 2 make: *** Waiting for unfinished jobs.... Checking prerequisites... Looks good Creating new 'Build' script for 'Munin::Plugins' version '0.0.0' * ERROR: net-analyzer/munin-1.4.3 failed: * build/build-man failed * * Call stack: * ebuild.sh, line 48: Called src_compile * environment, line 2353: Called die * The specific snippet of code: * emake build build-man || die "build/build-man failed";
Created attachment 215735 [details] ebuild for 1.4.3 I've been looking for a 1.4.x ebuild for a bit, so I decided to give updating this one a shot. I'm able to build/install this ebuild and everything appears correct, but I haven't tested it.
Created attachment 215737 [details, diff] revised patch from 1.3.4
Created attachment 215739 [details, diff] revised Makefile.config patch
Created attachment 215741 [details, diff] Revised parallel make patch
Created attachment 215742 [details, diff] revised plugin cleanup patch
Created attachment 215753 [details, diff] Part of the install hit parallel make problems as well and I missed it
Created attachment 216120 [details] Protect a new directory in /etc/munin not present in 1.3.x
Tried to use the ebuild but got an error when emerging: From the build.log: -------------- ... for f in build/master/doc/munin.conf node/doc/munin-node.conf; do \ pod2man --section=5 --release=1.4.3 --center="Munin Documentation" "$f".pod > build/doc/`basename $f .pod`.5; \ done cd common && /usr/bin/perl Build code cd node && /usr/bin/perl Build.PL rm -f common/blib/lib/Munin/Common/Defaults.pm cd plugins && /usr/bin/perl Build.PL Can't locate Munin/Common/Defaults.pm in @INC (@INC contains: ../common/blib/lib /etc/perl /usr/lib/perl5/vendor_perl/5.8.8/i686-linux /usr/lib/perl5/vendor_perl/5.8.8 /usr/lib/perl5/vendor_perl /usr/lib/perl5/site_perl/5.8.8/i686-linux /usr/lib/perl5/site_perl/5.8.8 /usr/lib/perl5/site_perl /usr/lib/perl5/5.8.8/i686-linux /usr/lib/perl5/5.8.8 /usr/local/lib/site_perl .) at NodeBuilder.pm line 14. BEGIN failed--compilation aborted at NodeBuilder.pm line 14. Compilation failed in require at Build.PL line 1. BEGIN failed--compilation aborted at Build.PL line 1. make: *** [node/Build] Error 2 make: *** Waiting for unfinished jobs.... Checking prerequisites... Looks good ---- Why is the common/blib/lib/Munin/Common/Defaults.pm removed after it was build?
Created attachment 216304 [details, diff] Update patch to improve parallel make
Let me know if the updated parallel make patch helps fix it. I'm currently poking at the developers to find someone I can speak to to hopefully work out the issues with the Makefile, as it boggles me. Also, I'm unable to reproduce your build failure. If the updated patch doesn't resolve the issue, can you respond with more details? I've currently only tested the ebuild on amd64.
It is quite strange, I had to emerge twice and then it was working (emerge succeeded). I'm facing some other issues now, mainly that the cron can't be setup and the /etc/init.d/munin-node is missing. When emerging I can see: * QA Notice: file does not exist: * * newins: /usr/local/portage/net-analyzer/munin/files/munin-1.3.2-plugins.conf does not exist * newins: /usr/local/portage/net-analyzer/munin/files/munin-1.3.3-crontab does not exist * newinitd: /usr/local/portage/net-analyzer/munin/files/munin-node_init.d_1.3.3-r1 does not exist * newconfd: /usr/local/portage/net-analyzer/munin/files/munin-node_conf.d_1.3.3-r1 does not exist * newins: /usr/local/portage/net-analyzer/munin/files/logrotate.d-munin does not exist
I have copied them from the 1.3.3 ebuild for now.
Sorry, I didn't make it clear but it uses some of the older files because they didn't have to be changed for the newer version. It would be best to copy the files/ directory from the portage tree if you are housing this ebuild in an overlay.
Thanks, that's what I have done right now....and it is running again...yipiyeah
The parallel make patch doesn't seem to work as intended. cp plugins/javalib/org/munin/plugin/jmx/MemorySurvivorPeak.class build/plugins/javalib/ org/munin/plugin/jmx/MemorySurvivorPeak.class mkdir -p build/`dirname plugins/javalib/org/munin/plugin/jmx/Threads.class` cp plugins/javalib/org/munin/plugin/jmx/MemoryPermGenUsagePostGC.class build/plugins/ja valib/org/munin/plugin/jmx/MemoryPermGenUsagePostGC.class /usr/bin/perl -pe 's{(PREFIX \s+=\s).*}{\1q{/usr};}x; \ s{(CONFDIR \s+=\s).*}{\1q{/etc/munin};}x; \ s{(BINDIR \s+=\s).*}{\1q{/usr/bin};}x; \ s{(SBINDIR \s+=\s).*}{\1q{/usr/sbin};}x; \ s{(DOCDIR \s+=\s).*}{\1q{/usr/share/doc/munin-1.4.3};}x; \ s{(LIBDIR \s+=\s).*}{\1q{/usr/libexec/munin};}x; \ s{(MANDIR \s+=\s).*}{\1q{/usr/share/man};}x; \ s{(LOGDIR \s+=\s).*}{\1q{/var/log/munin};}x; \ s{(HTMLDIR \s+=\s).*}{\1q{/usr/var/www/localhost/htdocs/munin};}x; \ s{(DBDIR \s+=\s).*}{\1q{/var/lib/munin};}x; \ s{(STATEDIR \s+=\s).*}{\1q{/var/run/munin};}x; \ s{(PERL \s+=\s).*}{\1q{/usr/bin/perl};}x; \ s{(PERLLIB \s+=\s).*}{\1q{/usr/lib/perl5/site_perl/5.8.8};}x; \ s{(PYTHON \s+=\s).*}{\1q{/usr/bin/env python};}x; \ s{(RUBY \s+=\s).*}{\1q{/usr/bin/env ruby};}x; \ s{(OSTYPE \s+=\s).*}{\1q{linux};}x; \ s{(HOSTNAME \s+=\s).*}{\1q{astrid};}x; \ s{(MKTEMP \s+=\s).*}{\1q{mktemp -p /tmp/ $1};}x; \ s{(VERSION \s+=\s).*}{\1q{1.4.3};}x; \ s{(PLUGSTATE \s+=\s).*}{\1q{/var/lib/munin/plugin-state};}x; \ s{(CGIDIR \s+=\s).*}{\1q{/usr/var/www/localhost/cgi-bin};}x; \ s{(USER \s+=\s).*}{\1q{munin};}x; \ s{(GROUP \s+=\s).*}{\1q{munin};}x; \ s{(PLUGINUSER \s+=\s).*}{\1q{nobody};}x; \ s{(GOODSH \s+=\s).*}{\1q{/bin/sh};}x; \ s{(BASH \s+=\s).*}{\1q{/bin/bash};}x; \ s{(HASSETR \s+=\s).*}{\1q{1};}x; \ s{(SSPOOLDIR \s+=\s).*}{\1q{/var/run/munin/spool};}x;' \ common/lib/Munin/Common/Defaults.pm > common/blib/lib/Munin/Common/De faults.pm cp plugins/javalib/org/munin/plugin/jmx/Threads.class build/plugins/javalib/org/munin/p lugin/jmx/Threads.class /bin/sh: common/blib/lib/Munin/Common/Defaults.pm: Permission denied make: *** [common/blib/lib/Munin/Common/Defaults.pm] Error 1 make: *** Waiting for unfinished jobs....
(In reply to comment #17) > The parallel make patch doesn't seem to work as intended. ... > common/lib/Munin/Common/Defaults.pm > > common/blib/lib/Munin/Common/Defaults.pm ... > /bin/sh: common/blib/lib/Munin/Common/Defaults.pm: Permission denied > make: *** [common/blib/lib/Munin/Common/Defaults.pm] Error 1 > make: *** Waiting for unfinished jobs.... > It looks like the file is created, but it doesn't look to be caused by parallel make. Is there something about your build environment that would make a file created by a command in make to not be readable by a later command spawned by make?
We'll need this change too if we want to support FEATURES=test properly. It fails even then at a lot of trivial tests, though. --- munin-1.4.3.ebuild 2010-01-13 21:13:25.000000000 +0100 +++ munin-1.4.3-r1.ebuild 2010-01-13 20:37:59.000000000 +0100 @@ -11,8 +11,8 @@ SRC_URI="mirror://sourceforge/munin/${P}.tar.gz" LICENSE="GPL-2" SLOT="0" -KEYWORDS="amd64 ~mips ppc sparc x86" -IUSE="doc minimal irc mysql postgres ssl" +KEYWORDS="~amd64 ~mips ~x86" +IUSE="doc minimal irc mysql postgres ssl test" # Upstream's listing of required modules is NOT correct! # Some of the postgres plugins use DBD::Pg, while others call psql directly. @@ -42,7 +42,10 @@ #munin-sybase? ( dev-perl/DBD-Sybase ) # Keep this seperate, as previous versions have had other deps here -DEPEND="${DEPEND_COM}" +DEPEND=" + ${DEPEND_COM} + test? ( dev-perl/Test-Perl-Critic dev-perl/Test-Pod-Coverage ) +" RDEPEND="${DEPEND_COM} !minimal? ( virtual/cron )"
Maybe this will help get the ebuild into the tree too: @@ -68,7 +72,7 @@ } src_compile() { - emake build build-man || die "build/build-man failed" + emake -j1 build build-man || die "build build-man failed" if use doc; then emake build-doc || die "build-doc failed" fi
(In reply to comment #18) > > /bin/sh: common/blib/lib/Munin/Common/Defaults.pm: Permission denied [...] > It looks like the file is created, but it doesn't look to be caused by parallel > make. Is there something about your build environment that would make a file > created by a command in make to not be readable by a later command spawned by > make? Er, to me that looks like /bin/sh is trying to *execute*, not just *read* common/blib/lib/Munin/Common/Defaults.pm
(In reply to comment #21) > Er, to me that looks like /bin/sh is trying to *execute*, not just *read* > common/blib/lib/Munin/Common/Defaults.pm Good point. I've had so many problems with it not existing that my mind went right down that path. I can't find anything in the Makefile that would attempt to execute it, though. I'm starting to give up on attempting to fix the Makefile. Does the ebuild emerge correctly if you add "-j1" and remove the parallel make patch? I got the impression from previous bugs that using "-j1" is unacceptable, but if it means the ebuild works, I'll be happy with that.
Created attachment 216830 [details, diff] re-revised Makefile.config patch: Also install into vendor_perl, not site_perl
Created attachment 217758 [details] ebuild without parallel makes Here is an ebuild without the parallel make patch and with "-j 1" added to the emake calls. I have given up on fixing parallel make, for now.
Created attachment 218051 [details] munin-1.4.3.ebuild This ebuild is based of the one in Attachment 217758 [details] (comment #24). It has dropped EPATCH_OPTS (Makefile patch wouldn't apply unless this was dropped). Also applied: -style changes for the global scope variables to be more aligned with common practices. -additional die statements TODO: I will be testing this version as a node with a 1.3.4 master in the next few days.
(In reply to comment #25) > TODO: I will be testing this version as a node with a 1.3.4 master in the next > few days. Tested fine. I got the ACK from Robin to commit. +*munin-1.4.3 (03 Feb 2010) + + 03 Feb 2010; Jeremy Olexa <darkside@gentoo.org> + -files/munin-1.3.2-plugin-cleanup.patch, + -files/munin-1.3.2-rrdtool-comments.patch, -munin-1.3.3.ebuild, + -munin-1.3.3-r1.ebuild, -munin-1.3.3-r2.ebuild, + -files/munin-1.3.3-Makefile.patch, -munin-1.3.4.ebuild, + -munin-1.3.4-r1.ebuild, +munin-1.4.3.ebuild, + +files/munin-1.4.3-Makefile.patch, + +files/munin-1.4.3-fw_conntrack_plugins.patch, + +files/munin-1.4.3-ping6_fix.patch, + +files/munin-1.4.3-plugin-cleanup.patch, metadata.xml: + Version bump to 1.4.3, many thanks to all the contributors on bug 300171. + Include ping6 fix from bug 294722. Include QA fix for perl site-dir, bug + 298528. Remove old versions and unused patches
