Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 299405 - media-video/mplayer ebuild fixes and enhancements
Summary: media-video/mplayer ebuild fixes and enhancements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks: 305509
  Show dependency tree
 
Reported: 2010-01-02 22:18 UTC by Andrew Savchenko
Modified: 2010-04-24 14:12 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
return back opencore-amr support (mplayer-9999.p00-amr.ebuild.diff,1.53 KB, patch)
2010-01-02 22:21 UTC, Andrew Savchenko
Details | Diff
bs2b dep (mplayer-9999.p01-bs2b.ebuild.diff,370 bytes, patch)
2010-01-02 22:23 UTC, Andrew Savchenko
Details | Diff
cdparanoia dep fix (mplayer-9999.p02-cdparanoia.ebuild.diff,429 bytes, patch)
2010-01-02 22:24 UTC, Andrew Savchenko
Details | Diff
subs without X (mplayer-9999.p03-subs.ebuild.diff,860 bytes, patch)
2010-01-02 22:27 UTC, Andrew Savchenko
Details | Diff
docs enhancement (mplayer-9999.p04-docs.ebuild.diff,1023 bytes, patch)
2010-01-02 22:30 UTC, Andrew Savchenko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Savchenko gentoo-dev 2010-01-02 22:18:39 UTC
Hello,

here are some patches against current mplayer-9999.ebuild.
Comment 1 Andrew Savchenko gentoo-dev 2010-01-02 22:21:59 UTC
Created attachment 214956 [details, diff]
return back opencore-amr support

opencore-amr support was dropped after mplayer-1.0_rc4_p20091026-r1.ebuild. 

I can't understand why: license is Apache 2.0, so it should induce no problems, this is not the same trouble as with amrnb/amrwb. Maybe just missed during update?
Comment 2 Andrew Savchenko gentoo-dev 2010-01-02 22:23:00 UTC
Created attachment 214957 [details, diff]
bs2b dep

Dependency on libbs2b was missed.
Comment 3 Andrew Savchenko gentoo-dev 2010-01-02 22:24:58 UTC
Created attachment 214958 [details, diff]
cdparanoia dep fix

If both cdio and cdparanoia are specified, cdio will be used. Thus depend on cdparanoia only if cdio is not requested.
Comment 4 Andrew Savchenko gentoo-dev 2010-01-02 22:27:15 UTC
Created attachment 214960 [details, diff]
subs without X

It is possible to use subtitle rendering in mencoder even if X server is not installed (I sometimes use this on my home X-less server to convert video). So ass and truetype should not relate to the "X" use flag.
Comment 5 Andrew Savchenko gentoo-dev 2010-01-02 22:30:28 UTC
Created attachment 214961 [details, diff]
docs enhancement

1) This patch generates docs for only those languages which are present in $LINGUAS. It was proposed earlier, but is not used for some reason, at least now. So, this is try #2.

2) In current ebuild html docs will be installed in the tech/mirrors/ because of docinto directive below html docs installation. This patch also fixes this and installes html docs in the html dir.
Comment 6 Reimar Döffinger 2010-01-03 01:06:01 UTC
Apache 2.0 license is not compatible with GPLv2, only with GPLv3.
I do not know if all of MPlayer can be relicensed as GPLv3, I actually doubt it.
Which means that the issue to my knownledge is basically unchanged: compiling your own binary with AMR support is ok, distributing the resulting binary is not though.
Comment 7 Wormo (RETIRED) gentoo-dev 2010-01-03 07:52:27 UTC
Thanks for submitting your mplayer enhancements, assigning to maintainers.
Comment 8 Andrew Savchenko gentoo-dev 2010-01-03 09:40:57 UTC
(In reply to comment #6)
> Apache 2.0 license is not compatible with GPLv2, only with GPLv3.
> I do not know if all of MPlayer can be relicensed as GPLv3, I actually doubt
> it.
> Which means that the issue to my knownledge is basically unchanged: compiling
> your own binary with AMR support is ok, distributing the resulting binary is
> not though.

Well, if we disable opencore-amr support for bindist, then everything should be ok: binary with AMR will not be distributed, sources will be build on local systems. Maybe a warning should be issued as well to aware from binary redistribution if AMR was included.
Comment 9 Reimar Döffinger 2010-01-03 17:28:31 UTC
I agree that toggling it with bindist should be ok, I just wanted to make sure possible issues aren't missed.
And (slightly off-topic) I'd also be grateful if someone could look into these
    filter-flags -fPIC -fPIE
    append-flags -D__STDC_LIMIT_MACROS
    is-flag -O? || append-flags -O2
and report proper bugs upstream (or just to me) if there are still issues (except slower speed), and if not get rid of them.
Comment 10 Sebastian Pipping gentoo-dev 2010-02-28 00:50:38 UTC
(In reply to comment #2)
> Created an attachment (id=214957) [details]
> bs2b dep
> 
> Dependency on libbs2b was missed.

FYI this has been fixed for bug #287993 by now.
Comment 11 Alexis Ballier gentoo-dev 2010-04-24 12:44:36 UTC
(In reply to comment #4)
> Created an attachment (id=214960) [details]
> subs without X
> 
> It is possible to use subtitle rendering in mencoder even if X server is not
> installed (I sometimes use this on my home X-less server to convert video). So
> ass and truetype should not relate to the "X" use flag.
> 

applied this one to -9999
Comment 12 Alexis Ballier gentoo-dev 2010-04-24 13:03:47 UTC
(In reply to comment #8)
> (In reply to comment #6)
> > Apache 2.0 license is not compatible with GPLv2, only with GPLv3.
> > I do not know if all of MPlayer can be relicensed as GPLv3, I actually doubt
> > it.
> > Which means that the issue to my knownledge is basically unchanged: compiling
> > your own binary with AMR support is ok, distributing the resulting binary is
> > not though.
> 
> Well, if we disable opencore-amr support for bindist, then everything should be
> ok: binary with AMR will not be distributed, sources will be build on local
> systems. Maybe a warning should be issued as well to aware from binary
> redistribution if AMR was included.
> 

-9999 now disables amr support with bindist useflag set
Comment 13 Alexis Ballier gentoo-dev 2010-04-24 13:04:30 UTC
Comment on attachment 214956 [details, diff]
return back opencore-amr support

patch merged -> obsolete
Comment 14 Alexis Ballier gentoo-dev 2010-04-24 13:04:50 UTC
Comment on attachment 214960 [details, diff]
subs without X

patch merged -> obsolete
Comment 15 Alexis Ballier gentoo-dev 2010-04-24 13:05:05 UTC
Comment on attachment 214957 [details, diff]
bs2b dep

patch merged -> obsolete
Comment 16 Alexis Ballier gentoo-dev 2010-04-24 13:30:28 UTC
(In reply to comment #3)
> Created an attachment (id=214958) [details]
> cdparanoia dep fix
> 
> If both cdio and cdparanoia are specified, cdio will be used. Thus depend on
> cdparanoia only if cdio is not requested.
> 

applied in -9999
Comment 17 Alexis Ballier gentoo-dev 2010-04-24 13:30:43 UTC
Comment on attachment 214958 [details, diff]
cdparanoia dep fix

patch merged -> obsolete
Comment 18 Alexis Ballier gentoo-dev 2010-04-24 13:56:16 UTC
(In reply to comment #5)
> Created an attachment (id=214961) [details]
> docs enhancement
> 
> 1) This patch generates docs for only those languages which are present in
> $LINGUAS. It was proposed earlier, but is not used for some reason, at least
> now. So, this is try #2.
> 
> 2) In current ebuild html docs will be installed in the tech/mirrors/ because
> of docinto directive below html docs installation. This patch also fixes this
> and installes html docs in the html dir.
> 

merged a (imho) simplified version of this patch in -9999
Comment 19 Alexis Ballier gentoo-dev 2010-04-24 13:56:30 UTC
Comment on attachment 214961 [details, diff]
docs enhancement

patch merged -> obsolete
Comment 20 Alexis Ballier gentoo-dev 2010-04-24 14:12:48 UTC
(In reply to comment #9)
> And (slightly off-topic) I'd also be grateful if someone could look into these
>     filter-flags -fPIC -fPIE

most likely because of poor registers on x86; this is filtered only on x86 now

>     append-flags -D__STDC_LIMIT_MACROS

bug #127901, seems unneeded, dropped

>     is-flag -O? || append-flags -O2

just a guess: doesn't mplayer fail at -O0 ?


All changes should be merged now, everyone happy, closing bug; thanks for the improvements!