Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 299090 - [EBUILD] mail-filter/dspam 3.10.0 and -9999 (GIT MASTER)
Summary: [EBUILD] mail-filter/dspam 3.10.0 and -9999 (GIT MASTER)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement with 2 votes (vote)
Assignee: Net-Mail Packages
URL:
Whiteboard:
Keywords:
: 360645 377383 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-12-31 11:56 UTC by steveb
Modified: 2011-08-05 06:47 UTC (History)
12 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mail-filter/dspam/files/dspam.initd (dspam.initd,1.23 KB, text/plain)
2009-12-31 11:56 UTC, steveb
Details
mail-filter/dspam/files/logrotate.dspam (logrotate.dspam,156 bytes, text/plain)
2009-12-31 11:57 UTC, steveb
Details
mail-filter/dspam/files/pgsql_createdb.py (pgsql_createdb.py,4.41 KB, text/plain)
2009-12-31 11:57 UTC, steveb
Details
mail-filter/dspam/files/pgsql_purge.py (pgsql_purge.py,1.21 KB, text/plain)
2009-12-31 11:58 UTC, steveb
Details
mail-filter/dspam/files/README.postfix (README.postfix,309 bytes, text/plain)
2009-12-31 11:58 UTC, steveb
Details
mail-filter/dspam/files/README.qmail (README.qmail,2.26 KB, text/plain)
2009-12-31 11:58 UTC, steveb
Details
mail-filter/dspam/dspam-3.9.0_rc2.ebuild (dspam-3.9.0_rc2.ebuild,20.11 KB, text/plain)
2009-12-31 11:59 UTC, steveb
Details
mail-filter/dspam/dspam-999999.ebuild (dspam-999999.ebuild,20.06 KB, text/plain)
2009-12-31 11:59 UTC, steveb
Details
mail-filter/dspam/files/logrotate.dspam (logrotate.dspam,130 bytes, text/plain)
2010-01-11 22:31 UTC, steveb
Details
mail-filter/dspam/dspam-3.9.0.ebuild (dspam-3.9.0.ebuild,19.99 KB, text/plain)
2010-01-11 22:48 UTC, steveb
Details
check_storage_drivers.patch (check_storage_drivers.patch,633 bytes, patch)
2010-01-15 21:32 UTC, Tom Hendrikx
Details | Diff
mail-filter/dspam/dspam-3.9.0.ebuild (dspam-3.9.0.ebuild,20.22 KB, text/plain)
2010-01-15 23:22 UTC, steveb
Details
mail-filter/dspam/dspam-999999.ebuild (dspam-999999.ebuild,20.31 KB, text/plain)
2010-01-15 23:22 UTC, steveb
Details
mail-filter/dspam/files/dspam.initd (dspam.initd,1.12 KB, text/plain)
2010-01-15 23:23 UTC, steveb
Details
dspam_maintenance_in_PATH.patch (dspam_maintenance_in_PATH.patch,777 bytes, patch)
2010-01-16 13:43 UTC, Tom Hendrikx
Details | Diff
mail-filter/dspam/dspam-3.9.0.ebuild (dspam-3.9.0.ebuild,20.48 KB, text/plain)
2010-01-16 14:00 UTC, steveb
Details
mail-filter/dspam/dspam-999999.ebuild (dspam-999999.ebuild,20.58 KB, text/plain)
2010-01-16 14:01 UTC, steveb
Details
dspam-3.9.0-dspam_maintenance.sh.patch (dspam-3.9.0-dspam_maintenance.sh.patch,2.79 KB, text/plain)
2010-01-16 15:20 UTC, Tom Hendrikx
Details
mail-filter/dspam/dspam-3.9.0.ebuild (dspam-3.9.0.ebuild,20.67 KB, text/plain)
2010-04-13 20:24 UTC, steveb
Details
mail-filter/dspam/dspam-999999.ebuild (dspam-999999.ebuild,20.76 KB, text/plain)
2010-04-13 20:24 UTC, steveb
Details
/etc/init.d/dspam for dspam-3.9.1-rc1 (dspam.initd,1.35 KB, application/octet-stream)
2011-06-06 13:40 UTC, Wicher Minnaard
Details
/etc/conf.d/dspam for dspam-3.9.1-rc1 (in files/) (dspam.confd,261 bytes, application/octet-stream)
2011-06-06 13:41 UTC, Wicher Minnaard
Details
ebuild for dspam-3.9.1-RC1 (dspam-3.9.1_rc1.ebuild,20.76 KB, application/octet-stream)
2011-06-06 13:42 UTC, Wicher Minnaard
Details
dspam-3.9.1_rc1-r1 (dspam-3.9.1_rc1-r1.ebuild,20.89 KB, application/octet-stream)
2011-06-06 14:34 UTC, Wicher Minnaard
Details
files/dspam-3.9.1_rc1-lmtp-client-unsolicited-SIZE.patch (dspam-3.9.1_rc1-lmtp-client-unsolicited-SIZE.patch,4.38 KB, patch)
2011-06-06 14:34 UTC, Wicher Minnaard
Details | Diff
dspam-3.10.0.ebuild (dspam-3.10.0.ebuild,20.93 KB, text/plain)
2011-08-02 21:46 UTC, Stevan Bajić
Details
dspam-999999.ebuild (dspam-999999.ebuild,21.02 KB, text/plain)
2011-08-02 21:47 UTC, Stevan Bajić
Details
files/dspam.confd (dspam.confd,92 bytes, text/plain)
2011-08-02 21:47 UTC, Stevan Bajić
Details
files/dspam.initd (dspam.initd,1.65 KB, text/plain)
2011-08-02 21:47 UTC, Stevan Bajić
Details
mail-filter/dspam/dspam-3.10.0.ebuild (dspam-3.10.0.ebuild,5.74 KB, text/plain)
2011-08-04 21:29 UTC, Tom Hendrikx
Details
mail-filter/dspam/files/dspam.confd (dspam.confd,251 bytes, text/plain)
2011-08-04 21:30 UTC, Tom Hendrikx
Details
mail-filter/dspam/files/dspam.cron (dspam.cron,160 bytes, text/plain)
2011-08-04 21:30 UTC, Tom Hendrikx
Details
mail-filter/dspam/files/dspam.logrotate (dspam.logrotate,180 bytes, text/plain)
2011-08-04 21:30 UTC, Tom Hendrikx
Details
mail-filter/dspam/files/dspam.initd (dspam.initd,649 bytes, text/plain)
2011-08-04 21:33 UTC, Tom Hendrikx
Details
mail-filter/dspam/metadata.xml (metadata.xml,971 bytes, text/plain)
2011-08-04 21:39 UTC, Tom Hendrikx
Details

Note You need to log in before you can comment on or make changes to this bug.
Description steveb 2009-12-31 11:56:10 UTC
Ebuilds for DSPAM 3.9.0 RC2 and DSPAM GIT

Reproducible: Always
Comment 1 steveb 2009-12-31 11:56:44 UTC
Created attachment 214722 [details]
mail-filter/dspam/files/dspam.initd
Comment 2 steveb 2009-12-31 11:57:26 UTC
Created attachment 214726 [details]
mail-filter/dspam/files/logrotate.dspam
Comment 3 steveb 2009-12-31 11:57:44 UTC
Created attachment 214727 [details]
mail-filter/dspam/files/pgsql_createdb.py
Comment 4 steveb 2009-12-31 11:58:04 UTC
Created attachment 214729 [details]
mail-filter/dspam/files/pgsql_purge.py
Comment 5 steveb 2009-12-31 11:58:20 UTC
Created attachment 214730 [details]
mail-filter/dspam/files/README.postfix
Comment 6 steveb 2009-12-31 11:58:34 UTC
Created attachment 214731 [details]
mail-filter/dspam/files/README.qmail
Comment 7 steveb 2009-12-31 11:59:04 UTC
Created attachment 214733 [details]
mail-filter/dspam/dspam-3.9.0_rc2.ebuild

Ebuild for DSPAM 3.9.0 RC2
Comment 8 steveb 2009-12-31 11:59:31 UTC
Created attachment 214735 [details]
mail-filter/dspam/dspam-999999.ebuild

Ebuild for DSPAM GIT
Comment 9 steveb 2010-01-11 22:31:04 UTC
Created attachment 216134 [details]
mail-filter/dspam/files/logrotate.dspam

/var/log/dspam/system.log should not be rotated. The maintenance script is purging system.log based on age.
Comment 10 steveb 2010-01-11 22:48:36 UTC
Created attachment 216137 [details]
mail-filter/dspam/dspam-3.9.0.ebuild

Ebuild for 3.9.0 which is just released 2 minutes ago :)

I would advise Gentoo users to wait for 3.9.1 which we are going to release in one to two weeks (counting from 12.01.2010 (which is btw our 1 year anniversary as a community project)).
Comment 11 Tom Hendrikx 2010-01-15 21:32:12 UTC
Created attachment 216650 [details, diff]
check_storage_drivers.patch

The dspam-3.9.0.ebuild dies during configure when no storage driver is selected. Attached patch adds a check that ensures that at least 1 storage driver is enabled.
Comment 12 steveb 2010-01-15 23:22:00 UTC
Created attachment 216656 [details]
mail-filter/dspam/dspam-3.9.0.ebuild

(In reply to comment #11)
> The dspam-3.9.0.ebuild dies during configure when no storage driver is
> selected. Attached patch adds a check that ensures that at least 1 storage
> driver is enabled.
> 
Thanks Tom. Here the modified Ebuild for 3.9.0.
Comment 13 steveb 2010-01-15 23:22:27 UTC
Created attachment 216658 [details]
mail-filter/dspam/dspam-999999.ebuild

Fixed Ebuild (thanks Tom).
Comment 14 steveb 2010-01-15 23:23:56 UTC
Created attachment 216660 [details]
mail-filter/dspam/files/dspam.initd

No need to check for ServerPID. DSPAM can work in daemon mode (for example acting as a gateway) without using ServerPID.
Comment 15 Tom Hendrikx 2010-01-16 13:43:48 UTC
Created attachment 216678 [details, diff]
dspam_maintenance_in_PATH.patch

This patch moves dspam_maintenance script to /usr/bin in stead of /etc/cron.daily. A replacement cron file that runs the script is generated.

This allows for much more flexibility, such as adding custom arguments to the cron file, or adding debug output in dspam_maintenance that does not show up when run from cron.
Comment 16 steveb 2010-01-16 14:00:44 UTC
Created attachment 216680 [details]
mail-filter/dspam/dspam-3.9.0.ebuild

(In reply to comment #15)
> 
> This patch moves dspam_maintenance script to /usr/bin in stead of
> /etc/cron.daily. A replacement cron file that runs the script is generated.
> 
> This allows for much more flexibility, such as adding custom arguments to the
> cron file, or adding debug output in dspam_maintenance that does not show up
> when run from cron.
> 
Thanks Tom. Updated the Ebuild with your patch.
Comment 17 steveb 2010-01-16 14:01:37 UTC
Created attachment 216681 [details]
mail-filter/dspam/dspam-999999.ebuild

Updated Ebuild with Tom's patch for the DSPAM cron script.
Comment 18 Tom Hendrikx 2010-01-16 15:20:44 UTC
Created attachment 216684 [details]
dspam-3.9.0-dspam_maintenance.sh.patch

Bugfixes for dspam_maintenance:
- adding some debug output
- fix for invalid pgsql script paths
- fix for when dspam is built with a single storage driver: avoid running data cleanup twice

The dspam_maintenance script is already refactored upstream, so this patch only applies to 3.9.0 version.
Comment 19 steveb 2010-01-19 11:35:27 UTC
(In reply to comment #18)
> Created an attachment (id=216684) [details]
> dspam-3.9.0-dspam_maintenance.sh.patch
> 
> Bugfixes for dspam_maintenance:
> - adding some debug output
> - fix for invalid pgsql script paths
> - fix for when dspam is built with a single storage driver: avoid running data
> cleanup twice
> 
> The dspam_maintenance script is already refactored upstream, so this patch only
> applies to 3.9.0 version.
> 
Can you check if the script in GIT HEAD is doing what it should do?
--------------------
http://dspam.git.sourceforge.net/git/gitweb.cgi?p=dspam/dspam;a=blob_plain;f=contrib/dspam_maintenance/dspam_maintenance.sh;hb=HEAD
--------------------

To get additional output you should/could execute the script with "--verbose".
Comment 20 Tom Hendrikx 2010-01-22 15:58:18 UTC
(In reply to comment #19)
> Can you check if the script in GIT HEAD is doing what it should do?
> 
> To get additional output you should/could execute the script with "--verbose".
> 

Hi, just looked at it. Bugs fixed (for pgsql driver that I am able to test), and nice output. Thanks :)
Comment 21 steveb 2010-01-27 15:48:07 UTC
(In reply to comment #20)
> ....
> and nice output. Thanks :)
> 
Guess which text was used as template for the output? :)
Thanks for your help.
Comment 22 theboywho 2010-04-13 09:53:34 UTC
The dspam-3.9.0 ebuild only works if you already have the dspam user and groupon your system.

Otherwise the install phase complains that the dspam user doesn't exist.
Comment 23 steveb 2010-04-13 20:17:33 UTC
(In reply to comment #22)
> The dspam-3.9.0 ebuild only works if you already have the dspam user and
> groupon your system.
> 
> Otherwise the install phase complains that the dspam user doesn't exist.
> 
I know. I fixed that in my local repo but have not update the Ebuild here. Will do that right now. Give me 5 minutes....
Comment 24 steveb 2010-04-13 20:24:11 UTC
Created attachment 227655 [details]
mail-filter/dspam/dspam-3.9.0.ebuild
Comment 25 steveb 2010-04-13 20:24:31 UTC
Created attachment 227657 [details]
mail-filter/dspam/dspam-999999.ebuild
Comment 26 Tom Hendrikx 2010-06-16 22:03:13 UTC
(In reply to comment #10)
> I would advise Gentoo users to wait for 3.9.1 which we are going to release in
> one to two weeks (counting from 12.01.2010 (which is btw our 1 year anniversary
> as a community project)).
> 

Any reason to keep this version from portage? I've been running this since 3.9.0-rc2 without any issues...
Comment 27 Stevan Bajić 2010-06-23 19:06:13 UTC
(In reply to comment #26)
> (In reply to comment #10)
> > I would advise Gentoo users to wait for 3.9.1 which we are going to release in
> > one to two weeks (counting from 12.01.2010 (which is btw our 1 year anniversary
> > as a community project)).
> > 
> 
> Any reason to keep this version from portage? I've been running this since
> 3.9.0-rc2 without any issues...
> 
There is one small reason: I am going soon (next days) to release 3.9.1.
Comment 28 Johan Bergström 2010-11-11 14:22:35 UTC
Contrats on the anniversary. Was wondering if 3.9.0 will possibly hit the tree, or should we wait for 3.9.1? (Seems to be in RC stage)
Comment 29 James Young 2010-11-26 03:34:00 UTC
Are you planning to release dspam 3.9.0 at all?  It's been nearly 8 months since the last post on here.
Comment 30 Sven Schwyn (svoop) 2010-12-09 11:23:34 UTC
Maybe a reason not to wait for 3.9.1 (unless really imminent):

Stable dspam-3.8 and postgresql-server-8.4.4 cause tons of "HINT: Use the escape string syntax for backslashes" messages, so things may break in the future (or already do for those who use unstable Postgres which I don't).
Comment 31 Eray Aslan gentoo-dev 2011-03-27 06:55:43 UTC
*** Bug 360645 has been marked as a duplicate of this bug. ***
Comment 32 Wicher Minnaard 2011-06-06 13:40:49 UTC
Created attachment 276007 [details]
/etc/init.d/dspam for dspam-3.9.1-rc1
Comment 33 Wicher Minnaard 2011-06-06 13:41:32 UTC
Created attachment 276009 [details]
/etc/conf.d/dspam for dspam-3.9.1-rc1 (in files/)
Comment 34 Wicher Minnaard 2011-06-06 13:42:26 UTC
Created attachment 276011 [details]
ebuild for dspam-3.9.1-RC1
Comment 35 Wicher Minnaard 2011-06-06 13:44:18 UTC
I've made a dspam-3.9.1_rc1 based on the ebuilds above and various tweaks/fixes. It's in my overlay at
http://mestvaelt.gavagai.nl:8080/file/tip/mail-filter/dspam

Tweaks/Fixes:
- It would be nice if /etc/init.d/dspam would support running as some other user than root. Some users, such as I, run the dspam daemon as dspam:dspam - when only using virtual users, delivering over LMTP, there's no need for dspam to switch uids and hence no need for it to run as root.

- logrotate is not a build requirement

- virtual/postgresql-base is now dev-db/postgresql-base.

Changed files attached to this bug.
Comment 36 Wicher Minnaard 2011-06-06 14:34:10 UTC
Created attachment 276019 [details]
dspam-3.9.1_rc1-r1

With patch for unsollicited SIZE parameter in LMTP conversation.
Comment 37 Wicher Minnaard 2011-06-06 14:34:59 UTC
Created attachment 276021 [details, diff]
files/dspam-3.9.1_rc1-lmtp-client-unsolicited-SIZE.patch

Patch to client.c for unsollicited SIZE parameter in LMTP conversation.
Comment 38 Stevan Bajić 2011-06-06 23:45:43 UTC
(In reply to comment #37)
> Created attachment 276021 [details, diff]
> files/dspam-3.9.1_rc1-lmtp-client-unsolicited-SIZE.patch
> 
> Patch to client.c for unsollicited SIZE parameter in LMTP conversation.

So you are porting back stuff from MASTER to RC1? I might release DSPAM 3.9.1 in the next weeks (if all the other admins of the project agree on 3.9.1).
Comment 39 Wicher Minnaard 2011-06-07 09:16:39 UTC
(In reply to comment #38)
> (In reply to comment #37)
> > Created attachment 276021 [details, diff]
> > files/dspam-3.9.1_rc1-lmtp-client-unsolicited-SIZE.patch
> > 
> > Patch to client.c for unsollicited SIZE parameter in LMTP conversation.
> 
> So you are porting back stuff from MASTER to RC1? I might release DSPAM 3.9.1
> in the next weeks (if all the other admins of the project agree on 3.9.1).

No, not really 'stuff' in the general sense, but yes, I sinfully cherrypicked your fixes to client.c ;-)

It solves the problem of DSPAM not talking to Dovecot (2.0.13) over LMTP. I really need that. I needed to spend some time with a packet sniffer to get to the root of the problem and it appears to have been reported (and fixed by you, thanks!) a little less than a year ago (bug ID 3020344 on the SF dspam bugtracker).

Since I don't follow the -devel and -commit mailing lists, I don't know the state of MASTER. That's why I went for 3.9.1_RC1, and brought it out here on the gentoo bug tracker so other gentoo users confronted with LMTP problems don't have to whip out packet sniffers and hunt for patches ;-)

Good to hear that you might release 3.9.1 in the coming weeks. Will your LMTP patches to client.c go into that release? That would be great.
Comment 40 Stevan Bajić 2011-06-08 10:41:10 UTC
(In reply to comment #39)
> Good to hear that you might release 3.9.1 in the coming weeks. Will your LMTP
> patches to client.c go into that release? That would be great.
> 
Yes. The LMTP patch will be included.
Comment 41 Eray Aslan gentoo-dev 2011-08-02 12:20:45 UTC
*** Bug 377383 has been marked as a duplicate of this bug. ***
Comment 42 Stevan Bajić 2011-08-02 21:46:56 UTC
Created attachment 281899 [details]
dspam-3.10.0.ebuild
Comment 43 Stevan Bajić 2011-08-02 21:47:13 UTC
Created attachment 281901 [details]
dspam-999999.ebuild
Comment 44 Stevan Bajić 2011-08-02 21:47:37 UTC
Created attachment 281903 [details]
files/dspam.confd
Comment 45 Stevan Bajić 2011-08-02 21:47:54 UTC
Created attachment 281905 [details]
files/dspam.initd
Comment 46 Tom Hendrikx 2011-08-04 21:29:27 UTC
Created attachment 282111 [details]
mail-filter/dspam/dspam-3.10.0.ebuild

Attached is a new and completely rewritten ebuild for dspam, which is clean and easy to read and maintain. Gentoo devs, please consider this ebuild for inclusion in the main portage tree. 

If there is any reason why the ebuild can not be added to the main portage tree in its current state, then please provide feedback so we can improve the ebuild.
Comment 47 Tom Hendrikx 2011-08-04 21:30:00 UTC
Created attachment 282113 [details]
mail-filter/dspam/files/dspam.confd
Comment 48 Tom Hendrikx 2011-08-04 21:30:29 UTC
Created attachment 282115 [details]
mail-filter/dspam/files/dspam.cron
Comment 49 Tom Hendrikx 2011-08-04 21:30:54 UTC
Created attachment 282117 [details]
mail-filter/dspam/files/dspam.logrotate
Comment 50 Tom Hendrikx 2011-08-04 21:33:08 UTC
Created attachment 282119 [details]
mail-filter/dspam/files/dspam.initd
Comment 51 Tom Hendrikx 2011-08-04 21:39:09 UTC
Created attachment 282121 [details]
mail-filter/dspam/metadata.xml
Comment 52 Eray Aslan gentoo-dev 2011-08-05 06:47:54 UTC
Committed with slight changes.  Thank you.

+*dspam-3.10.0 (05 Aug 2011)
+
+  05 Aug 2011; Eray Aslan <eras@gentoo.org> +dspam-3.10.0.ebuild,
+  +files/dspam.confd, +files/dspam.cron, +files/dspam.initd,
+  +files/dspam.logrotate, metadata.xml:
+  version bump - bug #299090. Ebuild thanks to Tom Hendrikx
+