Since the 1.6 version bump, the cegui use flag is no more, but CEGUIRenderer is built only if dev-games/cegui has been built at the configure time. Reproducible: Always Steps to Reproduce: 1. emerge ogre 2. emerge cegui Actual Results: CEGUIRenderer is not built Very simple to fix, simply add cegui? ( dev-games/cegui ) to the RDEPEND of the dev-games/ogre-1.6 ebuild
The cegui use flag was removed from ogre-1.6.2.ebuild (1.1->1.2) It seems to have been a tidying up exercise, "no need for cegui flag since it it only used for sample programs" The flaw here is you might want to do more with Ogre than just build the samples.
It's not only needed for the samples, it's needed for applications using both CEGUI and Ogre, relying on the OgreCEGUIRenderer, which is only built if CEGUI has been built before.
I'll take a patch for this but just changing the deps isn't good enough. If it's automagic deps on cegui then it's not good enough.
"I'll take a patch for this but just changing the deps isn't good enough. If it's automagic deps on cegui then it's not good enough." Changing the deps isn't good enough? What should be done then? This seems like a perfect use for USE flags.
It's not good enough to just change the deps for the ebuild if the package itself doesn't do what we expect after that. Imagine you have USE=-cegui but have cegui installed on your system for some reason. Then you install ogre and expect it to not depend on cegui but it links against it anyhow. Next you remove cegui. Now your system is broken and the package manager doesn't know about it because as far as it's concerned, there is no dependency between cegui and ogre.
Oh I see what you mean, thanks for clearing that up. When I get back home to my gentoo system next week I'll try writing a patch that meets those requirements.
Created attachment 224805 [details, diff] Patch for the ogre-1.6.5.ebuild which adds the cegui use flag This patch adds the cegui use flag to the ogre-1.6.5.ebuild file. If the use flag is enabled it passes --enable-cegui to the configure script. If the use flag is disable it passes --disable-cegui. This patch requires a patch to the ogre build scripts since they don't support the --enable/disable-cegui options.
Created attachment 224807 [details, diff] Patches the acinclude.m4 file in the ogre distribution to support enabling/disabling the build of CEGUIRenderer. This patch add's the options --enable-cegui and --disable-cegui to the configure script so that the user can explicitly enable or disable building of the CEGUIRenderer classes. I've tested this patch with the patched ebuild. With USE=cegui, the CEGUI renderer is built. With USE=cegui the CEGUI renderer is not build regardless of whether or not dev-games/cegui is installed. The original build scripts were automagically dependant on cegui. If the dev-games/cegui was installed it would automatically build the CEGUIRenderer.
Nice work. In portage.
