Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 297503 - Stable =media-video/gpac-0.4.5-r1
Summary: Stable =media-video/gpac-0.4.5-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2009-12-19 11:28 UTC by Samuli Suominen (RETIRED)
Modified: 2010-01-31 16:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
declare glx function prototype (glx-define-prototype.patch,561 bytes, patch)
2009-12-20 16:12 UTC, Markos Chandras (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2009-12-19 11:28:57 UTC
One line difference to 0.4.5 which has been in tree since 31 Jan 2009. 
No known regressions.

Please test & mark stable.
Comment 1 Markos Chandras (RETIRED) gentoo-dev 2009-12-20 16:12:17 UTC
Created attachment 213579 [details, diff]
declare glx function prototype

Ok there was an error on amd64 system

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:         
 * /usr/lib64/gpac/gm_jack.so                                          
 * /usr/lib64/gpac/gm_alsa.so                                          
 * /usr/lib64/gpac/gm_oss_audio.so                                     
 * /usr/lib64/gpac/gm_pulseaudio.so                                    


 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.               
 * compositor/visual_manager_3d_gl.c:102: warning: implicit declaration of function 'glXGetProcAddress'
 * compositor/visual_manager_3d_gl.c:102: warning: implicit declaration of function 'glXGetProcAddress'

 * 
 * QA Notice: Package has poor programming practices which may compile
 *            but will almost certainly crash on 64bit architectures.
 *
 * Function `glXGetProcAddress' implicitly converted to pointer at compositor/visual_manager_3d_gl.c:102
 * Function `glXGetProcAddress' implicitly converted to pointer at compositor/visual_manager_3d_gl.c:102
 *
 *  Please file a bug about this at http://bugs.gentoo.org/
 *  with the maintaining herd of the package.

I created the trivial patch, committed it, and stabled the package. This patch wont affect the package in anyway. It is just a trivial way to make sure that gcc will compile and interprets the falling function correctly

So, to sum up. Stable on amd64
Comment 2 Christian Faulhammer (RETIRED) gentoo-dev 2010-01-01 16:16:00 UTC
x86 stable
Comment 3 Brent Baude (RETIRED) gentoo-dev 2010-01-06 19:11:10 UTC
ppc64 done
Comment 4 Brent Baude (RETIRED) gentoo-dev 2010-01-07 18:28:45 UTC
ppc done
Comment 5 Tobias Klausmann (RETIRED) gentoo-dev 2010-01-23 16:25:51 UTC
Stable on alpha.
Comment 6 Raúl Porcel (RETIRED) gentoo-dev 2010-01-31 15:59:13 UTC
sparc stable, closing
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2010-01-31 16:28:04 UTC
Reopening.

(In reply to comment #1)
> So, to sum up. Stable on amd64

gpac-0.4.5-r1.ebuild:KEYWORDS="alpha ~amd64 ppc ppc64 sparc x86 ~x86-fbsd"

?
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2010-01-31 16:38:10 UTC
(In reply to comment #7)
> Reopening.
> 
> (In reply to comment #1)
> > So, to sum up. Stable on amd64
> 
> gpac-0.4.5-r1.ebuild:KEYWORDS="alpha ~amd64 ppc ppc64 sparc x86 ~x86-fbsd"
> 
> ?
> 
Sorry I failed

Marked stable now on amd64