Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 297113 - dev-db/sqlite should use amalgamation source tarball
Summary: dev-db/sqlite should use amalgamation source tarball
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Arfrever Frehtes Taifersar Arahesis (RETIRED)
URL:
Whiteboard:
Keywords:
: 297213 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-12-16 00:35 UTC by Andrew Brouwers
Modified: 2020-05-25 11:19 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to use amalgamation (sqlite-amalgamation.diff,651 bytes, patch)
2009-12-16 00:36 UTC, Andrew Brouwers
Details | Diff
sqlite amalgamation patch (sqlite-amalgamation.diff,2.15 KB, patch)
2009-12-16 23:21 UTC, Andrew Brouwers
Details | Diff
Proper patch for SRC_URI (sqlite-amalgamation-v2.diff,1.10 KB, patch)
2009-12-16 23:30 UTC, Andrew Brouwers
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Brouwers 2009-12-16 00:35:11 UTC
As outlined on sqlite's website, it seems like we really should be using the "amalgamation" tarball for building sqlite:

http://www.sqlite.org/download.html

Further, 3.6.21 seems to build quite fine without requiring TCL to be installed on the system, so this can probably be dropped from the DEPEND section.  This is on a fully up-to-date amd64 system:

[ebuild   R   ] dev-db/sqlite-3.6.21  USE="readline threadsafe -debug -doc -fts3 -icu -soundex -tcl" 0 kB [?=>1]

[ebuild  N    ] dev-lang/tcl-8.5.7  USE="-debug -threads" 4,319 kB

Attached is a diff that builds the package well for me, and things like firefox still seem to behave fine.

Reproducible: Always
Comment 1 Andrew Brouwers 2009-12-16 00:36:07 UTC
Created attachment 213150 [details, diff]
Patch to use amalgamation
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-12-16 18:44:14 UTC
Amalgamation tarball doesn't contain tests and TCL bindings.
Comment 3 Andrew Brouwers 2009-12-16 19:01:24 UTC
(In reply to comment #2)
> Amalgamation tarball doesn't contain tests and TCL bindings.
> 

What about using a USE flag to distinguish them ?  I think the TCL dep kinda sucks, and alot of people don't need the extra stuff.
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-12-16 19:42:53 UTC
*** Bug 297213 has been marked as a duplicate of this bug. ***
Comment 5 Andrew Brouwers 2009-12-16 23:21:17 UTC
Created attachment 213248 [details, diff]
sqlite amalgamation patch

Attached is an updated patch, handling the case for +tcl and +test
Comment 6 Andrew Brouwers 2009-12-16 23:22:43 UTC
re-opening, with an updated patch that will handle the scenario of wanting tcl bindings or tests to be ran.  This will, if desired, pull in the proper tarballs for each scenario, allowing users to use the amalgamation sources if they do not need tcl or tests ran.
Comment 7 Andrew Brouwers 2009-12-16 23:30:36 UTC
Created attachment 213250 [details, diff]
Proper patch for SRC_URI

Sorry, last upload was the wrong file - this one should be good.
Comment 8 Petteri Räty (RETIRED) gentoo-dev 2009-12-19 11:56:44 UTC
+  19 Dec 2009; Petteri Räty <betelgeuse@gentoo.org> sqlite-3.6.21.ebuild:
+  Make building work without tcl installed using the amalgamation tarball
+  from upstream. Fixes tests to work with -tcl. Thanks to Andrew
+  <abrouwers@gmail.com>. Fixes bug #297113 and bug #297332.
+