Bugzilla Bug 2952

The balsa-1.3.5-r1 ebuild fails to patch the source because it tries to use the
balsa-1.3.5.patch instead of the balsa-1.3.5-r1.patch.

The solution is either to rename the diff or use ${PF} instead of ${P} in line 30:

    patch -p0 < ${FILESDIR}/${PF}.diff

The ebuild still has some problems. It seems that "make install" attempts to
write outside the sandbox:

/bin/sh ../mkinstalldirs /etc/sound/events
 /bin/install -c -m 644 ./balsa.soundlist /etc/sound/events/balsa.soundlist
ACCESS DENIED  unlink:    /etc/sound/events/balsa.soundlist
/bin/install: cannot remove `/etc/sound/events/balsa.soundlist': Permission denied
 /bin/install -c -m 644 ./email.soundlist /etc/sound/events/email.soundlist
ACCESS DENIED  unlink:    /etc/sound/events/email.soundlist
/bin/install: cannot remove `/etc/sound/events/email.soundlist': Permission denied
make[2]: *** [install-soundlistDATA] Error 1
make[2]: Leaving directory `/var/tmp/portage/balsa-1.3.5-r1/work/balsa-1.3.5/sounds'
make[1]: *** [install-am] Error 2
make[1]: Leaving directory `/var/tmp/portage/balsa-1.3.5-r1/work/balsa-1.3.5/sounds'
make: *** [install-recursive] Error 1

!!! ERROR: The ebuild did not complete successfully.
!!! Function src_install, Line 4, Exitcode 2
!!! make install failed

--------------------------- ACCESS VIOLATION SUMMARY ---------------------------
LOG FILE = "/tmp/sandbox-balsa-1.3.5-r1-22960.log"

unlink:    /etc/sound/events/balsa.soundlist
unlink:    /etc/sound/events/email.soundlist
--------------------------------------------------------------------------------
!!! emerge aborting on  /usr/portage/net-mail/balsa/balsa-1.3.5-r1.ebuild .

To eliminate the access violation it's necessary to add

  gnomeconfdir=${D}/etc

to the "make install" line, i.e., it should be

	make \
		prefix=${D}/usr \
		mandir=${D}/usr/share/man \
		gnomeconfdir=${D}/etc \
		gnomedatadir=${D}/usr/share install || die "make install failed"

Thanks for catching and fixing this :)