Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 294120 - [PATCH] app-i18n/uim-1.5.6-r4 breaks window close button for many Gnome applications
Summary: [PATCH] app-i18n/uim-1.5.6-r4 breaks window close button for many Gnome appli...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: CJK Team
URL: http://bugs.freedesktop.org/show_bug....
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-22 23:15 UTC by Alexandre Rostovtsev (RETIRED)
Modified: 2009-11-23 15:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
corrected delete event patch (uim-1.5.6-toplevel-delete-event-2.patch,842 bytes, patch)
2009-11-22 23:19 UTC, Alexandre Rostovtsev (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Rostovtsev (RETIRED) gentoo-dev 2009-11-22 23:15:21 UTC
app-i18n/uim-1.5.6-r4 was recently added to portage with the patch that I suggested to fix firefox crashes (see bug #287687). Unfortunately, it turns out the patch has a problem: it introduces a window delete event handler that returns void. In gtk+, if a delete event handler does not return FALSE, the event is not propagated to other handlers. In other words, uim intercepts the delete event, the application does not receive the delete event, and the window does not get closed; see
http://library.gnome.org/devel/gtk/stable/GtkWidget.html#GtkWidget-delete-event

As a result, with uim-1.5.6-r4, many Gnome applications (evince, gnome-terminal, gnote, epiphany etc.) cannot be closed via the window manager X button, and can only be closed using File->Close.

See also the Debian bug on the same issue: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=557341
Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev 2009-11-22 23:19:58 UTC
Created attachment 210936 [details, diff]
corrected delete event patch

This is a corrected delete event patch by Etsushi Kato to uim-1.5.6 that returns FALSE in the delete event handler and makes evince etc. windows close properly. Please use it instead of the uim-1.5.6-toplevel-delete-event.patch in portage.

According to http://bugs.freedesktop.org/show_bug.cgi?id=25139 this new patch will be part of the upcoming uim-1.5.7
Comment 2 MATSUU Takuto (RETIRED) gentoo-dev 2009-11-23 15:18:14 UTC
1.5.7 in cvs now. thanks.