Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 292867 - www-client/epiphany-2.26.3: preferences dialog resets Download directory
Summary: www-client/epiphany-2.26.3: preferences dialog resets Download directory
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords:
Depends on:
Blocks: gnome2.26
  Show dependency tree
 
Reported: 2009-11-12 03:00 UTC by James C. Georgas
Modified: 2010-01-11 12:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
epiphany-2.26.3-revert-downloadir.patch (epiphany-2.26.3-revert-downloadir.patch,1.24 KB, patch)
2010-01-06 14:29 UTC, Pacho Ramos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James C. Georgas 2009-11-12 03:00:13 UTC
With Epiphany 2.26.3, When I open the Preferences dialog, the Download folder gets reset to the "File System" dropdown item.

The /apps/epiphany/directories/downloads_folder gconf item gets reset to "/".

Reproducible: Always

Steps to Reproduce:
1. open Preferences dialog
2. set Download folder to Desktop or something. Note the value of the gconf key.
3. close Preferences dialog
4. download something and note that it goes to the specified directory.
5. open Preferences dialog.
6. note that the Download folder is reset to "File System". Note the value of the gconf key.
7. Download something and note that it fails (or goes into / if you have write permission).
Actual Results:  
Download folder value is reset to "/" whenever the preferences dialog is opened. 

Expected Results:  
Preferences dialog should read in the value of the gconf key and populate the dialog accordingly.
Comment 1 Pacho Ramos gentoo-dev 2009-11-14 21:11:24 UTC
This is an upstream bug:
https://bugzilla.gnome.org/show_bug.cgi?id=583616

But I doubt it will be ever fixed since 2.26 is no longer maintained by upstream :-/
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-11-15 15:27:37 UTC
marking needpatch since the issue most likely only requires bissecting or reading the git log to find out which commit fixed it.
Comment 3 Pacho Ramos gentoo-dev 2009-11-15 16:46:03 UTC
After checking on a local overlay, the problem appears in 2.26.1, 2.26.0 doesn't have it (and 2.27.0 has it also fixed)

I think that this is the culprit:
http://git.gnome.org/cgit/epiphany/commit/?h=gnome-2-26&id=7dbe33b5bfd99ff4ef116f8ccf4777edd8ade788
Comment 4 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-12-30 01:37:42 UTC
@pacho: Can you verify that the patch fixes the problem? If so, please go ahead and commit it; I can't test anything epiphany-2.26 related because I have xulrunner-1.9.2
Comment 5 Pacho Ramos gentoo-dev 2009-12-31 12:38:13 UTC
The problem is that reverting completely:
http://git.gnome.org/browse/epiphany/commit/?h=gnome-2-26&id=7dbe33b5bfd99ff4ef116f8ccf4777edd8ade788

would revert also the bug that originated that commit (seems that something related with "hog in mountpoints")
Comment 6 Pacho Ramos gentoo-dev 2010-01-06 14:29:38 UTC
Created attachment 215393 [details, diff]
epiphany-2.26.3-revert-downloadir.patch

This is the patch I would commit and the one I have tested and works fine :-D. It reverts exactly the same that is reverted in upstream trunk and 2.28-branch as explained in https://bugzilla.gnome.org/show_bug.cgi?id=583616#c13

Gnome team, simply put "Inclusion" keyword and I will be happy to commit it ;-)

Regards
Comment 7 Pacho Ramos gentoo-dev 2010-01-11 12:48:20 UTC
Just commited to epiphany-2.26.3-r3 , if you have any problems blame on me (and please CC me)

Thanks