Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 291734 - transcode 1.1.5 doesn't see libmpeg2 (no mpeg support)
Summary: transcode 1.1.5 doesn't see libmpeg2 (no mpeg support)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-03 17:58 UTC by Douglas J Hunley
Modified: 2009-11-05 19:41 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge.info,3.92 KB, text/plain)
2009-11-04 14:25 UTC, Douglas J Hunley
Details
config.log showing libmpeg2 support not requested (config.log,106.18 KB, text/plain)
2009-11-04 14:29 UTC, Douglas J Hunley
Details
build.log (build.log,618.88 KB, text/plain)
2009-11-04 14:33 UTC, Douglas J Hunley
Details
patch for this problem (trans.patch,1.22 KB, patch)
2009-11-04 21:39 UTC, Rafał Mużyło
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas J Hunley 2009-11-03 17:58:32 UTC
Something about the 1.1.5 release (maybe the ebuild?) doesn't detect libmpeg2. Once I upgraded from 1.1.4, I tried to rip a DVD and it failed saying there was no mpeg2 support. I noticed the ebuild has an 'mpeg' USE, so I added that to package.use and recompiled and there was still no mpeg2 support. I unmerged libmpeg2 and re-emerge it, no issues there. I then re-emerged transcode and the configure said libmpeg2 was not found.

Reproducible: Always

Steps to Reproduce:
1.upgrade transcode to 1.1.5
2.try ripping a dvd
3.observe the 'no mpeg2 support' error

Actual Results:  
Ripping a DVD (using dvdrip, if it matters) to AVI fails with transcode claiming there is no mpeg2 support

Expected Results:  
New ebuild should detect libmpeg2 properly like the previous ebuild did

Reverting to 1.1.4 (after removing the transcode entry from package.use that I added) returned transcode to a working state
Comment 1 Douglas J Hunley 2009-11-04 04:17:09 UTC
If you examine the configure log for 1.1.5, you'll see that configure says we aren't requesting libmpeg2 support whereas in 1.1.4 it says we are, and then it goes about determining where to find the header and .so 
Comment 2 Sebastian Luther (few) 2009-11-04 08:23:00 UTC
Please attach emerge --info, build.log and config.log.
Comment 3 Douglas J Hunley 2009-11-04 14:25:05 UTC
Created attachment 209212 [details]
emerge --info

emerge --info
Comment 4 Douglas J Hunley 2009-11-04 14:29:09 UTC
Created attachment 209215 [details]
config.log showing libmpeg2 support not requested
Comment 5 Douglas J Hunley 2009-11-04 14:33:41 UTC
Created attachment 209216 [details]
build.log

Note that it clearly says:
libmpeg2                       no
libmpeg2convert                no
and that the library builds just fine. Also, I did a ctrl-c after it finished building during the 'package up the image to install onto /' stage as I didn't want to let it finish and then have to downgrade again (I'm ripping DVDs using 1.1.4 as we speak and didn't want to deal w/ the breakage)
Comment 6 Rafał Mużyło 2009-11-04 20:40:02 UTC
Upstream made both of those optional and disabled
by default. So, it's time to add a new useflag,
make libmpeg2 optional dep in the ebuild
and add a couple use_enable switches
(actually, looking at those libs,
one useflag for both should be OK).
Comment 7 Douglas J Hunley 2009-11-04 20:48:54 UTC
do we need a _new_ USE flag? 'eix transcode' says:
[I] media-video/transcode
     Available versions:  1.0.7 (~)1.1.4 [m](~)1.1.5 {3dnow X a52 aac alsa altivec dv dvd extrafilters fame iconv imagemagick jpeg lzo mjpeg mmx mp3 mpeg network nuv ogg oss postproc quicktime sdl sse sse2 theora truetype v4l2 vorbis x264 xml xvid}

which shows an 'mpeg' flag already. However, in my testing, it doesn't look like the 1.1.5 ebuild respects it. Wouldn't that be the 'proper' way to advance this? Just pondering :)
Comment 8 Rafał Mużyło 2009-11-04 20:55:51 UTC
BTW, there's a really hilarious bit in configure.in:

AC_PROVIDE([AC_PROG_CXX])  dnl we don't want it!
AC_PROVIDE([AC_PROG_F77])  dnl likewise

Why is it so funny ?
Cause with libtool 2 those bits cause for those checks
to be run - exactly the opposite effect of the intended.
Comment 9 Rafał Mużyło 2009-11-04 21:09:02 UTC
In an old post on libtool mailing list it was said,
that the proper way (for 1.5) was:
define([AC_LIBTOOL_LANG_CXX_CONFIG], [:])dnl
define([AC_LIBTOOL_LANG_F77_CONFIG], [:])dnl

For libtool 2, is a non-issue.

Comment 10 Rafał Mużyło 2009-11-04 21:27:46 UTC
As for comment 7:
you've probably found a bug in eix, cause there's no such flag
in transcode 1.1.5 (or you still have 1.0.7 -
in later ebuilds that was changed to mp3).
Comment 11 Rafał Mużyło 2009-11-04 21:32:05 UTC
Correction:
mpeg in 1.0.7 was used for libmpeg3 (mp3 was already in use),
in 1.1.4, libmpeg3 was no longer a dep, so useflag was removed.
Comment 12 Rafał Mużyło 2009-11-04 21:39:45 UTC
Created attachment 209274 [details, diff]
patch for this problem

This is what I think is needed
(I'd say --disable-x86-textrels for x86 would be nice too,
but I already mentioned that elsewhere).
Comment 13 Douglas J Hunley 2009-11-04 21:48:20 UTC
as for comment #10:
must be an eix bug then as I've completely removed and reinstalled transcode
from this system and can verify the only thing installed currently is 1.1.4 and
eix still shows it. It looks like eix lists all the USE flags in any of the
available versions (and since 1.0.7 is the current 'stable' ebuild, the flag
exists there). Then again, how would it show that a given use flag was only
valid for _some_ of the available ebuilds? That'd get ugly quickly I think. :)  

But this is off-topic for the bug at hand. I was just asking if it'd be easier
to re-use the 'mpeg' flag for this than to introduce a new flag. I don't really
care _how_ yall make the dependency, as long as its there in 1.1.5-r1 or
whatever. :) Thx!
Comment 14 Douglas J Hunley 2009-11-04 21:51:25 UTC
heh, looks like that's exactly what you did in comment #12. awesome. now to find time to test this...
Comment 15 Frank 2009-11-05 10:19:08 UTC
(In reply to comment #12)
> Created an attachment (id=209274) [details]
> patch for this problem
> 
> This is what I think is needed
> (I'd say --disable-x86-textrels for x86 would be nice too,
> but I already mentioned that elsewhere).
> 

The proposed patch works and enables mpeg2 support as intended. 
Comment 16 Alexis Ballier gentoo-dev 2009-11-05 19:41:13 UTC
(In reply to comment #12)
> Created an attachment (id=209274) [details]
> patch for this problem
> 
> This is what I think is needed
> (I'd say --disable-x86-textrels for x86 would be nice too,
> but I already mentioned that elsewhere).
> 

thanks, applied