First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 29156
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Perl Devs @ Gentoo <perl@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Wayne Davison <gentoo@blorf.net>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
razor-taint.patch The razor patch from Mail-SpamAssassin patch Wayne Davison 2003-09-19 16:16 0000 1.08 KB Details | Diff
razor-ebuild.patch Patch for both the razor-2.36.ebuild and the razor-2.20.ebuild. patch Wayne Davison 2003-09-19 16:26 0000 787 bytes Details | Diff
razor-taint.patch The untaint patch from Mail-SpamAssassin 2.60 (final) patch Wayne Davison 2003-09-24 09:50 0000 2.08 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 29156 depends on: Show dependency tree
Show dependency graph
Bug 29156 blocks: 29404
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2003-09-19 16:08 0000 
The latest SpamAssassin release comes with a patch for razor that makes the
library work when perl's taint mode (-T) is turned on.  The patch is very simple
(it just untaints a couple variables), but it is required to avoid a fatal error
when an application calls the library with taint mode enabled.

I'll attach the razor patch and an ebuild patch to use it.

------- Comment #1 From Wayne Davison 2003-09-19 16:16:05 0000 ------- 
Created an attachment (id=18004) [edit]
The razor patch from Mail-SpamAssassin

Tweaked by me to remove the prefixed comments and to add the full path of the
files we're changing.

------- Comment #2 From Wayne Davison 2003-09-19 16:26:16 0000 ------- 
Created an attachment (id=18005) [edit]
Patch for both the razor-2.36.ebuild and the razor-2.20.ebuild.

This patch not only adds a src_unpack() section to apply the razor-taint.patch
(found in attachment 18004 [edit]), but it also makes the minor change of setting "P"
instead of "S" (since we need to refer to the modified P value in several
places and S depends on P, so it's easier this way).

The fix should be applied to both 2.36 and 2.20:

cd /usr/portage/net-mail/razor
patch -p0 <razor-ebuild.patch
patch -p0 razor-2.20.ebuild <razor-ebuild.patch

------- Comment #3 From Malte S. Stretz 2003-09-24 04:30:10 0000 ------- 
The attached patch against Razor is an older one. There's now a revisited one
in the 
SpamAssassin 2.60-final tarball.

------- Comment #4 From Wayne Davison 2003-09-24 09:50:45 0000 ------- 
Created an attachment (id=18269) [edit]
The razor patch from Mail-SpamAssassin 2.60 (final)

Updated the patch to the version from Mail-SpamAssassin's final 2.60 release.
Also updated the line numbers to match the 2.36 release's files.

------- Comment #5 From Wayne Davison 2003-09-24 09:57:05 0000 ------- 
One extra note: if the untaint patch is used with the 2.20 release, it will
generate some *.orig files (since the line numbers aren't quite the same) and
they will be installed into the perl library dir.  Thus, the 2.20 ebuild would
need the patch command to be tweaked to add the --no-backup-if-mismatch option
to avoid this.

------- Comment #6 From Robert Coie (RETIRED) 2003-09-26 16:32:30 0000 ------- 
2.36 is patched in -r1.

------- Comment #7 From SpanKY 2004-01-20 16:19:25 0000 ------- 
guess rac forgot to close out this bug ;)
First Last Prev Next    No search results available      Search page      Enter new bug