Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 289547 - app-i18n/ibus-1.2.0.20091014 (previous too): minor corrections of ebuild
Summary: app-i18n/ibus-1.2.0.20091014 (previous too): minor corrections of ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: CJK Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-18 04:47 UTC by Rafał Mużyło
Modified: 2009-10-19 16:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
fixes _FORTIFY_SOURCE warning (warning.patch,1.41 KB, patch)
2009-10-18 04:52 UTC, Rafał Mużyło
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mużyło 2009-10-18 04:47:56 UTC
OK, very little about ebuild -
it needs gnome2_icon_cache_update (and perhaps two keepdir lines,
as on reemerge it removes /usr/share/ibus/icons and /usr/share/ibus/engine
- unless those dirs aren't needed).

More about something else.
I took a look on client/x11/main.c, to see if something can be done
about that _FORTIFY_SOURCE related warning.
That code needs a lot cleanup work, IMHO.

But anyway, I think I created a patch that looks correct to me
(if somebody sees a bug in it, feel free to correct me).
Should be upstreamed.
Comment 1 Rafał Mużyło 2009-10-18 04:52:46 UTC
Created attachment 207446 [details, diff]
fixes _FORTIFY_SOURCE warning

That define in the source is probably a typo
and it makes sense only if defined before other inclusions.

(probably that 'exit' in main() should actually be 'return',
but decided not to touch it)
Comment 2 MATSUU Takuto (RETIRED) gentoo-dev 2009-10-19 16:40:26 UTC
1.2.0.20091014-r1 in cvs.

Could you report _FORTIFY_SOURCE warning to upstream?