Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 28910 - Updated CFEngine ebuild v2.0.8p1
Summary: Updated CFEngine ebuild v2.0.8p1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Kurt Lieber (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-16 14:05 UTC by Russell Adams
Modified: 2003-10-07 08:55 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cfengine 2.0.8p1 ebuild (cfengine-2.0.8_p1.ebuild,1.05 KB, text/plain)
2003-09-16 14:06 UTC, Russell Adams
Details
updated ebuild (cfengine-2.0.8_p1.ebuild,1.11 KB, text/plain)
2003-09-16 14:37 UTC, Russell Adams
Details
Updated ebuild, again. (cfengine-2.0.8_p1.ebuild,1.21 KB, text/plain)
2003-09-24 15:29 UTC, Russell Adams
Details
Ebuild fixup, cleanup (cfengine-2.8.8_p1.ebuild.diff,1.42 KB, patch)
2003-09-29 21:28 UTC, Donnie Berkholz (RETIRED)
Details | Diff
Updated ebuild, including above patch. (cfengine-2.0.8_p1.ebuild,1.37 KB, text/plain)
2003-09-30 10:22 UTC, Russell Adams
Details
Whitespace fixed. (cfengine-2.0.8_p1.ebuild,1.38 KB, text/plain)
2003-09-30 10:41 UTC, Russell Adams
Details
New -r1 ebuild (cfengine-2.0.8_p1-r1.ebuild,1.44 KB, text/plain)
2003-10-02 15:39 UTC, Russell Adams
Details
Updated -r1 (cfengine-2.0.8_p1-r1.ebuild,1.65 KB, text/plain)
2003-10-05 11:54 UTC, Russell Adams
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Russell Adams 2003-09-16 14:05:08 UTC
Attached in _text_ is an updated ebuild for cfengine 2.0.8p1.

Please note the md5sum of cfengine-2.0.8p1.tar.gz should be:

17f9647edcc955e5c07489a6ac6126b1

I checked against multiple mirrors and verified the md5sum, unfortunately GPG
signed sources are not available.

Demo
Comment 1 Russell Adams 2003-09-16 14:06:24 UTC
Created attachment 17829 [details]
cfengine 2.0.8p1 ebuild
Comment 2 Russell Adams 2003-09-16 14:37:01 UTC
Minor update, see new attachment.

Demo
Comment 3 Russell Adams 2003-09-16 14:37:30 UTC
Created attachment 17831 [details]
updated ebuild
Comment 4 Jon Portnoy (RETIRED) gentoo-dev 2003-09-17 22:31:33 UTC
I know Kurt secretly loves development work...
Comment 5 Russell Adams 2003-09-24 15:29:38 UTC
Created attachment 18282 [details]
Updated ebuild, again.
Comment 6 solar (RETIRED) gentoo-dev 2003-09-29 18:25:24 UTC
Any dev that can test,

After converting Russell's ebuild Attachment #18282 [details] from spaces to tabs I
gave it a quick test. It failed for me with some configure errors (perhaps
trailing whitepace after \ ). Anyway Its not a pkg I maintain or have ever
used so somebody please find a way to get cfengine bumped to a more recent
version that does not contain the secuirty problems listed in this advisory.

http://packetstormsecurity.nl/0309-advisories/cfengine.txt
Comment 7 solar (RETIRED) gentoo-dev 2003-09-29 18:58:29 UTC
Trailing whitespace was the problem.

I have successfully run ebuild cfengine-2.0.8_p1.ebuild clean unpack compile

2.0.8_p1 commited to portage as ~arch
Comment 8 solar (RETIRED) gentoo-dev 2003-09-29 19:37:04 UTC
changing resolution to TEST-REQUEST
Comment 9 Donnie Berkholz (RETIRED) gentoo-dev 2003-09-29 21:28:43 UTC
Created attachment 18517 [details, diff]
Ebuild fixup, cleanup

This fixes some silly things in the ebuild.
Comment 10 solar (RETIRED) gentoo-dev 2003-09-30 00:10:32 UTC
Reopening bug,

Donnie please commit any changes you feel is needed on cfegnine.
Comment 11 Russell Adams 2003-09-30 10:22:39 UTC
Created attachment 18546 [details]
Updated ebuild, including above patch.

I've rolled the prior patch into this ebuild, added key generation if a key
doesn't already exist.

I had to get rid of the rm command, bypassing the make install completely.
Comparisons between an old installation vs this new installation show that
everything was installed in the proper locations, including the html files
now
going to the proper directory.

Demo
Comment 12 Russell Adams 2003-09-30 10:41:03 UTC
Created attachment 18547 [details]
Whitespace fixed.

I fixed any whitespace issues I could find. I'm using Emacs in shell mode,
which works quite nicely for ebuilds, so I'm uncertain where the whitespace
issues may have been. Hence, I removed all leading whitespace / indentation,
and reindented for consistency.

Demo
Comment 13 Russell Adams 2003-09-30 10:49:49 UTC
Warning from the CFEngine mailing list regarding OpenSSL vulnerability:

Date: Tue, 30 Sep 2003 12:42:06 -0400
From: Jeff Wasilko <jeffw@smoe.org>
To: help-cfengine@gnu.org
Subject: vuln in openssl
  
http://www.uniras.gov.uk/vuls/

------

See also: http://www.openssl.org/news/secadv_20030930.txt

This ebuild should be updated to require OpenSSL 0.9.7c or 0.9.6k when updated
ebuilds become available for OpenSSL.

Demo
Comment 14 solar (RETIRED) gentoo-dev 2003-09-30 21:13:01 UTC
The ebuilds for openssl are in the portage tree now.
Comment 15 Kurt Lieber (RETIRED) gentoo-dev 2003-10-02 06:51:34 UTC
minor nit: the cfengine documentation, as well as most other tutorials I've
seen place files in /var/cfengine/* instead of /var/lib/cfengine/*

Is there a good reason to place things in /var/lib/cfengine?  (especially
considering that cfengine really has very little to do with libraries...)

If not, can we adjust the ebuild to place files in the defacto standard /var/cfengine/*?
Comment 16 Russell Adams 2003-10-02 07:52:58 UTC
From http://www.iu.hio.no/cfengine/confdir/cfexecd.html

Some Unices are probably going to insist on changing /var/cfengine to /var/lib/cfengine
(Unix is a mess, isn't it?) so let's call the base directory WORKDIR. This
is a configurable parameter, which can be set in configure

./configure --with-workdir=WORKDIR 

-------------------------------------------------------------------------------

Next see http://www.pathname.com/fhs/2.2/fhs-5.1.html

Applications must generally not add directories to the top level of /var.
Such directories should only be added if they have some system-wide implication,
and in consultation with the FHS mailing list. 

-------------------------------------------------------------------------------

And then http://www.pathname.com/fhs/2.2/fhs-5.8.html

This hierarchy holds state information pertaining to an application or the
system. State information is data that programs modify while they run, and
that pertains to one specific host. Users must never need to modify files
in /var/lib to configure a package's operation.

State information is generally used to preserve the condition of an application
(or a group of inter-related applications) between invocations and between
different instances of the same application. State information should generally
remain valid after a reboot, should not be logging output, and should not
be spooled data.

--------------------------------------------------------------------------------

I felt that with the above criteria, that cfengine should use /var/lib/cfengine.

It may be beneficial for historical reasons to provide a symlink back to
/var/cfengine, or compensate for it in classes.

Its a simple change.

Also, I'm looking at reworking the make install back into the ebuild, but
making modifications to the makefile to fix the documentation installation
issue.

(I hope the links above work automatically :P )

Demo
Comment 17 Kurt Lieber (RETIRED) gentoo-dev 2003-10-02 09:10:44 UTC
"Users must never need to modify files in /var/lib to configure a package's
operation."

Then cfengine doesn't belong in /var/lib since you have to modify the files
in $WORKDIR/input in order for cfengine to function

I'm not saying that /var/cfengine complies with FHS, but at the same time,
I don't  think /var/lib/cfengine does, either.  As long as we're going to
violate the FHS either way, I'd at least like to put things where most cfengine
users will expect them to be :)

Comment 18 solar (RETIRED) gentoo-dev 2003-10-02 09:50:19 UTC
Kurt, 
When all the changes are (done or ready for the masses) with cfengine please
make note on this bug so we can have/request that aliz send the GLSA out.
Comment 19 Kurt Lieber (RETIRED) gentoo-dev 2003-10-02 10:19:25 UTC
solar -- the stuff we're discussing right now is entirely semantical and
shouldn't prevent us issuing a GLSA.  I've installed the current ~masked
ebuild on two machines and it works fine.  We can go ahead and issue the
GLSA and worry about semantics later.
Comment 20 Russell Adams 2003-10-02 10:33:56 UTC
Technically, /var/cfengine/inputs are cached config files distributed globally,
the admin shouldn't be modifying them directly. Meaning its application specific
data that must be preserved between invocations.

However I agree on both points, lets violate FHS for compatibility, and please
issue the GLSA, there's no reason to hold it up. It works fine as is, the
makefile mods are just to fix docs installation.

I'll see about making a -r1 version with the makefile updates and the /var/cfengine
change.

Demo
Comment 21 Russell Adams 2003-10-02 15:39:10 UTC
Created attachment 18630 [details]
New -r1 ebuild

Updated with makefile fixes, change in symlinking, fixed the key generation,
and now using /var/cfengine.

Lastly, it requires >=openssl-0.9.6k.

Perhaps it'll finally make stable. ;]

Demo
Comment 22 Kurt Lieber (RETIRED) gentoo-dev 2003-10-03 06:00:57 UTC
committed to cvs ~masked.
Comment 23 Kurt Lieber (RETIRED) gentoo-dev 2003-10-04 17:39:52 UTC
marked 2.0.8_p1 as stable pending the release of the GLSA.  This ebuild is
good enough for now, but I think we may want to look at removing the /var/cfengine/bin/cfagent
symlink in a future revision...

will close bug when GLSA goes out tomorrow.
Comment 24 Kurt Lieber (RETIRED) gentoo-dev 2003-10-05 09:47:09 UTC
GLSAs went out.  closing bug.

Russell -- would you like to work on an ebuild for 2.1.0 which should be
released next week?  If so, drop me an email so we can chat about a couple
of questions I had wrt the current one.
Comment 25 Russell Adams 2003-10-05 11:54:04 UTC
Created attachment 18796 [details]
Updated -r1

This removes useless config options, has better comments, and refines the
sed
command that edits the makefile. Plz make this the final.

Anyone interested in documentation on how to setup cfengine under gentoo,
and
integrating portage?

Demo
Comment 26 solar (RETIRED) gentoo-dev 2003-10-07 08:55:27 UTC
Russell,

my $0.02

Yes I'd love to see some gentoo style documentation & examples on cfengine.
If you were to do it I'd like to request that you do it in .xml so Kurt and
or others may post it as an official www.gentoo.org/proj/en/*??*/cfengine.xml