Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 288320 - Fix "eapi" files support in profiles so that they will be inherited from parent
Summary: Fix "eapi" files support in profiles so that they will be inherited from parent
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: PMS/EAPI
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-09 15:06 UTC by Chris Gianelloni
Modified: 2009-10-24 08:47 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Gianelloni 2009-10-09 15:06:02 UTC
This is a simple bug.  There should be *no* files in any default/linux/* profiles.  Release-specific settings should go under releases/10.0 instead.  Simply remove default/linux/*/10.0/eapi and put one in releases/10.0 and you're done.

The design was that no changes should be made under default, as they are supposed to be profiles which only do inheritance.

Thanks
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-10-09 15:09:00 UTC
the 'eapi' files are not inherited.
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-10-09 15:15:12 UTC
(In reply to comment #1)
> the 'eapi' files are not inherited.
> 

Sorry, I should have been more clear. Too much multi-tasking.

I added the eapi files to multiple locations. It is not very clear *where* they should be, exactly. I asked for help and never got anything back. It doesn't make much sense for there to be a 'default/linux/amd64/10.0/eapi' file, you are correct. This does need to be re-evaluated.
Comment 3 solar (RETIRED) gentoo-dev 2009-10-09 16:14:53 UTC
(In reply to comment #2)
> I added the eapi files to multiple locations.

darkside, mind taking this bug then? The fix seems simple enough.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2009-10-21 14:17:00 UTC
@dev-portage: Are these eapi files inherited from parents? I know deprecated files aren't, so doublechecking.
Comment 5 Zac Medico gentoo-dev 2009-10-22 00:23:26 UTC
(In reply to comment #4)
> @dev-portage: Are these eapi files inherited from parents? I know deprecated
> files aren't, so doublechecking.

No, they're not inherited. This reason is that it would be too easy to accidentally bump the eapi on inheriting profiles and have people wondering what just happened.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2009-10-22 08:44:54 UTC
(In reply to comment #0)
> This is a simple bug.  There should be *no* files in any default/linux/*
> profiles.  Release-specific settings should go under releases/10.0 instead. 
> Simply remove default/linux/*/10.0/eapi and put one in releases/10.0 and you're
> done.

As explained by Zac, we have to put both "eapi" and "deprecated" files inside them, and this layout never worked the way you wanted.
Comment 7 Zac Medico gentoo-dev 2009-10-23 03:13:52 UTC
I'm not sure if this matters, but it's worth noting that even though eapi files are not 'inherited' in the usual sense, they still cause the entire profile stack to be rejected by a package manager that doesn't support any one of the eapis within the entire profile stack. So, you still get a somewhat inheritance-like benefit from this file, even though the eapi itself isn't inherited.
Comment 8 Zac Medico gentoo-dev 2009-10-23 08:16:36 UTC
This is really PMS domain.
Comment 9 Zac Medico gentoo-dev 2009-10-23 08:30:36 UTC
If we do change the inheritance behavior, it won't cause any compatibility issues with portage since current versions of portage will actually accept atoms from any eapi regardless of what the 'eapi' files happen to contain. The eapi file is currently only used to reject a profile which contains an unsupported eapi.
Comment 10 Ciaran McCreesh 2009-10-23 13:15:30 UTC
The way it is makes sense. See the original discussion; this was covered then.
Comment 11 Samuli Suominen (RETIRED) gentoo-dev 2009-10-24 08:47:31 UTC
(In reply to comment #10)
> The way it is makes sense. See the original discussion; this was covered then.
> 

I'm convinced in the light of recent discussions.