287132 – [gnome-overlay, FEATURES="test"] gnome-extra/yelp-2.28.0 dies install_qa

Bug 287132 - [gnome-overlay, FEATURES="test"] gnome-extra/yelp-2.28.0 dies install_qa

Summary: [gnome-overlay, FEATURES="test"] gnome-extra/yelp-2.28.0 dies install_qa

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Development (show other bugs)
Hardware:	All Linux

Importance:	Normal QA
Assignee:	Gentoo Linux Gnome Desktop Team

URL:	https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords:

Depends on:
Blocks:	gnome2.28
	Show dependency tree

Reported:	2009-09-30 18:24 UTC by Xake
Modified:	2009-10-24 13:35 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
tests/test-uri.c is missing an include (0001-Forgotten-include-fix-warning.patch,539 bytes, patch) 2009-09-30 18:25 UTC, Xake	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Xake 2009-09-30 18:24:09 UTC

* QA Notice: Package has poor programming practices which may compile
 *            but will almost certainly crash on 64bit architectures.
 * 
 * Function `g_unix_output_stream_new' implicitly converted to pointer at test-uri.c:198
 * 
 *  Please file a bug about this at http://bugs.gentoo.org/
 *  with the maintaining herd of the package.
 * 


Find attached patch for fix.

Comment 1 Xake 2009-09-30 18:25:37 UTC

Created attachment 205697 [details, diff]
tests/test-uri.c is missing an include

Add this to ebuild, the file only gets compiled if FEATURES="test" so this bug will not affect users which do not enable test.

Comment 2 Gil Forcada 2009-10-24 11:48:36 UTC

Just FYI.

It's already fixed upstream.

Comment 3 Xake 2009-10-24 13:35:19 UTC

This is fixed upstream HEAD (and as 2.28 has not been branched afaics I guess this will hit 2.28.1) and the 2.28.0 ebuild in the overlay carries the patch, so closing as fixed.