Bugzilla Bug 28664

Build failure for gedit-2.4.0:
---
if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I. -DORBIT2=1 -pthread
-I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0
-I/usr/include/libgnomecanvas-2.0 -I/usr/include/gtk-2.0
-I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/libbonoboui-2.0
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/orbit-2.0
-I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0
-I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0
-I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/lib/gtk-2.0/include
-I/usr/include/atk-1.0 -I/usr/X11R6/include -I/usr/include/libxml2
-I/usr/include/libglade-2.0 -I/usr/include/eel-2 -I/usr/include/gail-1.0
-I/usr/include/gtksourceview-1.0 -I/usr/include/libgnomeprint-2.2
-I/usr/include/libgnomeprintui-2.2   -DDATADIR=\""/usr/share"\"
-DGNOME_ICONDIR=\""/usr/share/pixmaps"\"
-DGEDIT_LOCALEDIR=\""/usr/share/locale"\"
-DGEDIT_UI_DIR=\""/usr/share/gedit-2/ui/"\"
-DGEDIT_PLUGINDIR=\""/usr/lib/gedit-2/plugins"\"
-DGEDIT_GLADEDIR=\""/usr/share/gedit-2/glade/"\" -DG_DISABLE_DEPRECATED
-DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED
-DGDK_PIXBUF_DISABLE_DEPRECATED -DGNOME_DISABLE_DEPRECATED    -O0 -g -pipe -MT
gedit-mdi-child.o -MD -MP -MF ".deps/gedit-mdi-child.Tpo" \
  -c -o gedit-mdi-child.o `test -f 'gedit-mdi-child.c' || echo
'./'`gedit-mdi-child.c; \
then mv ".deps/gedit-mdi-child.Tpo" ".deps/gedit-mdi-child.Po"; \
else rm -f ".deps/gedit-mdi-child.Tpo"; exit 1; \
fi
gedit2.c: In function `main':
gedit2.c:354: error: `LC_ALL' undeclared (first use in this function)
gedit2.c:354: error: (Each undeclared identifier is reported only once
gedit2.c:354: error: for each function it appears in.)
make[4]: *** [gedit2.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory `/var/tmp/portage/gedit-2.4.0/work/gedit-2.4.0/gedit'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/var/tmp/portage/gedit-2.4.0/work/gedit-2.4.0/gedit'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/var/tmp/portage/gedit-2.4.0/work/gedit-2.4.0/gedit'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/gedit-2.4.0/work/gedit-2.4.0'
make: *** [all] Error 2

!!! ERROR: app-editors/gedit-2.4.0 failed.
!!! Function gnome2_src_compile, Line 39, Exitcode 2
!!! compile failure
---

Emerge info:
---
Portage 2.0.49-r4 (default-x86-1.4, gcc-3.3.1, glibc-2.3.2-r1, 2.6.0-test5)
=================================================================
System uname: 2.6.0-test5 i686 AMD Athlon(tm) processor
distcc 2.10 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.2 [enabled]
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-O0 -g -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /var/qmail/control /usr/kde/2/share/config
/usr/kde/3/share/config /usr/X11R6/lib/X11/xkb /usr/kde/3.1/share/config
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/config"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-O0 -g -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs sandbox ccache strict nostrip cvs"
GENTOO_MIRRORS="http://gentoo.oregonstate.edu
http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="x86 oss apm avi crypt cups encode foomaticdb gif jpeg libg++ mad mikmod mmx
mpeg ncurses nls pdflib png quicktime spell truetype xml2 xmms xv zlib directfb
gdbm berkdb slang readline arts svga java X sdl gpm tcpd pam libwww ssl python
imlib oggvorbis gnome gtk qt kde motif opengl cdr 3dnow aalib alsa
artswrappersuid bonobo dga dvd esd faad gstreamer gtk2 ldap mozilla nas perl pic
samba slp tcltk tetex tiff v4l wmf wxwindows xinerama xml xvid"
---

i can only reproduce this when i use your CFLAGS. try something like
"-march=i686 -O2 -pipe" and set "debug" in USE if you want -g.

I have exactly the same problem with my CFLAGS="-mcpu=athlon-xp -O3 -pipe" 

Failed:
CFLAGS="-O0 -g -pipe"
CFLAGS=""


Works:
CFLAGS="-march=i686 -O2 -pipe"
CFLAGS="-O2 -pipe"

Pending (I think its past where it usually dies):
CFLAGS="-O2 -g -pipe"

More cflags results:

Works:
CFLAGS="-O -g -pipe"
CFLAGS="-O2 -g -pipe"
CFLAGS="-O3 -g -pipe"

This seems to be a problem somewhat related to CFLAGS indeed. I think there are
at least two possible solutions: tweaking compilation flags inside the ebuild
(bringing a bit of awkwardness to it, and voiding part of the purpose of this
variable unnecessarily), or patching the source, so it correctly includes
locale.h (the standard header where LC_ALL is usually in) when needed.

I chose the latter option, since I think it makes more sense, the fix is in
CVS. Maybe a bug report in Gnome's bugzilla is in order?

Thank you very much for bringing this to the attention of Gentoo developers.

I get the same result, but ONLY if I use no CFLAGS at all (""). I get different
errors otherwise, which are found at bug 28708.

CFLAGS="-march=i686 -O2 -pipe" works for me.

Thanks for the work, people :)

Joe/Deathwing00 are either of you using gcc3.3 ?

I don't believe that the patch is the complete solution. Why would that code
only fail on certain CFLAGS, if the header isn't included across all cases ?
More so, if the header isn't included, then shouldn't it fail on all cases ?
The patch doesnt address the differing CFLAGS affecting the build. 

And be careful about posting upstream problems to GNOME, if they are Gentoo
specific (as usually seen with CFLAGS issues) then they won't be well recieved.

*** Bug 28751 has been marked as a duplicate of this bug. ***

Hello. Thank you all for your comments.

There is in fact a problem when a piece of C code uses setlocale() but doesn't include locale.h. This should come natural to any C coder.

Googling for this subject, you can come across lots of examples of this.

http://mail.gnome.org/archives/garnome-list/2002-November/msg00061.html
http://lists.spine.cx/archives/everybuddy/2002-July/001925.html
http://lunar-linux.org/pipermail/lunar.old/2002-March/000033.html

(Moreover, it's rather interesting how this problem shows up in a lot of Gnome-related packages. Maybe developers tend to rely on autoconf magic or another headr file which includes locale.h for them?)

Why is this an issue influenced by CFLAGS, and why it compiles fine under certain circumstances, I don't really know right now. My guess would be that optimization flags somehow make it compile, but the resulting binaries could be problematic. But then again, I'm not sure.


> I don't believe that the patch is the complete solution.

Maybe this bug is giving a hint about some deeper issues here that should be studied by the people who develop these packages. But it seems to me that the patch fixes the real problem reported by Erik (it would be nice to hear from him if he have tho chance to test it).


> And be careful about posting upstream problems to GNOME (..)

I know, I'm familiar with both Gnome's bugzilla and our own. :) Thanks for the notes, Mike, they are very relevant.

@Leonardo:
I just tested it; the patch does fix the compile failure.

@Mike:
Why was bug 28751 marked as a duplciate of this one?
Assuming there is no root problem, it is a seperate occurance of this _type of_ problem.

because, to me, the 2 occurances, where the CFLAGS were common, hints at
something else being the problem. my train of thought then, and still now is
that "if this is a compile-time error (missing header) then why doesnt it fail
for me with 'normal' CFLAGS'".

feel free to re-open 28751 if you feel it was hard done by. i'm still
skeptical, maybe that's just me. who knows.

The patch resolved this bug, and the upstream maintainer has committed the
fix to his tree too. Re-closing.

Thanks again for the report.