Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 286010 - [gnome-overlay] gnome-extra/gnome-power-manager: does not compile with USE=-hal
Summary: [gnome-overlay] gnome-extra/gnome-power-manager: does not compile with USE=-hal
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Low minor
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-22 19:19 UTC by Florian Scandella
Modified: 2009-10-11 00:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Scandella 2009-09-22 19:19:43 UTC 
if hal is disabled the cpufreq backport of gnome-overlay is causing an compile error (missing hal).

the patch should be applied conditionally (if at all, gnome-applets has an cpufreq applet).

Reproducible: Always
Comment 1 Romain Perier (RETIRED) gentoo-dev 2009-09-22 20:54:37 UTC 
Theorically the cleaner way to handle this issue would be use the conditionnal compilation (AC_DEFINE + AM_CONDITIONNAL + macro-constants) including the cpufreq capplet only when hal support is enabled (from sources using autotools).

Then if USE=-hal if given, we could display a warning from pkg_setup() using ewarn.

We avoid to apply patches conditionally from ebuilds for some technical reasons.

- This alternative would fix the issue .
- And would give the opportunity to disable the cpufreq capplet (for example when a user prefers to use cpufreq applet from gnome-panel)
Comment 2 Romain Perier (RETIRED) gentoo-dev 2009-10-10 14:24:29 UTC 
Bump to 2.28.0 and bug fixed,
resync your overlay :)
Comment 3 Florian Scandella 2009-10-11 00:10:26 UTC 
confirmed working, thx