Bug 285600 – dev-util/global gtags elisp install path mismatch

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description IGARASHI Masanao 2009-09-19 17:01:17 UTC]

USE="emacs" dev-util/global-5.6.2 (possibly other versions)

The site-init file /usr/share/emacs/site-lisp/site-gentoo.el sets load-path so:

;;; global site-lisp configuration

(add-to-list 'load-path "/usr/share/emacs/site-lisp/global")

But, gtags.[el|elc] have installed into /usr/share/emacs/site-lisp/gtags.
These paths should be matched.

Reproducible: Always

Steps to Reproduce:
1.USE="emacs" emerge dev-util/global
2.
3.

[Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-08 21:30:08 UTC]

Could you create the patch in unidiff format?

[Comment 2 Jeroen Roovers (RETIRED) 2010-09-01 13:39:00 UTC]

(In reply to comment #1)
> Could you create the patch in unidiff format?

Er, so the fix was very simple and you could readily imagine the patch, yet you insisted on a unified diff? :-\

CC'ing emacs@ (since you maintain elisp-common.eclass) for confirmation. The file in question appears to be
gentoo-x86/dev-util/global/files/50gtags-gentoo.el
and I can't see what's wrong with it.

[Comment 3 Jeroen Roovers (RETIRED) 2010-09-01 14:27:54 UTC]

I think this change might make sense:

Index: global-5.9.2.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/dev-util/global/global-5.9.2.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 global-5.9.2.ebuild
--- global-5.9.2.ebuild 1 Sep 2010 13:40:39 -0000       1.1
+++ global-5.9.2.ebuild 1 Sep 2010 14:27:28 -0000
@@ -59,7 +59,7 @@
        fi
 
        if use emacs; then
-               elisp-install gtags *.{el,elc}
+               elisp-install global *.{el,elc}
                elisp-site-file-install "${FILESDIR}/${SITEFILE}"
        fi
 }

[Comment 4 Ulrich Müller 2010-09-01 14:45:55 UTC]

(In reply to comment #3)
> I think this change might make sense:

Right, either that, or just use ${PN}. And add a "||die" command.

So the canonical solution would be:

    if use emacs; then
        elisp-install ${PN} *.el *.elc || die
        elisp-site-file-install "${FILESDIR}/${SITEFILE}" || die
    fi

[Comment 5 Jeroen Roovers (RETIRED) 2010-09-01 15:04:38 UTC]

Thanks. That's fixed in 5.9.1 and 5.9.2.