Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 285251 - media-sound/pulseaudio doesn't compile with >=x11-proto/xextproto-7.0.99.1
Summary: media-sound/pulseaudio doesn't compile with >=x11-proto/xextproto-7.0.99.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-16 21:03 UTC by Olivier Huber
Modified: 2009-10-05 10:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch (pulseaudio.ebuild.patch,536 bytes, patch)
2009-09-16 21:05 UTC, Olivier Huber
Details | Diff
patch for pulseaudio (pulseaudio-fix-Xtest-move.patch,360 bytes, patch)
2009-09-16 21:07 UTC, Olivier Huber
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Huber 2009-09-16 21:03:58 UTC
modules/x11/module-x11-cork-request.c:32:34: error: X11/extensions/XTest.h : No such file or directory

In xextproto-7.0.99.1, some headers where renamed (XTest.h was split into xtest.h and xtestproto.h : http://cgit.freedesktop.org/xorg/proto/xextproto/commit/?id=8cb2568c4a7df1eb0482009bf9150912e98969e6
and later in 7.0.99.3, xtest.h was renamed to xtestconst.h : http://cgit.freedesktop.org/xorg/proto/xextproto/commit/?id=d7ead7a591da851f6bb2efecdd35b63836df4ed0

It seems also that xextproto should be in DEPEND.
Comment 1 Olivier Huber 2009-09-16 21:05:17 UTC
Created attachment 204369 [details, diff]
patch
Comment 2 Olivier Huber 2009-09-16 21:07:06 UTC
Created attachment 204370 [details, diff]
patch for pulseaudio
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-09-17 08:03:26 UTC
Does your patch not break older XTest versions?
Comment 4 Olivier Huber 2009-09-18 11:16:41 UTC
(In reply to comment #3)
> Does your patch not break older XTest versions?

I'm not sure that I'm understanding your question, but this patch will break the build process w/ <xextproto-7.0.99.3, hence the has_version check.

It is true that if someone tries to emerge pulseaudio with xextproto-7.0.99.{1,2} it won't work, but since these are some kind of rc, I think it's not worth a specific patch.
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-09-18 11:24:16 UTC
I would rather avoid adding version-dependent patches. I'll try to find out if the change is there to stay and fix it upstream and in Gentoo in a single way.
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-10-05 09:43:49 UTC
Okay there is something a bit more to fix, the problem is that the old libXtst's functions are now missing from xextproto… did you try the patch at all? Because it really couldn't have worked properly.

I'll be waiting for the new libXtst to enter the overlay then fix this upstream.
Comment 7 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-10-05 10:31:47 UTC
This only required some mangling of dependencies to make sure that at least one of the two packages installing the XTest.h header is installed; this should be fine now.