Hello! This is popa3d, a security oriented POP3 server. The website is http://www.openwall.com/popa3d/ Supports mbox/maildir, virtual hosts, PAM/shadow authentication and more. The .tgz file contains the following: popa3d-0.6.3.ebuild files/pam files/popa3d-initrc This is my first ebuild, and I'd appreciate any comments. Thanks. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Created attachment 17349 [details] Tar.gz with popa3d ebuild and companions Tar.gz with popa3d ebuild and companions.
Created attachment 17369 [details] popa3d-0.6.3.ebuild
Created attachment 17370 [details] Manifest
Created attachment 17371 [details] files/popa3d-initrc
Created attachment 17372 [details] files/pam
Created attachment 17373 [details] files/digest-popa3d-0.6.3
Hi, I will take a look at your work this evening. Thanks for the hard work.
By the way, there is no need to submit the Manifest and digest files.
Ah okay, makes sense. Why have MD5sums if you accept them from submitters :-). I skipped them in the tgz, but included them when I posted the files individually, I wasn't really sure, but now I know. Thanks. I also set up a how-to/tester thread on the forum http://forums.gentoo.org/viewtopic.php?t=82386
Created attachment 17459 [details] Modified popa3d-0.6.3.ebuild OK, I've taken a look at your ebuild and butchered it ;) It uses the mbox and maildir USE flags much more closely now, and I removed your POPA3D_HOME_MAILBOX="Maildir" comment, as all other ebuilds in portage default .maildir. Anyway, you can take a look at see the rest for yourself. I've got a few more things to check and change in there, but I've run out of time for tonight. Regards.
Created attachment 17468 [details] Modified popa3d-0.6.3.ebuild You seem to have butchered off your own foot along with it. Few comments on your changes: *) Checking for mbox && maildir is good. I like that. *) It should be possible to overwrite POPA3D_HOME_MAILBOX for people who want the traditional ~/Mailbox or ~/Maildir (which, yes, are not gentoo traditional though, see my discussion on bug #28260). *) When the 'mbox' USE flag is set, you set POPA3D_HOME_MAILBOX to "Mailbox", which is incorrect. In gentoo 'mbox' denotes /var/mail/user. To get that you'll have to leave POPA3D_HOME_MAILBOX empty, which in turn, makes popa3d use the default /var/mail/user, and not a home (~/) mailbox, as the name suggests. *) In src_unpack you only set the home mailbox path in popa3d if the 'maildir' USE flag is set. This breaks the use of POPA3D_HOME_MAILBOX when 'mbox' is being used (so it breaks your previous ~/Mailbox assignment). Also, the info line in the else is wrong compared to the previous ~/Mailbox entry you added. *) You mix up the einfo's for mailbox path determination and mailbox format. I've attached a modified version of the ebuild. I included a header explaining the configuration. Please let me know what you think of it, and what other changes you had in mind.
Created attachment 17475 [details] Modified popa3d-0.6.3.ebuild Added dodoc for all the relevant files.
Created attachment 17489 [details] Modified popa3d-0.6.3.ebuild take 2 I've got one foot left, so heres another modification. *)I moved the mbox and maildir check back into pkg_config as we want to die early when they are both set. *)POPA3D_HOME_MAILBOX can now be set from outside. If using mbox its set back to "" *) maildir takes precedence over mbox so if neither are set, maildir is the default. *) added depscan.sh run in pkg_postinst as we are installing an init script. As for having epatch run inside src_compile, I'm going let that slide as the output looks messy with the einfo's inside unpacking.
Created attachment 17505 [details] popa3d-0.6.3.ebuild RC-1 Okay, we're on the same track now. Only one minor change, if using mbox, we shouldn't set POPA3D_HOME_MAILBOX="" since that'd block people from overwriting it. The default is of course "".
In cvs, thanks.
