Bug 282744 – media-libs/jpeg-7 cause blured images in gtk+

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Milos Popovic 2009-08-25 21:06:11 UTC]

Instaling new jpeg libraries cause blured images in all gtk programs (geeqie, f-spot, eog,...). See bug on gnome bugzilla: http://bugzilla.gnome.org/show_bug.cgi?id=588740

I am using x11-libs/gtk+-2.17.8, but it looks like problem exist with all versions.

Reproducible: Always

Steps to Reproduce:

[Comment 1 Paul Bredbury 2009-08-26 04:21:48 UTC]

Created attachment 202296 [details, diff]
putte_xvi's patch for gtk+-2-2.16.5 with jpeg-7

putte_xvi's patch seems to work well.

[Comment 2 Romain Perier (RETIRED) 2009-08-26 13:45:00 UTC]

Paul: no upstream confirmations no chocolate :D

I asked Matthias to confirm officially this patch, and then we'll be able to import it into gentoo ;)

[Comment 3 Boris Fersing (RETIRED) 2009-08-27 23:01:15 UTC]

*** Bug 282988 has been marked as a duplicate of this bug. ***

[Comment 4 Gef 2009-08-30 12:18:35 UTC]

(In reply to comment #2)
> I asked Matthias to confirm officially this patch, and then we'll be able to
> import it into gentoo ;)
> 
Romain,

Matthias answered you ; he treats this patch more as a workaround rather than a fix. (Anyway, i will patch gtk in my system... gqview is unusable right now).

[Comment 5 Romain Perier (RETIRED) 2009-08-30 13:59:37 UTC]

(In reply to comment #4)
> (In reply to comment #2)
> > I asked Matthias to confirm officially this patch, and then we'll be able to
> > import it into gentoo ;)
> > 
> Romain,
> 
> Matthias answered you ; he treats this patch more as a workaround rather than a
> fix. (Anyway, i will patch gtk in my system... gqview is unusable right now).
> 

hehe I responsed to him, the problem is this patch works only with libjpeg7 (libjpeg6 and libjpeg7 scale specs are different, see upstream) , actually it's not canditate to be applied, until there is a correct fix, approved on upstream.

[Comment 6 Milos Popovic 2009-08-30 18:26:52 UTC]

Great, we could make temporary fix this in ebuild itself. What do you say???

if jpeg7 then patch...
else ...

[Comment 7 Romain Perier (RETIRED) 2009-08-30 18:38:13 UTC]

(In reply to comment #6)
> Great, we could make temporary fix this in ebuild itself. What do you say???
> 
> if jpeg7 then patch...
> else ...
> 

yeah except we never apply patch conditionnally (at least in gnome team, for some technicals reasons)

And until the patch won't be accept on upstream we won't apply it, even for temp fix 

[Comment 8 Valentin But 2009-08-31 21:19:44 UTC]

Just masked it in /etc/portage/package.mask:
=media-libs/jpeg-7

Also:
=media-libs/netpbm-10.46.00-r1
because it depends on media-libs/jpeg-7, media-libs/netpbm-10.46.00 is not.

[Comment 9 Romain Perier (RETIRED) 2009-09-01 14:27:45 UTC]

I posted on upstream a correct patch, which includes 	
conditionally the good snippet of code. I just used JPEG_LIB_VERSION macro-constant value, in order to keep backwards compatibility with jpeg-6.

see upstream for more details (especially why the check is static and not dynamic)

[Comment 10 Romain Perier (RETIRED) 2009-09-06 14:43:39 UTC]

+*gtk+-2.16.5-r1 (06 Sep 2009)
+
+  06 Sep 2009; Romain Perier <[e-mail]>
+  +gtk+-2.16.5-r1.ebuild,
+  +files/gtk+-2.16.5-jpeg-backward-compatibility.patch:
+  Fix jpeg7 blured images in gdk-pixbuf due to jpeg7 scale specs changes,
+  per bug #282744.

Fixed into the main tree with a revbump , patch is applied for gtk+-2.16.5 which will be stabilized in few days.

Thanks for reporting

[Comment 11 Rafał Mużyło 2009-10-21 00:52:03 UTC]

Consider reopening and changing fix:
today an email regarding this problem has arrived on gtk-devel-list.
It suggest a fix by jpeg upstream -
it's too early to tell if it gets accepted.
See: http://mail.gnome.org/archives/gtk-devel-list/2009-October/msg00110.html