Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 281442 - [PATCH] gnome-base/gdm: wrong DESKTOP_SESSION set under corner case circumstances
Summary: [PATCH] gnome-base/gdm: wrong DESKTOP_SESSION set under corner case circumsta...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2009-08-14 09:18 UTC by Fabio Erculiani (RETIRED)
Modified: 2009-08-24 22:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
fix DESKTOP_SESSION env variable setup (gdm-2.20.10-fix-DESKTOP_SESSION-when-dmrc-is-empty-and-autologin.patch,809 bytes, patch)
2009-08-14 09:19 UTC, Fabio Erculiani (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Erculiani (RETIRED) gentoo-dev 2009-08-14 09:18:51 UTC
When ${HOME}/.dmrc is not found or does not contain any relevant data AND autologin is enabled, gdm fails to set DESKTOP_SESSION, not stripping ".desktop" extension to session char* variable. This is a bug in daemon/slave.c code and causes the GNOME Applications menu to not be shown when in use with new gnome-base/gnome-menus-2.26.x session ebuilds because DESKTOP_SESSION="gnome.desktop" instead of DESKTOP_SESSION="gnome"

Please find a working patch attached (tested on gdm-2.20.10)

Reproducible: Always

Steps to Reproduce:
Comment 1 Fabio Erculiani (RETIRED) gentoo-dev 2009-08-14 09:19:26 UTC
Created attachment 201213 [details, diff]
fix DESKTOP_SESSION env variable setup
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-08-14 11:44:19 UTC
ah the vicious bug, thanks for finding this out. Could you also test/check that gdm-2.26 code is safe wrt this issue ?
Comment 3 Fabio Erculiani (RETIRED) gentoo-dev 2009-08-14 16:20:18 UTC
You're welcome :)
Looking at gdm 2.26.1 source code, code has been completely rewritten and it doesn't seem to have issues here (just tested)
Comment 4 Romain Perier (RETIRED) gentoo-dev 2009-08-24 22:57:24 UTC
+*gdm-2.20.10-r2 (24 Aug 2009)
+
+  24 Aug 2009; Romain Perier <mrpouet@gentoo.org>
+  -gdm-2.20.10-r1.ebuild, +gdm-2.20.10-r2.ebuild,
+  +files/gdm-2.20.10-desktop-session-dmrc-autologin.patch:
+  Fix bug #281442, wrong DESKTOP_SESSION set if ${HOME}/.dmrc is empty and
+  autologin enabled. Thanks to Fabio Erculiani <lxnay@sabayonlinux.org> for
+  this work. Clean up old revision.

Fixed into the main tree with a revision bump. Thanks for you work and for reporting ;)