Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 280129 - =media-video/mplayer-1.0_rc2_p20090731 upstream ./configure LINGUAS loop always returns true
Summary: =media-video/mplayer-1.0_rc2_p20090731 upstream ./configure LINGUAS loop alwa...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-03 05:03 UTC by Samuli Suominen (RETIRED)
Modified: 2009-08-03 07:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
IRC log (mplayerdev.txt,1.27 KB, text/plain)
2009-08-03 05:06 UTC, Samuli Suominen (RETIRED)
Details
patch, based on the IRC log.. let's hope it's right (mplayer-1.0_rc2_p20090731-linguas.patch,699 bytes, patch)
2009-08-03 07:10 UTC, Samuli Suominen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2009-08-03 05:03:29 UTC
This code is broken because language_msg variable is reused instead of using a temp. variable so the check will always return true:

for lang in $language_msg ; do
  test -f "help/help_mp-${lang}.h" && language_msg=$lang && break
done
test -z "$language_msg" && language_msg=en
_mp_help="help/help_mp-${language_msg}.h"
echores "messages: $language_msg - man pages: $language_man - documentation: $language_doc"

This is why we are forcing --language=all now in the ebuild.

To reproduce the problem set your LINGUAS to e.g. "sl" which isn't supported by MPlayer.

I've reported it to #mplayerdev and they even came up with a solution but didn't commit it (yet?) in SVN :-(

Once we get the fix in tree the method for handling LINGUAS in older ebuilds is fine.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2009-08-03 05:06:28 UTC
Created attachment 199974 [details]
IRC log

..
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2009-08-03 07:10:52 UTC
Created attachment 199985 [details, diff]
patch, based on the IRC log.. let's hope it's right

applied in the 20070731 snapshot in portage