Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 279477 - net-misc/chrony: the argument tests should happen in init.d's start()
Summary: net-misc/chrony: the argument tests should happen in init.d's start()
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-28 14:31 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-11-16 14:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2009-07-28 14:31:39 UTC 
Right now conf.d/chrony tries executing some greps (without even checking if the file exists) to set arguments to enable. This should be done in the start(0 function of the init script not in the configuration file. The code in configuration file is global scope, and like it is for ebuilds, init scripts' global scope slows down dependency cache generation.

Thanks,
Diego
Comment 1 Dawid Węgliński (RETIRED) gentoo-dev 2009-11-16 14:29:05 UTC 
  16 Nov 2009; Dawid Węgliński <cla@gentoo.org> files/chronyd.conf,
  files/chronyd.rc:
  Don't run grep in global scope (bug #279477)