Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 279461 - [patch] smbkrb5passwd for openldap-2.4.17 unable to install
Summary: [patch] smbkrb5passwd for openldap-2.4.17 unable to install
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo LDAP project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-28 10:29 UTC by zym
Modified: 2009-07-28 21:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch update supplied by submitter (openldap-smbk4pwd.patch,800 bytes, patch)
2009-07-28 20:12 UTC, James Earl Spahlinger
Details | Diff
ebuild modification submitted by reporter (openldap-2.4.17.ebuild.patch,537 bytes, patch)
2009-07-28 20:26 UTC, James Earl Spahlinger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zym 2009-07-28 10:29:39 UTC
hi, the patch for 2.4.17 is not modified compare to the ebuild, so there is unabled to install:

 * Install the smbk5pwd module
make -j10 DESTDIR=/var/tmp/portage/net-nds/openldap-2.4.17/image/ libexecdir=/usr/lib64/openldap install-mod 
make: *** No rule to make target `install-mod'.  Stop.
 * 
 * ERROR: net-nds/openldap-2.4.17 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_install
 *             environment, line 3330:  Called die
 * The specific snippet of code:
 *               emake DESTDIR="${D}" libexecdir="/usr/$(get_libdir)/openldap" install-mod || die "emake install smbk5pwd failed";
 *  The die message:
 *   emake install smbk5pwd failed
 * 
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/tmp/portage/net-nds/openldap-2.4.17/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/net-nds/openldap-2.4.17/temp/environment'.


please apply the the patch on ebuild:

@@ -402,10 +429,17 @@
 		if use smbkrb5passwd ; then
 			einfo "Install the smbk5pwd module"
 			cd "${S}/contrib/slapd-modules/smbk5pwd"
-			emake DESTDIR="${D}" libexecdir="/usr/$(get_libdir)/openldap" install-mod || die "emake install smbk5pwd failed"
+			emake DESTDIR="${D}" libexecdir="/usr/$(get_libdir)/openldap" install || die "emake install smbk5pwd failed"
 			newdoc README smbk5pwd-README
 		fi

and the pactch file:

--- /usr/portage/net-nds/openldap/files/openldap-2.4.17-contrib-smbk5pwd.patch	2009-07-28 10:11:25.000000000 +0800
+++ files/openldap-2.4.17-contrib-smbk5pwd.patch	2009-07-28 14:50:24.000000000 +0800
@@ -6,7 +6,7 @@
  # <http://www.OpenLDAP.org/license.html>.
  
 +#libexecdir=/usr/lib/openldap
-+moduledir=$(libexecdir)/openldap
++moduledir=$(libexecdir)
  LIBTOOL=../../../libtool
 -OPT=-g -O2
 +#OPT=
@@ -57,5 +57,5 @@
 -	$(LIBTOOL) --mode=install cp smbk5pwd.la $(PREFIX)/lib/openldap
 -	$(LIBTOOL) --finish $(PREFIX)/lib
 +	mkdir -p $(moduledir)
-+	$(LIBTOOL) --mode=install cp smbk5pwd.la $(moduledir)
-+	$(LIBTOOL) --finish $(libexecdir)
++	$(LIBTOOL) --mode=install cp smbk5pwd.la $(DESTDIR)$(moduledir)
++	$(LIBTOOL) --finish $(DESTDIR)$(libexecdir)


FYI

thanks
Comment 1 James Earl Spahlinger 2009-07-28 20:06:52 UTC
Thanks for the patches, would be nice if they could be uploaded. I'll give it a shot by copy pasting into emacs and uploading that way. :)
Comment 2 James Earl Spahlinger 2009-07-28 20:12:53 UTC
Created attachment 199473 [details, diff]
patch update supplied by submitter
Comment 3 James Earl Spahlinger 2009-07-28 20:26:51 UTC
Created attachment 199475 [details, diff]
ebuild modification submitted by reporter

I've uploaded both of your patches in unified diff format. Please in the future upload them rather then paste the patches in the comment field as it helps the developers out. The developers can view what changes your patch does just by clicking the diff button on bugzilla as well as download your patch for use easier. Again thanks for the patches :)
Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-07-28 21:28:41 UTC
Fixed in 2.4.17-r1.