Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 279423 - net-analyzer/net-snmp-5.4.2.1 revamp + add =sys-apps/lm_sensors-3* support
Summary: net-analyzer/net-snmp-5.4.2.1 revamp + add =sys-apps/lm_sensors-3* support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 273827 301474
  Show dependency tree
 
Reported: 2009-07-28 04:40 UTC by Gordon Malm (RETIRED)
Modified: 2010-01-19 10:22 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
net-snmp-5.4.2.1-r2.ebuild (net-snmp-5.4.2.1-r2.ebuild,5.29 KB, text/plain)
2009-07-28 04:42 UTC, Gordon Malm (RETIRED)
Details
net-snmp-5.4.1-sensors3.patch (net-snmp-5.4.1-sensors3.patch,47.27 KB, patch)
2009-07-28 04:45 UTC, Gordon Malm (RETIRED)
Details | Diff
net-snmp-5.4.1-sensors3-version_detect.patch (net-snmp-5.4.1-sensors3-version_detect.patch,1.36 KB, patch)
2009-07-28 04:48 UTC, Gordon Malm (RETIRED)
Details | Diff
snmpd.init (snmpd.init,954 bytes, text/plain)
2009-07-28 04:49 UTC, Gordon Malm (RETIRED)
Details
snmptrapd.init (snmptrapd.init,520 bytes, text/plain)
2009-07-28 04:50 UTC, Gordon Malm (RETIRED)
Details
Unified diff of changes vs. current net-snmp-5.4.2.1-r1 (net-snmp-5.4.2.1-r2-diff.txt,8.97 KB, text/plain)
2009-07-28 04:55 UTC, Gordon Malm (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gordon Malm (RETIRED) gentoo-dev 2009-07-28 04:40:51 UTC
Hi Netmon Herd,

I've written an =net-analyzer/net-snmp-5.4.2.1-r2 with a bunch of needed updates, including adding support for building against =sys-apps/lm_sensors-3*.  A lot of newer sensor chips only have support via lm_sensors-3 and it has been hardmasked (due to API changes creating build issues) for way too long.  sys-apps/net-snmp is one of the last remaining ebuilds to not build against it.

Quick summary:
-Switch to EAPI=2
-General QA/small stuff (readability adjustments, die, etc.)
-Wrap lm_sensors depend in kernel_linux (semi-dupe #234036)
-Allow USE flags bzip2/zlib independent of USE rpm (semi-dupe #234036)
-Use net-snmp's own build/install for perl/python modules (semi-dupe #234036)
-Add support for building with =sys-apps/lm_sensors-3*, while remaining =sys-apps/lm_sensors-2* compat.
-snmpd init script: Add reload capability (semi-dupe #273827).
-snmpd/snmptrapd init scripts: Use ${SVCNAME}, allow pid file location override capability (looks nicer, keeps style consistency between the two init scripts ;).

Files incoming....
Comment 1 Gordon Malm (RETIRED) gentoo-dev 2009-07-28 04:42:10 UTC
Created attachment 199404 [details]
net-snmp-5.4.2.1-r2.ebuild

net-snmp-5.4.2.1-r2.ebuild
Comment 2 Gordon Malm (RETIRED) gentoo-dev 2009-07-28 04:45:34 UTC
Created attachment 199406 [details, diff]
net-snmp-5.4.1-sensors3.patch

net-snmp-5.4.1-sensors3.patch

Source: http://cvs.fedoraproject.org/viewvc/devel/net-snmp/net-snmp-5.4.1-sensors3.patch

Adds support for lm_sensors-3.  Latest from upstream and unmodified except for a "Source:" comment added at the top.
Comment 3 Gordon Malm (RETIRED) gentoo-dev 2009-07-28 04:48:23 UTC
Created attachment 199408 [details, diff]
net-snmp-5.4.1-sensors3-version_detect.patch

net-snmp-5.4.1-sensors3-version_detect.patch

Add automatic lm_sensors version detection to the build process and build accordingly (libsensorsMib tries to use the lmsensors_v3 module *all* the time).
Comment 4 Gordon Malm (RETIRED) gentoo-dev 2009-07-28 04:49:40 UTC
Created attachment 199410 [details]
snmpd.init
Comment 5 Gordon Malm (RETIRED) gentoo-dev 2009-07-28 04:50:04 UTC
Created attachment 199411 [details]
snmptrapd.init
Comment 6 Gordon Malm (RETIRED) gentoo-dev 2009-07-28 04:55:43 UTC
Created attachment 199413 [details]
Unified diff of changes vs. current net-snmp-5.4.2.1-r1

Unified diff of changes vs. current net-snmp-5.4.2.1-r1 (cause sometimes its easier to review a diff ;)
Comment 7 Gordon Malm (RETIRED) gentoo-dev 2009-08-06 02:22:21 UTC
bump
Comment 8 Gordon Malm (RETIRED) gentoo-dev 2009-08-15 00:05:14 UTC
Haven't heard anything from netmon, so unless someone objects (and fast) I'm going to revbump net-analyzer/net-snmp using this real soon.
Comment 9 Peter Volkov (RETIRED) gentoo-dev 2009-08-17 17:18:13 UTC
Gordon there is one problem... There is already some work done that's currently not in the tree... Well let me 5 days to check what to do best and if I answer nothing here bump your package on 22.08 :) Thank you for your work.
Comment 10 Billy DeVincentis 2009-08-31 19:22:24 UTC
This is about the only blocker for most people using lm_sensors, isn't it about time to commit this to tree?
Comment 11 Gordon Malm (RETIRED) gentoo-dev 2009-08-31 20:16:35 UTC
(In reply to comment #9)
> Gordon there is one problem... There is already some work done that's currently
> not in the tree... Well let me 5 days to check what to do best and if I answer
> nothing here bump your package on 22.08 :) Thank you for your work.
> 

I didn't see anything in net-snmp cvs/svn/whatever upstream for lm_sensors building auto-detect logic.  Perhaps there is now (or I missed it)?  I believe most distros are just statically building/choosing lm_sensors-3.x or lm_sensors-2.x (via old the old MIB) support as they have that luxury.
Comment 12 Billy DeVincentis 2009-09-17 03:00:46 UTC
5 days is long gone. I really want to upgrade lm-sensors. Please, lets move on this. If you feel more comfortable, add it to the tree masked for testing purposes.
Comment 13 Gordon Malm (RETIRED) gentoo-dev 2009-10-16 08:59:08 UTC
Committed and removed lm_sensors-3 from package.mask.  Closing as FIXED.