Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 279064 - [PATCH] media-plugins/audacious-plugins-2.1: Use media-libs/libmpcdecsv7 (transition package)
Summary: [PATCH] media-plugins/audacious-plugins-2.1: Use media-libs/libmpcdecsv7 (tra...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Tony Vroon (RETIRED)
URL: http://tinderbox.dev.gentoo.org/misc/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-25 15:50 UTC by Samuli Suominen (RETIRED)
Modified: 2009-10-04 00:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for Audacious Plugins 2.1 (audacious-plugins-2.1-libmpcdecsv7.patch,1.51 KB, patch)
2009-07-26 15:55 UTC, Samuli Suominen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2009-07-25 15:50:15 UTC
Info:

1. media-libs/libmpcdec is Musepack SV7.
2. >=media-sound/musepack-tools-444 is Musepack SV8.

These applications depend on old libmpcdec:

app-cdr/k3b-1.0.5-r5:musepack
gnustep-apps/cynthiune-0.9.5-r3:musepack
media-libs/xine-lib-1.1.16.3:musepack
media-plugins/audacious-plugins-2.1:musepack
media-plugins/gst-plugins-musepack-0.10.11
media-sound/aqualung-0.9_beta10-r1:musepack
media-sound/cmus-2.2.0-r1:musepack
media-sound/moc-2.5.0_alpha3-r2:musepack
media-sound/mpd-0.15.1:musepack
media-sound/qmmp-0.3.0:musepack
media-video/mplayer-1.0_rc2_p20090530:musepack
media-video/mplayer-9999:musepack
media-video/vlc-1.0.0:musepack
media-video/vlc-1.0.9999:musepack
media-video/vlc-9999:musepack

(I've only listed latest)

If your application can use SV8, you need to adjust the depend to:

|| ( >=media-sound/musepack-tools-444 media-libs/libmpcdec )

Thank you.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2009-07-25 16:10:23 UTC
Include directory is now /usr/include/mpc as opposed to /usr/include/mpcdec. This is the way it's in Debian and in upstream SVN and tarball.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2009-07-25 17:12:26 UTC
Musepack SV7 example files: http://samples.mplayerhq.hu/A-codecs/musepack/
Musepack SV8 example files: http://samples.mplayerhq.hu/A-codecs/musepack/sv8/
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2009-07-25 17:18:27 UTC
(In reply to comment #1)
> Include directory is now /usr/include/mpc as opposed to /usr/include/mpcdec.
> This is the way it's in Debian and in upstream SVN and tarball.
> 

I've symlinked it to the old location, but please consider using the new path.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2009-07-25 21:17:52 UTC
beandog, mplayer has internal musepack sv7 and sv8 support from ffmpeg, please remove USE musepack from latest and -9999.

chainsaw, nenolod said that since 2.2 audacious will use ffaudio instead of libmpcdec for musepack support, basically same situation with mplayer
Comment 5 Tony Vroon (RETIRED) gentoo-dev 2009-07-25 22:29:50 UTC
(In reply to comment #4)
> chainsaw, nenolod said that since 2.2 audacious will use ffaudio instead of
> libmpcdec for musepack support, basically same situation with mplayer

That is correct. Current Audacious versions however are strictly SV7-only. 

Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2009-07-25 22:51:01 UTC
Fixed gst-plugins-musepack deps; they support SV8 as discussed briefly with Tester. Removing gstreamer@ from CC.
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2009-07-26 10:49:24 UTC
Fixed mplayer, it has internal codecs:

ffmusepack7 ffmpeg    working   Musepack sv7 audio codec  [mpc7]
ffmusepack8 ffmpeg    working   Musepack sv8 audio codec  [mpc8]
musepack    mpcdec    working   Musepack audio codec

(Also played both SV7 and SV8 examples, works great.)
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2009-07-26 13:24:36 UTC
media-libs/xine-lib-1.1.16.3:musepack (fixed to use libmpcdecsv7)
media-plugins/gst-plugins-musepack-0.10.11 (fixed to use sv8)
media-sound/aqualung-0.9_beta10-r1:musepack (fixed to use libmpcdecsv7)
media-sound/cmus-2.2.0-r1:musepack (fixed to use libmpcdecsv7)
media-sound/moc-2.5.0_alpha3-r2:musepack (fixed to use libmpcdecsv7)
media-sound/mpd-0.15.1:musepack (fixed to use sv8)
media-sound/qmmp-0.3.0:musepack (fixed to use sv8)

only k3b, cynthiune, audacious, and vlc remain broken
Comment 9 Samuli Suominen (RETIRED) gentoo-dev 2009-07-26 15:36:06 UTC
app-cdr/k3b-1.0.5-r5:musepack (fixed to use libmpcdecsv7)
gnustep-apps/cynthiune-0.9.5-r3:musepack (fixed to use libmpcdecsv7)
media-video/vlc-1.0.0:musepack (fixed to use sv8)
media-video/vlc-1.0.9999:musepack (fixed to use sv8)
media-video/vlc-9999:musepack (fixed to use sv8)

only audacious left, it needs to be converted to libmpcdecsv7, it's a simple headers / lib rename.
Comment 10 Samuli Suominen (RETIRED) gentoo-dev 2009-07-26 15:55:55 UTC
Created attachment 199229 [details, diff]
Patch for Audacious Plugins 2.1

And change depend to: media-libs/libmpcdecsv7
Comment 11 Tony Vroon (RETIRED) gentoo-dev 2009-07-26 20:56:05 UTC
(In reply to comment #10)
> Created an attachment (id=199229) [edit]
> Patch for Audacious Plugins 2.1
> And change depend to: media-libs/libmpcdecsv7

+*audacious-plugins-2.1-r1 (26 Jul 2009)
+
+  26 Jul 2009; <chainsaw@gentoo.org> +files/2.1-libmpcdecsv7.patch,
+  audacious-plugins-2.1.ebuild, -files/2.1_alpha1-timidity-conf-path.patch,
+  +audacious-plugins-2.1-r1.ebuild:
+  Patch by Samuli Suominen <ssuominen@gentoo.org> changes Musepack
+  dependency to a SV7-only transition library. Mark 2.1 version stable on
+  AMD64.

 

Comment 12 Samuli Suominen (RETIRED) gentoo-dev 2009-07-26 21:08:49 UTC
Thanks Tony. There's nothing left to do here. :-) Audacious will use ffaudio when it's ready, I hope xine-lib will too (Mailed Diego about it).
Comment 13 Samuli Suominen (RETIRED) gentoo-dev 2009-07-26 21:18:28 UTC
src_unpack() {
        unpack ${A}
        cd "${S}"
        epatch "${FILESDIR}/${PV}-libmpcdecsv7.patch"
}

hmm, I've patched configure.in (and not configure) so this will not make the change in effect... sorry should have been more specific i suppose
Comment 14 Samuli Suominen (RETIRED) gentoo-dev 2009-07-26 21:27:23 UTC
inherit autotools

AT_M4DIR="${S}/m4" eautoreconf

or move to patching configure directly i guess
Comment 15 Tony Vroon (RETIRED) gentoo-dev 2009-07-26 23:04:43 UTC
+  26 Jul 2009; <chainsaw@gentoo.org> audacious-plugins-2.1-r1.ebuild:
+  Running eautoreconf is advisable if one patches the configure system. Do
+  so, closing off bug #279064 once and for all.
Comment 16 Chris Larson 2009-10-03 23:41:07 UTC
Apologies if this isn't the right place. It seems to be functioning as a sort of tracker bug so:

media-tv/xbmc-9999.ebuild needs updating for libmpcdecsv7 as well.

(In reply to comment #15)
> +  26 Jul 2009; <chainsaw@gentoo.org> audacious-plugins-2.1-r1.ebuild:
> +  Running eautoreconf is advisable if one patches the configure system. Do
> +  so, closing off bug #279064 once and for all.
> 

Comment 17 Tony Vroon (RETIRED) gentoo-dev 2009-10-04 00:29:19 UTC
Do *not* hijack bug reports. You need to file your own.
Comment 18 Chris Larson 2009-10-04 00:35:06 UTC
Once again, I apologize. As I said, it looked like the right place, so I posted with with the caveat that I might be doing the wrong thing.

(In reply to comment #17)
> Do *not* hijack bug reports. You need to file your own.
>