with 1.7.1.1, # is treated as a comment in TEXT. this is a problem because in my output I need to use # for color values. unfortunately, although conky's ChangeLog specifies you can escape the # sign (\#) to actually use it, this doesn't work. I've written a patch that allows # usage in TEXT if its prefixed with an \. It seems to work fine here: # => Comment until end of line \# => \ is stripped and # is printed on screen. I've submitted the patch to Upstream's bug tracker (URL). ebuild and patch are available in my overlay, wirelay: http://github.com/wired/wirelay/tree/master/app-admin/conky I'll attach the patch here as well.
Created attachment 198496 [details, diff] patch that fixes # behavior
This has actually been fixed in git for a while. Thanks for the patch though. See: http://git.omp.am/?p=conky.git;a=commit;h=aaca08fc972fb37f15e0b4e21de2b67c094021ed http://git.omp.am/?p=conky.git;a=commit;h=e2caa5892301f5e04bb7326106c20d187260fa6e
Oh wait, looks like I didn't read the first comment. I'll go cower in shame now.
Created attachment 198497 [details, diff] new patch from upstream that fixes # problems meh :) OK, I recreated the patch from those two commits :)
(In reply to comment #2) > This has actually been fixed in git for a while. Thanks for the patch though. > See: > > http://git.omp.am/?p=conky.git;a=commit;h=aaca08fc972fb37f15e0b4e21de2b67c094021ed > http://git.omp.am/?p=conky.git;a=commit;h=e2caa5892301f5e04bb7326106c20d187260fa6e > I've been testing the new patch and it seems that the stuff from the second commit above is not working well. If you have a line with a comment anywhere, it removes the newline from the end of the commented line (together with the comment), effectively concatenating whats left of the line containing the comment with the next one. The first commit works OK and fixes my \# issue.
(In reply to comment #5) > > I've been testing the new patch and it seems that the stuff from the second > commit above is not working well. > > If you have a line with a comment anywhere, it removes the newline from the end > of the commented line (together with the comment), effectively concatenating > whats left of the line containing the comment with the next one. > > The first commit works OK and fixes my \# issue. > I'm guessing the second patch relies on some previous patch. I'm too lazy to dig through the code and see what's missing.
(In reply to comment #6) > I'm guessing the second patch relies on some previous patch. I'm too lazy to > dig through the code and see what's missing. Alright. I'll just add the first patch then to allow \#s to work for now :)
I've added the patch to CVS. Thanks.
