Bug 277011 – sys-apps/portage-2.2.00.13797 tries to use system rsync, lacks EPREFIX prefix

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Stuart Shelton 2009-07-08 10:13:57 UTC]

The system rsync on IRIX is not actually Tridgell/Mackerras rsync, but instead an RCS versioning utility.

The latest portage's portage/pym/_emerge/actions.py contains:

rsynccommand = ["/usr/bin/rsync"] + rsync_opts + extra_rsync_opts

... on line 2010, whereas elsewhere the command is (hopefully always) 'EPREFIX + "/usr/bin/rsync' elsewhere.  This prevents further syncs.

This appears to be the only instance in this file.

(Quite how any prefix users with a non-rsync system rsync are to get any update to address this problem is an exercise left to the reader ;)

[Comment 1 Jeremy Olexa (darkside) (RETIRED) 2009-07-08 15:20:48 UTC]

Ah, that is a new file in .13797. Good thing it is masked for now previous to this bug report. ;)

[Comment 2 Jeremy Olexa (darkside) (RETIRED) 2009-07-14 19:29:37 UTC]

Still present in 2.2.00.13825, also masked for unrelated issues.

[Comment 3 Fabian Groffen 2009-07-14 19:58:19 UTC]

ah, thanks!
Index: pym/_emerge/actions.py
===================================================================
--- pym/_emerge/actions.py      (revision 13825)
+++ pym/_emerge/actions.py      (working copy)
@@ -1983,7 +1983,7 @@
                        if mytimestamp != 0 and "--quiet" not in myopts:
                                print ">>> Checking server timestamp ..."
 
-                       rsynccommand = ["/usr/bin/rsync"] + rsync_opts + extra_rsync_opts
+                       rsynccommand = [EPREFIX + "/usr/bin/rsync"] + rsync_opts + extra_rsync_opts
 
                        if "--debug" in myopts:
                                print rsynccommand

revision 13827

[Comment 4 Fabian Groffen 2009-07-14 20:13:48 UTC]

fixed in portage-2.2.00.13827