Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 276715 - sys-apps/openrc-0.4.3-r3 compilation failure with sys-kernel/linux-headers-2.6.30
Summary: sys-apps/openrc-0.4.3-r3 compilation failure with sys-kernel/linux-headers-2....
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
: 276824 276976 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-07-06 09:45 UTC by sargastic
Modified: 2009-07-11 15:14 UTC (History)
17 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
openrc-0.4.3-command-line-size-fix.diff (openrc-0.4.3-command-line-size-fix.diff,2.58 KB, patch)
2009-07-08 08:09 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sargastic 2009-07-06 09:45:51 UTC
During an 'emerge -vuD system', upgrade openrc-0.4.3.r2 to r3 :

runscript.c: In function ‘runscript’:
runscript.c:1204: warning: ignoring return value of ‘chdir’, declared with attribute warn_unused_result
i686-pc-linux-gnu-gcc -O2 -march=i686 -pipe  -std=c99 -Wall -Wextra -Wimplicit -Wshadow -Wformat=2 -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -Wmissing-format-attribute -Wnested-externs -Winline -Wwrite-strings -Wcast-align -Wcast-qual -Wpointer-arith -Wdeclaration-after-statement -Wsequence-point  -I../includes -I../librc -I../libeinfo  -D_BSD_SOURCE -D_XOPEN_SOURCE=600 -DHAVE_TERMCAP -DHAVE_PAM -c rc.c -o rc.o
rc.c: In function ‘proc_getent’:
rc.c:179: error: ‘COMMAND_LINE_SIZE’ undeclared (first use in this function)
rc.c:179: error: (Each undeclared identifier is reported only once
rc.c:179: error: for each function it appears in.)


Reproducible: Always

Steps to Reproduce:
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-07-06 11:10:43 UTC
Please post your "emerge --info" and attach the build.log file of the failed emerge to this bug.
Comment 2 Rafał Mużyło 2009-07-06 11:51:22 UTC
My private guess is:
kernel headers 2.6.30.
That's cause COMMAND_LINE_SIZE there is inside
#ifdef __KERNEL__, so either we undo kernel change,
or openrc will have to get that const in a different way.
Comment 3 ruckc 2009-07-06 16:36:10 UTC
This is happening to me also.  Here is my emerge --info

(ch) livecd / # emerge --info
Portage 2.1.6.13 (default/linux/amd64/2008.0/server, gcc-4.3.2, glibc-2.10.1-r0, 2.6.29-gentoo-r5 x86_64)
=================================================================
System uname: Linux-2.6.29-gentoo-r5-x86_64-AMD_Athlon-tm-_64_X2_Dual_Core_Processor_4400+-with-glibc2.2.5
Timestamp of tree: Mon, 06 Jul 2009 05:00:01 +0000
app-shells/bash:     4.0_p24
dev-lang/python:     2.5.4-r2
sys-apps/baselayout: 2.0.1
sys-apps/sandbox:    1.6-r2
sys-devel/autoconf:  2.63-r1
sys-devel/automake:  1.10.2, 1.11
sys-devel/binutils:  2.19.1-r1
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.30
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=athlon64"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O2 -pipe -march=athlon64"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks fixpackages parallel-fetch protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://ftp.daum.net/gentoo/ http://ftp.lecl.net/pub/gentoo/ http://mirror.pacific.net.au/linux/Gentoo"
LDFLAGS="-Wl,-O1"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="acl amd64 apache2 bash-completion berkdb bzip2 cli cracklib crypt cups dri fortran gdbm iconv isdnlog ldap mailwrapper midi mmx mudflap multilib mysql ncurses nls nptl nptlonly openmp pam pcre perl pppd python readline reflection session snmp spl sse sse2 ssl sysfs tcpd truetype unicode xml xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="fbdev glint i810 intel mach64 mga neomagic nv r128 radeon savage sis tdfx trident vesa vga via vmware voodoo"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LANG, LC_ALL, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY
Comment 4 Rafał Mużyło 2009-07-06 23:26:37 UTC
*** Bug 276824 has been marked as a duplicate of this bug. ***
Comment 5 Nikitas Skembris 2009-07-07 03:17:19 UTC
Indeed, Rafał Mużyło is right. The problem occurs only with sys-kernel/linux-headers-2.6.30.

By downgrading to sys-kernel/linux-headers-2.6.29, sys-apps/openrc-0.4.3-r3 compiles fine.

Maybe placing a block till the proper solution is decided would be a good idea?
Comment 7 Oleg Pereverzev 2009-07-07 14:16:51 UTC
(In reply to comment #6)
> http://roy.marples.name/projects/openrc/ticket/177
> http://roy.marples.name/projects/openrc/changeset/6abeec74301d8406ebbbd653b9fe9a0e234c09bf
> 

I have this bug on .29 kernel also, and i was just installing gentoo.
When i run 'emerge -uD world' sysvinit deactivated, and openrc failed to compile, so i have no working gentoo now. Good entrance too new distro, heh
Comment 8 Oleg Pereverzev 2009-07-07 14:18:10 UTC
Ooops, that was to #5 comment
Comment 9 Daniel Robbins 2009-07-07 16:55:38 UTC
The bug appears to be with linux-headers-2.6.30 itself. It does not contain a definition for COMMAND_LINE_SIZE (which should be defined in asm/setup.h). I grepped the full 2.6.30 linux kernel sources and COMMAND_LINE_SIZE hasn't gone anywhere.
Comment 10 Daniel Robbins 2009-07-07 17:03:05 UTC
COMMAND_LINE_SIZE seems to be defined in the gentoo linux-headers-base source tarball, so this looks like some kind of installation or Makefile failure where the proper arch-dependent COMMAND_LINE_SIZE is not being copied to asm/setup.h, and an empty version of asm/setup.h is getting installed instead.
Comment 11 Rafał Mużyło 2009-07-08 00:18:14 UTC
*** Bug 276976 has been marked as a duplicate of this bug. ***
Comment 12 Rafał Mużyło 2009-07-08 00:33:29 UTC
I'll reiterate:
it's due to #ifdef __KERNEL__ -
when kernel headers are installed those sections are stripped,
as they're meant for kernel compilation only.

It's bit like bug 252721, only I doubt that kernel upstream
would consider this a bug.
Comment 13 caslca 2009-07-08 08:09:18 UTC
it appears there is a patch from the openrc team:
http://roy.marples.name/projects/openrc/changeset/6abeec74301d8406ebbbd653b9fe9a0e234c09bf

Comment 14 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-07-08 08:09:58 UTC
Created attachment 197153 [details, diff]
openrc-0.4.3-command-line-size-fix.diff

Please give this patch a thorough testing as I don't have >=linux-headers-2.6.29 installed on any of my systems. I can only say that openrc-0.4.3 + this patch compiled without any problems on my machine and the machine still (re)boots as good as before.
Comment 15 ruckc 2009-07-08 08:17:09 UTC
Also, the -9999 ebuild compiles and appears from the outset to work perfect.
Comment 16 Fernando (likewhoa) 2009-07-10 13:20:31 UTC
(In reply to comment #14)
> Created an attachment (id=197153) [edit]
> openrc-0.4.3-command-line-size-fix.diff
> 
> Please give this patch a thorough testing as I don't have
> >=linux-headers-2.6.29 installed on any of my systems. I can only say that
> openrc-0.4.3 + this patch compiled without any problems on my machine and the
> machine still (re)boots as good as before.
> 

Patch applies fine with sys-apps/openrc-0.4.3-r3 here.

(In reply to comment #15)
> Also, the -9999 ebuild compiles and appears from the outset to work perfect.
> 

Yea tried with openrc-9999 but that build excludes net.lo see http://roy.marples.name/projects/openrc/ticket/186 for fix

Comment 17 hirakendu 2009-07-10 19:11:12 UTC
compiles with the patch in #14 :). will run later. aside, are any other packages broken by the linux-headers-2.6.30?
Comment 18 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-07-10 22:32:46 UTC
vapier: add to the -r3 ebuild please.
Comment 19 Nicholas J. Michalek 2009-07-11 06:05:03 UTC
(just adding CC... I wanna know when this is properly resolved in-tree)
Comment 20 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-07-11 15:14:24 UTC
InCVS.