Bug 276187 – [PATCH] x11-base/xorg-server-1.6.1.901-r5: dri2 is always disabled because of bad configure.ac

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Naohiro Aota 2009-07-02 10:28:01 UTC]

You may find these line in xorg-server-1.6.1.901/configure.ac

> AM_CONDITIONAL(DRI2, test "x$DRI2" == xyes)
> AM_CONDITIONAL(DRI2_AIGLX, test "x$DRI2_AIGLX" == xyes)

These test won't work well on FreeBSD's /bin/sh (and clearly this
doesn't follow POSIX manner)

This cause dri2 always disabled, and cause some packages
(e.g. xf86-video-intel) to build failure.


Reproducible: Always

Steps to Reproduce:
1. USE='-minimal' emerge =x11-base/xorg-server-1.6.1.901-r5



Actual Results:  
You may find dri2 files (e.g. /usr/include/xorg/dri2.h) not installed.


Expected Results:  
Must install dri2 files.

[Comment 1 Naohiro Aota 2009-07-02 10:29:06 UTC]

Created attachment 196332 [details, diff]
patch for ebuild to fix the problem

I could get dri2 files installed with the attached patch.

[Comment 2 Alexis Ballier 2009-07-02 10:37:23 UTC]

Such a change is probably worth having globally and submitted upstream; replacing test == constructions by test =

[Comment 3 Rémi Cardona (RETIRED) 2009-07-08 12:32:46 UTC]

Reassigning to x11 so I don't lose track of it, I'll try to commit something upstream.

Thanks

[Comment 4 Rémi Cardona (RETIRED) 2009-07-08 13:04:10 UTC]

Fixed in 1.6.2. Beware though, I screwed up a bit so if 1.6.2 doesn't work on the first build, wait a bit, sync again and it should work.

Thanks

[Comment 5 Naohiro Aota 2009-07-17 11:08:20 UTC]

It seems it fixes only "configure.ac" and "configure" still have the
problem.

Maybe we need a line "SNAPSHOT=yes" to regenerage "configure" or
another patch for "configure".

[Comment 6 Rémi Cardona (RETIRED) 2009-07-17 11:50:10 UTC]

The ebuild now calls eautoreconf after patching. Fixed without a revbump in 1.6.2-r1.

Thanks